Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direction for missing "nodeProgramClasses" entry #1248

Closed
wants to merge 1 commit into from

Conversation

SephReed
Copy link
Contributor

@SephReed SephReed commented May 21, 2022

I copied an example project, and decided I didn't feel like copying over all the different nodeProgramClasses. When I ran my project, I got a strange error with an untraceable call stack. By adding this small check, no such confusion will ever have to happen again.

main.ts:8 Uncaught TypeError: Cannot read properties of undefined (reading 'process')
at Sigma.process (main.ts:8:40)
at new Sigma (main.ts:8:40)
at SigmaSentimentGraph.initRenderer (SigmaGraph.view.ts:80:10)
at SentimentMatrix.view.ts:12:26

Pull request type

Check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

NOTE: Before to create a PR, read our contributing guide

NOTE: Try to limit your pull request to one type, submit multiple pull requests if needed.

What is the current behavior?

Issue Number: N/A

NOTE: Describe the current behavior that you are modifying, or link to a relevant issue.

What is the new behavior?

NOTE: Describe the behavior or changes that are being added by this PR.

Other information

NOTE: Any other information that is important to this PR such as screenshots of how the component looks before and after the change.

I copied an example project, and decided I didn't feel like copying over all the different `nodeProgramClasses`.  When I ran my project, I got a strange error with an untraceable call stack.  By adding this small check, no such confusion will ever have to happen again.

> main.ts:8 Uncaught TypeError: Cannot read properties of undefined (reading 'process')
>    at Sigma.process (main.ts:8:40)
>    at new Sigma (main.ts:8:40)
>    at SigmaSentimentGraph.initRenderer (SigmaGraph.view.ts:80:10)
>    at SentimentMatrix.view.ts:12:26
@stale
Copy link

stale bot commented Jun 30, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jun 30, 2022
@SephReed
Copy link
Contributor Author

SephReed commented Jul 8, 2022

Hey Bot! Couldn't a person at least read this!?

@stale stale bot removed the wontfix label Jul 8, 2022
@stale
Copy link

stale bot commented Aug 17, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Aug 17, 2022
@sim51 sim51 added enhancement and removed wontfix labels Aug 17, 2022
sim51 added a commit that referenced this pull request Aug 17, 2022
@sim51
Copy link
Collaborator

sim51 commented Aug 17, 2022

It has been merged .

Thanks for your contribution !

@sim51 sim51 closed this Aug 17, 2022
boogheta pushed a commit to boogheta/sigma.js that referenced this pull request Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants