Fixing GEXF parsing in IE #59

Merged
merged 1 commit into from Apr 3, 2013

Conversation

Projects
None yet
4 participants
@tjdett
Contributor

tjdett commented Nov 8, 2012

IE apparently doesn't support getElementsByTagNameNS for XML documents.

This patch simply skips using getElementsByTagNameNS when it isn't supported. Any edge cases caught by getElementsByTagNameNS will obviously not be caught in IE, but this is probably better behaviour than not working at all.

Fixing GEXF parsing in IE.
IE apparently doesn't support getElementsByTagNameNS for XML documents.
@jakobzhao

This comment has been minimized.

Show comment Hide comment
@jakobzhao

jakobzhao Nov 8, 2012

finally!

On Wed, Nov 7, 2012 at 8:34 PM, Tim Dettrick notifications@github.comwrote:

IE apparently doesn't support getElementsByTagNameNS for XML documents.

You can merge this Pull Request by running:

git pull https://github.com/tjdett/sigma.js fix-ie-gexf

Or view, comment on, or merge it at:

#59
Commit Summary

  • Fixing GEXF parsing in IE.

File Changes

  • M plugins/sigma.parseGexf.js (16)

Patch Links

Bo Zhao
Site: www.yenching.org
Coordinates: 40°0'3.46"N 83°0'44.34"W
Tel: +1-614-477-3557 (US) +86-18792701774 (China)

finally!

On Wed, Nov 7, 2012 at 8:34 PM, Tim Dettrick notifications@github.comwrote:

IE apparently doesn't support getElementsByTagNameNS for XML documents.

You can merge this Pull Request by running:

git pull https://github.com/tjdett/sigma.js fix-ie-gexf

Or view, comment on, or merge it at:

#59
Commit Summary

  • Fixing GEXF parsing in IE.

File Changes

  • M plugins/sigma.parseGexf.js (16)

Patch Links

Bo Zhao
Site: www.yenching.org
Coordinates: 40°0'3.46"N 83°0'44.34"W
Tel: +1-614-477-3557 (US) +86-18792701774 (China)

@tjdett

This comment has been minimized.

Show comment Hide comment
@tjdett

tjdett Nov 8, 2012

Contributor

Looks like this fixes #16 and #45.

Contributor

tjdett commented Nov 8, 2012

Looks like this fixes #16 and #45.

@computermacgyver

This comment has been minimized.

Show comment Hide comment
@computermacgyver

computermacgyver Feb 6, 2013

Contributor

Another solution is to use json (#73)

Contributor

computermacgyver commented Feb 6, 2013

Another solution is to use json (#73)

@jacomyal jacomyal merged commit 3e3e8d2 into jacomyal:master Apr 3, 2013

@mattcg mattcg referenced this pull request Apr 8, 2013

Merged

Support viz:* in GEXF in IE #90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment