[Cypher plugin]: Correct documentation #677

Merged
merged 2 commits into from Jan 31, 2016

Projects

None yet

2 participants

@sim51
Collaborator
sim51 commented Nov 26, 2015

Change 'sigma.parsers.cypher' to 'sigma.neo4j.cypher'

@sim51 sim51 [Cypher plugin]: Correct documentation
Change 'sigma.parsers.cypher' to 'sigma.neo4j.cypher'
f4e4d55
@Yomguithereal
Collaborator

Hello @sim51.You are right indeed concerning the erroneous documentation. But while we're there, shouldn't the plugin use the sigma.parsers.cypher namespace to remain coherent with its folder and the other namespaces?

@sim51
Collaborator
sim51 commented Nov 30, 2015

Hi,
You have right for the cypher function, but there is also some helper functions for the communication between sigma & neo.
Can I keep sigma.neo for them, and only put the cypher parser function into sigma.parsers package ? What do you think ?
Cheers.

@Yomguithereal
Collaborator

I guess you could migrate all the plugin to the neo4j namespace since we are not "parsing" anything here strictly speaking. @jacomyal, what's your opinion?

@sim51 sim51 [Cypher plugin]: PR #677
Change the package name of the plugin.
1b75fe5
@Yomguithereal
Collaborator

Thanks you very much @sim51 :)?

@Yomguithereal Yomguithereal merged commit 85c65ad into jacomyal:master Jan 31, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment