MakeMaker.pm: Search for libssh2 includes and libs in /usr/local (on FreeBSD) #50

Merged
merged 1 commit into from Jan 27, 2014

Projects

None yet

2 participants

@jacquesg
Owner

This "should" fix #49 (Untested). I did a slight more generic approach, as similar problems may start showing up on other platforms, notably Solaris.

It would be nice to make this even more configurable, I'll see if I can dream something up (that also works with Windows and MSVC).

@jacquesg
Owner

Ok, I'm 99% sure c9e5e22 will work

@ghedo ghedo merged commit c9e5e22 into jacquesg:master Jan 27, 2014

1 check passed

Details default The Travis CI build passed
@ghedo
Collaborator

I'm not totally convinced hard-coding paths is the correct way to fix this, but I guess pkg-config isn't that much of a solution either considering that it may not be installed.

Another alternative would be to have Devel::CheckLib check for the header too: the build will succeed but without ssh support.

Oh well, I guess we can fix this later if we find a better solution.

@jacquesg
Owner

I think it is safe to provide some reasonable default hard coded values. On FreeBSD, if you use ports, the libraries will be in /usr/local, dito for Solaris (/opt/csw).

As I mentioned, it would be nice to override these locations if the libraries are installed in some non-conventional / non-standard location.

@jacquesg jacquesg deleted the unknown repository branch Apr 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment