Set cake version #7

Closed
damusnet opened this Issue Mar 6, 2012 · 2 comments

Comments

Projects
None yet
2 participants
Contributor

damusnet commented Mar 6, 2012

Hello,

I just realized how much you had improved capcake lately by merging all commits and upgrading for CakePHP v2, so thanks a lot!

However, I just encountered an issue: :set cake_branch, "1.3" does not override set :cake2 to false so I had to change it manually in my deploy.rb. So either this setting should be moved there, or even better, a check should occur based on the branch.

No time to write the fix today, maybe later, but wanted to have your take on it before.

Owner

jadb commented Mar 6, 2012

Hey damusnet,

You are correct, it does not override it. When I initially did the update I didn't think of it as I didn't have to re-deploy any Cake 1.2 (or 1.3) since.

I think that your idea of changing the setting is a good one. A suggestion for you in case you have some time to code it in, how about having a kind of configuration for each cake version and replacing my "if..else..." by the appropriate config based on the branch? I know that there are only certain parts of the deployment strategy that need to act differently according to the version being used, parts that I believe can easily be pre-configured in one master configuration that would deal with previous, current and future versions (just edit the values of each basic default config).

I hope what I just explained made sense to you. And if so, what do you think?

Contributor

damusnet commented Mar 9, 2012

I think it's a good idea. However, I lack knowledge of other CakePHP versions, since I currently only use 1.3
Still I'll try and look into it.

jadb closed this Jan 29, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment