Introducing a core config namespace #8

Merged
merged 1 commit into from Jan 29, 2016

Projects

None yet

2 participants

Contributor
damusnet commented Mar 9, 2012

I reintroduced the ability to separate local core.php config file from production one in a cleaner way.

Owner
jadb commented Mar 13, 2012

Thanks, maybe I am missing something.

How are you separating the local core.php from the one being deployed exactly? I see that you are merely moving the core.php file tracked by the repo (which means the same one exists in your local clone) into the shared path. Maybe I am missing something?

Usually speaking, files that end up in the shared path are not tracked by the repo. In core.php case, the file wouldn't be tracked by the repo, another version of it like core.php.example would be tracked and a modified copy of it would be stored remotely in the shared path before symlink-ing to it from the latest deployed release.

Contributor

Moving the core.php file tracked by the repo into the shared path only occurs at config time (first time) or if manually triggered. Then, at each deploy, the core.php file tracked by the repo will be deleted and a symlink will be created to the shared one. Same as for the database.php file actually, only without the config prompt. This means that you have to get your core.php file right before the first deploy, or manually change it afterwards, or manually update it.

@jadb jadb merged commit efeea99 into jadb:master Jan 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment