Skip to content
This repository has been archived by the owner on Sep 13, 2022. It is now read-only.

No compact format #324

Closed
yepninja opened this issue Dec 7, 2018 · 4 comments
Closed

No compact format #324

yepninja opened this issue Dec 7, 2018 · 4 comments

Comments

@yepninja
Copy link
Contributor

yepninja commented Dec 7, 2018

Requirement - what kind of business use case are you trying to solve?

Use the same format of reported data. Go client library uses compact format. Jaeger env variable for agent port is set up for compact format.

Problem - what in Jaeger blocks you from solving the requirement?

Nodejs client uses binary format. And I cann't switch to compact format.

Proposal - what do you suggest to solve the problem or improve the existing situation?

Support change the format.

Any open questions to address

@yurishkuro
Copy link
Member

As I recall, at he time there was no support for compact format in the thrift lib we're using. What is your justification for needing it?

@fho
Copy link

fho commented Oct 10, 2019

As I understand the ticket, the point is to align the jaeger nodejs and golang libraries.
If a variable of the jaeger-libs has the same name I assume that the same value is expected.
(I stumbled about the issue myself some minutes ago.)

But:
JAEGER_AGENT_PORT for jaeger-client-node expects port 6832 (binary thrift)
JAEGER_AGENT_PORT for jaeger-client-go expects port 6831 (compact thrift)

@yurishkuro
Copy link
Member

yurishkuro commented Oct 10, 2019

The port discrepancy is a separate issue that can be addressed by auto-detecting the format jaegertracing/jaeger#1596.

@yurishkuro
Copy link
Member

Doesn't look like we'll be able to solve this here, closing.

Iuriy-Budnikov pushed a commit to agile-pm/jaeger-client-node that referenced this issue Sep 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants