Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add max traces and compute resource parameters #102

Merged
merged 3 commits into from Feb 26, 2019

Conversation

@etoews
Copy link
Contributor

commented Feb 25, 2019

Add parameters in the template to constrain the maximum number of
traces and the amount of CPU/Memory consumed. This provides guardrails
to prevent over-utilization of CPU/Memory on a node which is known to
cause instability. Even in a non-production environment, such
guardrails are critical.

Signed-off-by: Everett Toews everett.toews@gmail.com

Which problem is this PR solving?

Resolves #101

Short description of the changes

As per the PR description above.

etoews added some commits Feb 25, 2019

Add max traces and compute resource parameters
Add parameters in the template to constrain the maximum number of
traces and the amount of CPU/Memory consumed. This provides guardrails
to prevent over-utilization of CPU/Memory on a node which is known to
cause instability. Even in a non-production environment, such
guardrails are critical.

Signed-off-by: Everett Toews <everett.toews@gmail.com>
Bump copyright to 2019
Signed-off-by: Everett Toews <everett.toews@gmail.com>
@jpkrohling
Copy link
Member

left a comment

LGTM, except for the default MAX_TRACES, which seems too conservative to be useful, IMO.

all-in-one/jaeger-all-in-one-template.yml Outdated Show resolved Hide resolved
Increase default max traces to 50000
Signed-off-by: Everett Toews <everett.toews@gmail.com>

@jpkrohling jpkrohling merged commit 4e82454 into jaegertracing:master Feb 26, 2019

3 checks passed

DCO DCO
Details
WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jpkrohling

This comment has been minimized.

Copy link
Member

commented Feb 26, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.