Skip to content
This repository has been archived by the owner. It is now read-only.

Add max traces and compute resource parameters #102

Merged
merged 3 commits into from Feb 26, 2019

Conversation

@etoews
Copy link
Contributor

@etoews etoews commented Feb 25, 2019

Add parameters in the template to constrain the maximum number of
traces and the amount of CPU/Memory consumed. This provides guardrails
to prevent over-utilization of CPU/Memory on a node which is known to
cause instability. Even in a non-production environment, such
guardrails are critical.

Signed-off-by: Everett Toews everett.toews@gmail.com

Which problem is this PR solving?

Resolves #101

Short description of the changes

As per the PR description above.

etoews added 2 commits Feb 25, 2019
Add parameters in the template to constrain the maximum number of
traces and the amount of CPU/Memory consumed. This provides guardrails
to prevent over-utilization of CPU/Memory on a node which is known to
cause instability. Even in a non-production environment, such
guardrails are critical.

Signed-off-by: Everett Toews <everett.toews@gmail.com>
Signed-off-by: Everett Toews <everett.toews@gmail.com>
Copy link
Member

@jpkrohling jpkrohling left a comment

LGTM, except for the default MAX_TRACES, which seems too conservative to be useful, IMO.

Loading

all-in-one/jaeger-all-in-one-template.yml Outdated Show resolved Hide resolved
Loading
Signed-off-by: Everett Toews <everett.toews@gmail.com>
@jpkrohling jpkrohling merged commit 4e82454 into jaegertracing:master Feb 26, 2019
3 checks passed
Loading
@jpkrohling
Copy link
Member

@jpkrohling jpkrohling commented Feb 26, 2019

Thanks!

Loading

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants