Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inject sidecars in other controllers #750

Closed
2 of 5 tasks
ptescher opened this issue Nov 8, 2019 · 11 comments
Closed
2 of 5 tasks

Inject sidecars in other controllers #750

ptescher opened this issue Nov 8, 2019 · 11 comments
Labels
duplicate enhancement question

Comments

@ptescher
Copy link

@ptescher ptescher commented Nov 8, 2019

For instance, on OpenShift if we are using DeploymentConfigs instead of Deployments we cant auto inject jaeger sidecars. With the latest Istio setup on OpenShift daemonsets are deprecated, so this becomes more important.

Places I can think of where sidecars could be injected:

  • Deployments
  • StatefulSets
  • DaemonSets
  • DeploymentConfigs (OpenShift)
  • CronJobs

I think #171 would solve this for all controllers (as well as pods without a controller).

@jpkrohling
Copy link
Contributor

@jpkrohling jpkrohling commented Nov 13, 2019

One of the motivations behind #171 is indeed to be able to inject sidecars into any workload that is backed by pods, but it adds some complexity to the setup. Unfortunately, this can't be currently covered by OLM (to the best of our knowledge), so, it's currently a blocker for us.

If you absolutely require support for DeploymentConfigs, we could discuss about adding it to the current mechanism, but it will bring quite some maintenance burden.

@jpkrohling jpkrohling added duplicate enhancement question labels Nov 13, 2019
@jpkrohling
Copy link
Contributor

@jpkrohling jpkrohling commented Nov 13, 2019

I'm marking as "duplicate", as I'm sure we talked about this in the past.

@ptescher
Copy link
Author

@ptescher ptescher commented Nov 13, 2019

I just added the sidecars manually for now, which works for small deployments. Not a blocker.

@ptescher
Copy link
Author

@ptescher ptescher commented Nov 13, 2019

I just added the sidecars manually for now, which works for small deployments. Not a blocker. While #171 can't be dealt with purely on OLM, it looks like the actual complexity of the webhook (the ca bundle, etc) can be. The actual injector is relatively simple and could be run as its own service.

@jpkrohling
Copy link
Contributor

@jpkrohling jpkrohling commented Nov 14, 2019

Apparently, support for mutating webhook is coming to the operator SDK in the future. Once it is there, we should certainly re-evaluate this!

@jpkrohling jpkrohling added needs-triage and removed needs-triage labels Dec 16, 2019
@mumrau
Copy link

@mumrau mumrau commented Jan 13, 2020

It is a blocker for some usages, we like to deploy our artifcats the same way, using one single "rule them all" pipeline, which makes it impossible for us, as of today, to unify completely, because our periodic jobs do not receive their associated sidecar. We have to rely on a DaemonSet "ring" of agents to which our workloads connects.
I am sure we are not the only ones trying to unify their workloads deployment strategies in terms of labels, annotations, URLs and such, that's why I believe this can be a very valuable feature.

Maybe regular one off Job(s) could benefit from this feature eventually?

@mumrau
Copy link

@mumrau mumrau commented Jan 14, 2020

Oh I might add, I'm now programatically adding the sidecar agent when generating the cronjob, using my conventionnal --reporter.grpc.host-port=dns://my-jaeger-collector-headless.ns-jaeger:14250.

Worth noting, when the job finishes, the jaeger-agent doesn't exit and thus the job doesn't complete because of the sidecar nature of the agent (discussed more widely over there: kubernetes/kubernetes#25908 .

I am just giving this as a sidenote to be kept in mind, I'll fall back to another mode of functionning for .my jobs

@sergeyshaykhullin
Copy link

@sergeyshaykhullin sergeyshaykhullin commented Jun 12, 2020

Can operator start supporting inject in ArgoCD Rollouts? https://argoproj.github.io/argo-rollouts/

@jpkrohling
Copy link
Contributor

@jpkrohling jpkrohling commented Jun 15, 2020

As I understood, ArgoCD Rollouts create ReplicaSets. As such, it should work once #171 is there.

@vassilvk
Copy link

@vassilvk vassilvk commented Oct 18, 2020

Just wanted to chime in here - while #171 is being worked on, an alternative solution is now available through KubeMod (as described in my comment).

@pavolloffay
Copy link
Member

@pavolloffay pavolloffay commented Mar 21, 2022

#171 will allow injecting to all pods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate enhancement question
Projects
None yet
Development

No branches or pull requests

6 participants