From 0187d1cc379e21eeada0d8d5e6a4b848e4ce60a2 Mon Sep 17 00:00:00 2001 From: Ivan Babrou Date: Thu, 15 Feb 2024 20:08:31 -0800 Subject: [PATCH] Use JSON for table values only for objects Without this numbers are treated as json, which styles them with an offset. Signed-off-by: Ivan Babrou --- .../TraceTimelineViewer/SpanDetail/KeyValuesTable.tsx | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/SpanDetail/KeyValuesTable.tsx b/packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/SpanDetail/KeyValuesTable.tsx index 686e651668..69ee4f1e06 100644 --- a/packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/SpanDetail/KeyValuesTable.tsx +++ b/packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/SpanDetail/KeyValuesTable.tsx @@ -66,11 +66,9 @@ function formatValue(key: string, value: any) { parsed = tryParseJson(value); } - if (typeof parsed === 'string') { - content = stringMarkup(parsed); - } else if (Array.isArray(parsed) && shouldDisplayAsStringList(key)) { + if (Array.isArray(parsed) && shouldDisplayAsStringList(key)) { content = stringListMarkup(parsed); - } else { + } else if (typeof parsed == 'object') { const shouldJsonTreeExpand = Object.keys(parsed).length <= 10; content = ( @@ -95,6 +93,8 @@ function formatValue(key: string, value: any) { }} /> ); + } else { + content = stringMarkup(parsed); } return
{content}
;