From 2cad4130f730575e879722a77da8a67690e48ec9 Mon Sep 17 00:00:00 2001 From: Deren <64274085+DerenToy@users.noreply.github.com> Date: Wed, 25 Oct 2023 20:29:50 +0300 Subject: [PATCH] Fix linting warnings for all no-unused-vars (#1913) ## Which problem is this PR solving? - Resolves part of no-unused-vars warnings for #1608 ## Description of the changes - Unused variables have been removed ## How was this change tested? - By running "yarn lint" command ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` --- .../jaeger-ui/src/components/SearchTracePage/SearchForm.test.js | 2 -- .../components/TracePage/TracePageHeader/AltViewOptions.test.js | 1 - .../TracePage/TraceTimelineViewer/VirtualizedTraceView.tsx | 2 +- 3 files changed, 1 insertion(+), 4 deletions(-) diff --git a/packages/jaeger-ui/src/components/SearchTracePage/SearchForm.test.js b/packages/jaeger-ui/src/components/SearchTracePage/SearchForm.test.js index 86a669e36d..495902a8d4 100644 --- a/packages/jaeger-ui/src/components/SearchTracePage/SearchForm.test.js +++ b/packages/jaeger-ui/src/components/SearchTracePage/SearchForm.test.js @@ -54,8 +54,6 @@ function makeDateParams(dateOffset = 0) { }; } -const DATE_FORMAT = 'YYYY-MM-DD'; -const TIME_FORMAT = 'HH:mm'; const defaultProps = { dataCenters: ['dc1'], handleSubmit: () => {}, diff --git a/packages/jaeger-ui/src/components/TracePage/TracePageHeader/AltViewOptions.test.js b/packages/jaeger-ui/src/components/TracePage/TracePageHeader/AltViewOptions.test.js index 2de6ee2cf8..2cd81aa0de 100644 --- a/packages/jaeger-ui/src/components/TracePage/TracePageHeader/AltViewOptions.test.js +++ b/packages/jaeger-ui/src/components/TracePage/TracePageHeader/AltViewOptions.test.js @@ -15,7 +15,6 @@ import * as React from 'react'; import { shallow } from 'enzyme'; import { Dropdown } from 'antd'; -import { Link } from 'react-router-dom'; import AltViewOptions from './AltViewOptions'; import * as track from './TracePageHeader.track'; import { ETraceViewType } from '../types'; diff --git a/packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/VirtualizedTraceView.tsx b/packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/VirtualizedTraceView.tsx index e0cfbeecba..f3ecb97879 100644 --- a/packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/VirtualizedTraceView.tsx +++ b/packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/VirtualizedTraceView.tsx @@ -372,7 +372,7 @@ export class VirtualizedTraceViewImpl extends React.Component