From 551db4cec5ea460d7356e7c448610535ad15860e Mon Sep 17 00:00:00 2001 From: Yuri Shkuro Date: Fri, 25 Dec 2020 16:27:51 -0500 Subject: [PATCH] Display references unless it's a single CHILD_OF (#672) --- .../TraceTimelineViewer/SpanDetail/index.tsx | 20 ++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/SpanDetail/index.tsx b/packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/SpanDetail/index.tsx index f61282f680..ee5d4c12d1 100644 --- a/packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/SpanDetail/index.tsx +++ b/packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/SpanDetail/index.tsx @@ -17,6 +17,7 @@ import { Divider } from 'antd'; import AccordianKeyValues from './AccordianKeyValues'; import AccordianLogs from './AccordianLogs'; +import AccordianReferences from './AccordianReferences'; import AccordianText from './AccordianText'; import DetailState from './DetailState'; import { formatDuration } from '../utils'; @@ -27,7 +28,6 @@ import { TNil } from '../../../../types'; import { KeyValuePair, Link, Log, Span } from '../../../../types/trace'; import './index.css'; -import AccordianReferences from './AccordianReferences'; type SpanDetailProps = { detailState: DetailState; @@ -140,14 +140,16 @@ export default function SpanDetail(props: SpanDetailProps) { onToggle={() => warningsToggle(spanID)} /> )} - {references && references.length > 1 && ( - referencesToggle(spanID)} - focusSpan={focusSpan} - /> - )} + {references && + references.length > 0 && + (references.length > 1 || references[0].refType !== 'CHILD_OF') && ( + referencesToggle(spanID)} + focusSpan={focusSpan} + /> + )} {spanID}