From 5ec5ac2f2ec93f13e0f2b55942d9291a1eb29dca Mon Sep 17 00:00:00 2001 From: Ruben Vargas Date: Fri, 22 Feb 2019 15:28:42 -0500 Subject: [PATCH] Rename showChildrenStatus attribute from SpanTreeOffset to showChildrenIcon Signed-off-by: Ruben Vargas --- .../TracePage/TraceTimelineViewer/SpanDetailRow.js | 2 +- .../TracePage/TraceTimelineViewer/SpanDetailRow.test.js | 2 +- .../TracePage/TraceTimelineViewer/SpanTreeOffset.js | 8 ++++---- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/SpanDetailRow.js b/packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/SpanDetailRow.js index d30c77f3e8..3ac9f115d0 100644 --- a/packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/SpanDetailRow.js +++ b/packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/SpanDetailRow.js @@ -65,7 +65,7 @@ export default class SpanDetailRow extends React.PureComponent - + ', () => { }); it('renders the span tree offset', () => { - const spanTreeOffset = ; + const spanTreeOffset = ; expect(wrapper.contains(spanTreeOffset)).toBe(true); }); diff --git a/packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/SpanTreeOffset.js b/packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/SpanTreeOffset.js index 87deb13990..9bd0971886 100644 --- a/packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/SpanTreeOffset.js +++ b/packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/SpanTreeOffset.js @@ -37,7 +37,7 @@ type SpanTreeOffsetPropsType = { onClick: ?() => void, removeHoverIndentGuideId: string => void, span: Span, - showChildrenStatus: boolean, + showChildrenIcon: boolean, }; export class UnconnectedSpanTreeOffset extends React.PureComponent { @@ -47,7 +47,7 @@ export class UnconnectedSpanTreeOffset extends React.PureComponent : ); + showChildrenIcon && hasChildren && (childrenVisible ? : ); return ( {this.ancestorIds.map(ancestorId => (