Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot find operations if there is '/' char in serviceName #138

Closed
yurishkuro opened this issue Dec 17, 2017 · 4 comments

Comments

Projects
None yet
3 participants
@yurishkuro
Copy link
Member

commented Dec 17, 2017

Re-booking jaegertracing/jaeger#586

The UI must url-encode service name when calling the API to retrieve operation names: /api/services/{service}/operations. It does some encoding, but not correctly, e.g.

  • one of our internal services is emitting a bad service name ${artifactId}, and the API request looked like this /api/services/$%7BartifactId%7D/operations, which is ok
  • however, when the service name contains a slash like hotrod/customer, the slash is not encoded correctly: http://localhost:16686/api/services/hotrod/customer/operations

Incidentally, the API supports an alternative endpoint /api/operations?service={service}, we should decide which one we want to keep.

@acehko

This comment has been minimized.

Copy link

commented Feb 16, 2018

Has this been fixed in the docker images?
I just tested with 1.2.0 and latest and the issue still exists.

@tiffon

This comment has been minimized.

Copy link
Member

commented Feb 16, 2018

@yurishkuro yurishkuro reopened this Feb 16, 2018

@tiffon tiffon added the blocked label Mar 12, 2018

@tiffon

This comment has been minimized.

Copy link
Member

commented Mar 12, 2018

@yurishkuro after merging #140, I think this surfaced an issue in jaeger-query.

When running the hotrod demo with the service names to have jaeger/ prepended now results in the following GET HTTP call to the query service for service jaeger/customer:

http://localhost:16686/api/services/jaeger%2Fcustomer/operations

The query service responds with the index.html.

I'll add details to and re-open jaegertracing/jaeger#586.

@tiffon

This comment has been minimized.

Copy link
Member

commented Mar 12, 2018

Actually, I'm going to close this ticket so it's clear there isn't any outstanding UI work to resolve this.

@tiffon tiffon closed this Mar 12, 2018

@tiffon tiffon removed the blocked label Mar 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.