Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link in scatter plot when embed mode #282 #283

Merged
merged 1 commit into from Nov 28, 2018

Conversation

Projects
None yet
2 participants
@aljesusg
Copy link
Contributor

commented Nov 28, 2018

Which problem is this PR solving?

#282

Short description of the changes

Fix link in the scatter plot to the trace with embed mode

fix_scatter_plot

@codecov

This comment has been minimized.

Copy link

commented Nov 28, 2018

Codecov Report

Merging #283 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #283      +/-   ##
==========================================
+ Coverage   77.45%   77.52%   +0.06%     
==========================================
  Files         137      137              
  Lines        2976     2976              
  Branches      617      617              
==========================================
+ Hits         2305     2307       +2     
+ Misses        529      528       -1     
+ Partials      142      141       -1
Impacted Files Coverage Δ
.../jaeger-ui/src/components/SearchTracePage/index.js 89.65% <100%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f50592b...e1bbe6d. Read the comment docs.

Fix link in scatter plot when embed mode #282
Signed-off-by: Alberto Gutierrez <aljesusg@gmail.com>

@aljesusg aljesusg force-pushed the aljesusg:issue_282 branch from 63ea39e to e1bbe6d Nov 28, 2018

@aljesusg

This comment has been minimized.

Copy link
Contributor Author

commented Nov 28, 2018

@tiffon it's ready the fix :)

@tiffon

tiffon approved these changes Nov 28, 2018

Copy link
Member

left a comment

Great, thank you!

@tiffon tiffon merged commit fcd6bfd into jaegertracing:master Nov 28, 2018

5 checks passed

DCO DCO
Details
WIP Ready for review
Details
codecov/patch 100% of diff hit (target 77.45%)
Details
codecov/project 77.52% (+0.06%) compared to f50592b
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.