New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme files for Docker Hub #188

Open
pavolloffay opened this Issue May 31, 2017 · 7 comments

Comments

Projects
None yet
3 participants
@pavolloffay
Member

pavolloffay commented May 31, 2017

Readme files on Docker Hub https://hub.docker.com/r/jaegertracing should contain more information e.g. URL to the repository, which tags should be used etc.

@yurishkuro

This comment has been minimized.

Member

yurishkuro commented Jun 15, 2017

@pavolloffay when you say "readme files", is there some mechanism to provide that from this repo, or it's just a matter of going and editing the descriptions on Docker Hub?

Do you have a proposal of how the description should look like?

@pavolloffay

This comment has been minimized.

Member

pavolloffay commented Jun 15, 2017

Are we using automated builds? If so the readme from the docker file directory should be automatically used (If I remember correctly).

About the description, just a basic information, tags semantics, link to the git repository, nothing fancy.

@yurishkuro

This comment has been minimized.

Member

yurishkuro commented Jun 15, 2017

Sorry, what do you mean by automated builds? The docker images are built and published by Travis job.

@pavolloffay

This comment has been minimized.

Member

pavolloffay commented Jun 15, 2017

This https://docs.docker.com/docker-hub/builds/ you basically specify repo and dockerfile location, then the build is automatically triggered by github.

@yurishkuro

This comment has been minimized.

Member

yurishkuro commented Jun 16, 2017

No, we are not using automated builds. They seem to only work if the whole build is done via Docker file, but we're building the executables outside of the container and Dockerfile just copies them into the images.

@mabn

This comment has been minimized.

mabn commented Sep 12, 2017

If there were binaries released somewhere (e.g. to github) then it should be possible to create automated build which would just "ADD" the binary.

@pavolloffay

This comment has been minimized.

Member

pavolloffay commented Sep 25, 2017

This would work only for tagged versions. We push also latest per commit in master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment