Unify metric name and format in client libraries #572
running both golang and java service, and found out the metric name generated was different, for example, with prometheus:
Unify metric name and format in client libraries can help metric collector and monitor
The text was updated successfully, but these errors were encountered:
@yurishkuro Correct, the colon is "reserved" for end users, and should not be used in metric names as exposed by source. There is no technical namespace separator in Prometheus metrics right now. We've been considering it as part of OpenMetrics, but for now we don't have a solution.
We still have an issue with consistency across clients - only looking at Golang and Java currently:
There are common metrics across the two languages with consistent tags which is good. The Go client has some additional metrics based on throttling. Haven't looked at the rpc request metrics yet.
Therefore this should just be a renaming exercise:
One question would be - should the language be a tag, to enable metrics to be segmented by language if necessary?
Thoughts on the proposal?
Deleted my previous comment, it was redundant. ☕ lacking today.
The proposal looks good.
I don't see a reason to have different metric names per language. As long as metrics have the same meaning, they can remain the same.
If you had something that was java specific, I might namespace the metrics like