Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Consolidate query metrics and include result tag #1075
Signed-off-by: Gary Brown firstname.lastname@example.org
Which problem is this PR solving?
Currently jaeger-query produces a set of metrics for the following operations: find traces, get operations, get services and get trace.
The set of metrics are (only showing one bucket for histograms):
Errors and successes for latency and counters are separated out (including a further counter representing the total counts).
This PR consolidates the metrics to use common name with a
Short description of the changes
Have a single counter
Also combined the two latency based metrics and added a tag for result (ok/err).
NOTE: Have not included the
requested review from
Sep 20, 2018
@@ Coverage Diff @@ ## master #1075 +/- ## ====================================== Coverage 100% 100% ====================================== Files 140 140 Lines 6622 6625 +3 ====================================== + Hits 6622 6625 +3
jpkrohling left a comment
LGTM, but could you also add an entry to the changelog, mentioning that this is a breaking change? People relying on an existing metric name will get affected by this change.