Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dot replacement for int #1272

Merged
merged 1 commit into from Jan 3, 2019

Conversation

@pavolloffay
Copy link
Member

pavolloffay commented Jan 3, 2019

Resolves #1267

Signed-off-by: Pavol Loffay ploffay@redhat.com

Signed-off-by: Pavol Loffay <ploffay@redhat.com>
@pavolloffay pavolloffay force-pushed the pavolloffay:fix-dedotchar-int branch from 28a87c0 to ca97fbe Jan 3, 2019
@ghost ghost assigned pavolloffay Jan 3, 2019
@ghost ghost added the review label Jan 3, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 3, 2019

Codecov Report

Merging #1272 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1272   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files         160     160           
  Lines        7182    7182           
======================================
  Hits         7182    7182
Impacted Files Coverage Δ
plugin/storage/es/spanstore/dbmodel/to_domain.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe7352d...ca97fbe. Read the comment docs.

@objectiser objectiser merged commit ae36459 into jaegertracing:master Jan 3, 2019
5 checks passed
5 checks passed
DCO DCO
Details
WIP Ready for review
Details
codecov/patch 100% of diff hit (target 100%)
Details
codecov/project 100% (target 100%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ghost ghost removed the review label Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.