Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLI configurable MaxNumSpans while retrieving spans from ES. #1283

Merged
merged 3 commits into from Jan 17, 2019

Conversation

@annanay25
Copy link
Contributor

commented Jan 15, 2019

Signed-off-by: Annanay annanay.a@media.net

Which problem is this PR solving?

Short description of the changes

  • Added a CLI configurable option to limit the number of spans fetched in a single query to the ES backend.
Make MaxNumSpans CLI configurable
Signed-off-by: Annanay <annanay.a@media.net>

@wafflebot wafflebot bot added the review label Jan 15, 2019

@black-adder

This comment has been minimized.

Copy link
Collaborator

commented Jan 15, 2019

My only question is are we ok with changing behavior that people are used to? If people upgrade jaeger, they'll automatically be hit with the 10000 limit and not know about it. Perhaps if no limit is set, we don't apply a default limit?

@codecov

This comment has been minimized.

Copy link

commented Jan 15, 2019

Codecov Report

Merging #1283 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1283   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files         161     161           
  Lines        7198    7206    +8     
======================================
+ Hits         7198    7206    +8
Impacted Files Coverage Δ
plugin/storage/es/spanstore/reader.go 100% <100%> (ø) ⬆️
plugin/storage/es/options.go 100% <100%> (ø) ⬆️
plugin/storage/es/factory.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48b034c...9e4bb5f. Read the comment docs.

@annanay25

This comment has been minimized.

Copy link
Contributor Author

commented Jan 17, 2019

@black-adder; this makes sense.

However, we could mention the reasons for adopting such a limit in the docs (that it could overwhelm the query-service) and mention that it could be overwritten using the flag in the release notes.

@black-adder black-adder merged commit d64cb70 into jaegertracing:master Jan 17, 2019

3 checks passed

codecov/patch 100% of diff hit (target 100%)
Details
codecov/project 100% (target 100%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wafflebot wafflebot bot removed the review label Jan 17, 2019

@yurishkuro

This comment has been minimized.

Copy link
Member

commented Jan 18, 2019

please add to the changelog.

is the behavior actually different from before? I thought we already had another 10k limit in the code.

@yurishkuro yurishkuro referenced this pull request Jan 18, 2019

Closed

[tracking] Release 1.9 #1184

3 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.