Make Elasticsearch archive storage optional #1334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
pavolloffay
requested review from
black-adder,
jpkrohling,
objectiser,
tiffon,
vprithvi and
yurishkuro
as code owners
ghost
assigned 
Codecov Report
@@ Coverage Diff @@
## master #1334 +/- ##
======================================
Coverage 100% 100%
======================================
Files 162 162
Lines 7295 7308 +13
======================================
+ Hits 7295 7308 +13
Continue to review full report at Codecov.
|
objectiser
approved these changes
Feb 12, 2019
| @@ -206,6 +208,12 @@ func addFlags(flagSet *flag.FlagSet, nsConfig *namespaceConfig) { | |||
| "(experimental) Use read and write aliases for indices. Use this option with Elasticsearch rollover "+ | |||
| "API. It requires an external component to create aliases before startup and then performing its management. "+ | |||
| "Note that "+nsConfig.namespace+suffixMaxSpanAge+" is not taken into the account and has to be substituted by external component managing read alias.") | |||
| if nsConfig.namespace == archiveNamespace { | |||
There was a problem hiding this comment.
Just wondering if this needs to be conditional? The primary namespace is enabled by default, so it just means a user could disable the primary namespace, which is unlikely.
There was a problem hiding this comment.
I don't want to show this flag for the primary NS. We do the same for c*
iori-yja
pushed a commit
to iori-yja/jaeger
that referenced
this pull request
Feb 15, 2019
Signed-off-by: Pavol Loffay <ploffay@redhat.com> Signed-off-by: Iori Yoneji <fivo.11235813@gmail.com>
iori-yja
pushed a commit
to iori-yja/jaeger
that referenced
this pull request
Feb 15, 2019
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
iori-yja
pushed a commit
to iori-yja/jaeger
that referenced
this pull request
Feb 15, 2019
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1321 (comment)
Signed-off-by: Pavol Loffay ploffay@redhat.com