Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make grpc reporter default and add retry #1384

Merged
merged 6 commits into from Feb 27, 2019

Conversation

Projects
None yet
3 participants
@pavolloffay
Copy link
Member

commented Feb 26, 2019

Resolves #1218 #1229

Signed-off-by: Pavol Loffay ploffay@redhat.com

@ghost ghost assigned pavolloffay Feb 26, 2019

@ghost ghost added the review label Feb 26, 2019

@pavolloffay pavolloffay changed the title Make grpc reporter default and add retry WIP: Make grpc reporter default and add retry Feb 26, 2019

@codecov

This comment has been minimized.

Copy link

commented Feb 26, 2019

Codecov Report

Merging #1384 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1384   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files         164     164           
  Lines        7447    7453    +6     
======================================
+ Hits         7447    7453    +6
Impacted Files Coverage Δ
cmd/collector/app/builder/builder_flags.go 100% <100%> (ø) ⬆️
cmd/agent/app/reporter/grpc/flags.go 100% <100%> (ø) ⬆️
cmd/agent/app/reporter/flags.go 100% <100%> (ø) ⬆️
cmd/agent/app/reporter/grpc/collector_proxy.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 189cf70...f9a890b. Read the comment docs.

@pavolloffay pavolloffay changed the title WIP: Make grpc reporter default and add retry Make grpc reporter default and add retry Feb 26, 2019

pavolloffay added some commits Feb 26, 2019

Make grpc reporter default and add retry
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
Polish
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
Fix port
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
Polish
Signed-off-by: Pavol Loffay <ploffay@redhat.com>

@pavolloffay pavolloffay force-pushed the pavolloffay:make-grpc-default branch from 43008c4 to bfbf3bc Feb 26, 2019

Use higher retry
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
conn, _ := grpc.Dial(target,
grpc.WithInsecure(),
grpc.WithBalancerName(roundrobin.Name),
grpc.WithUnaryInterceptor(grpc_retry.UnaryClientInterceptor(grpc_retry.WithMax(o.MaxRetry))))

This comment has been minimized.

Copy link
@vprithvi

vprithvi Feb 26, 2019

Member

How does this retry work? Is it possible to configure it with exponential backoff, or some backoff for e.g.?

This comment has been minimized.

Copy link
@pavolloffay

pavolloffay Feb 26, 2019

Author Member

By default it is using BackoffLinearWithJitter. Which can be changed.

https://github.com/grpc-ecosystem/go-grpc-middleware/blob/master/retry/options.go#L26

@pavolloffay

This comment has been minimized.

Copy link
Member Author

commented Feb 26, 2019

Travis passed, I will try to restart it and hope :)

Increase retry to 100
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
@pavolloffay

This comment has been minimized.

Copy link
Member Author

commented Feb 27, 2019

I have restarted the build 4 times, it passed. I will merge this to see how it behaves in other repositories

@pavolloffay pavolloffay merged commit d8ab694 into jaegertracing:master Feb 27, 2019

5 checks passed

DCO DCO
Details
WIP Ready for review
Details
codecov/patch 100% of diff hit (target 100%)
Details
codecov/project 100% (target 100%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ghost ghost removed the review label Feb 27, 2019

@pavolloffay pavolloffay referenced this pull request Feb 27, 2019

Closed

Crossdock gRPC issues #1229

annanay25 added a commit to annanay25/jaeger that referenced this pull request Mar 1, 2019

Make grpc reporter default and add retry (jaegertracing#1384)
* Make grpc reporter default and add retry

Signed-off-by: Pavol Loffay <ploffay@redhat.com>

* Polish

Signed-off-by: Pavol Loffay <ploffay@redhat.com>

* Fix port

Signed-off-by: Pavol Loffay <ploffay@redhat.com>

* Polish

Signed-off-by: Pavol Loffay <ploffay@redhat.com>

* Use higher retry

Signed-off-by: Pavol Loffay <ploffay@redhat.com>

* Increase retry to 100

Signed-off-by: Pavol Loffay <ploffay@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.