Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default zap sampling config to nil #1460

merged 1 commit into from Apr 4, 2019


None yet
2 participants
Copy link

commented Apr 4, 2019

Which problem is this PR solving?

  • Resolves #160. Sets the default config behavior to no sampling for zap

Short description of the changes

  • Changes the default sampling config for the zap logger to nil

This comment has been minimized.

Copy link

commented Apr 4, 2019

Codecov Report

Merging #1460 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1460   +/-   ##
  Coverage   99.82%   99.82%           
  Files         173      173           
  Lines        8162     8162           
  Hits         8148     8148           
  Misses          7        7           
  Partials        7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7da2260...d1e629b. Read the comment docs.

@yurishkuro yurishkuro merged commit 8b2a2c1 into jaegertracing:master Apr 4, 2019

5 checks passed

WIP Ready for review
codecov/patch Coverage not affected when comparing 7da2260...d1e629b
codecov/project 99.82% (target 95%)
continuous-integration/travis-ci/pr The Travis CI build passed

This comment has been minimized.

Copy link

commented Apr 4, 2019


fix: set default sampling config for zap to nil
Signed-off-by: psinghal20 <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.