Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotrod] Reduce span exporter's batch timeout to let the spans be exported sooner #4518

Merged
merged 1 commit into from Jun 8, 2023
Merged

Conversation

GLVSKiriti
Copy link
Contributor

In HotROD appbatching is not required it should export traces asap so BatchTimeOut value can be lowered from 5sec solves the issue
Resolves jaegertracing/jaeger-ui#1180

In HotROD appbatching is not required it should export traces asap so BatchTimeOut value can be lowered from 5sec solves the issue

Signed-off-by: GLVS Kiriti <glvskiriti2003369@gmail.com>
@GLVSKiriti GLVSKiriti requested a review from a team as a code owner June 8, 2023 21:48
@yurishkuro yurishkuro changed the title Hyperlink in HotROD now finds trace results in 1st try [hotrod] Reduce span exporter's batch timeout to let the spans be exported sooner Jun 8, 2023
@yurishkuro yurishkuro enabled auto-merge (squash) June 8, 2023 21:59
@@ -62,7 +63,7 @@ func Init(serviceName string, exporterType string, metricsFactory metrics.Factor
rpcmetricsObserver := rpcmetrics.NewObserver(metricsFactory, rpcmetrics.DefaultNameNormalizer)

tp := sdktrace.NewTracerProvider(
sdktrace.WithBatcher(exp),
sdktrace.WithBatcher(exp, sdktrace.WithBatchTimeout(1000*time.Millisecond)),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: could express this as time.Second.

@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.03 ⚠️

Comparison is base (c582d89) 97.08% compared to head (aba5787) 97.05%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4518      +/-   ##
==========================================
- Coverage   97.08%   97.05%   -0.03%     
==========================================
  Files         300      300              
  Lines       17813    17813              
==========================================
- Hits        17293    17289       -4     
- Misses        417      420       +3     
- Partials      103      104       +1     
Flag Coverage Δ
unittests 97.05% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yurishkuro yurishkuro merged commit 557bb1c into jaegertracing:main Jun 8, 2023
31 checks passed
@GLVSKiriti GLVSKiriti deleted the hotRodBug branch June 8, 2023 22:21
kjschnei001 pushed a commit to kjschnei001/jaeger that referenced this pull request Jun 29, 2023
…orted sooner (jaegertracing#4518)

In HotROD appbatching is not required it should export traces asap so
BatchTimeOut value can be lowered from 5sec solves the issue
Resolves jaegertracing/jaeger-ui#1180

Signed-off-by: GLVS Kiriti <glvskiriti2003369@gmail.com>
Signed-off-by: KevinSchneider <kevin.schneider@target.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Following hyperlink from HotROD app does not find the trace on first try
3 participants