Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tracegen] Add options to generate more spans and attributes #4535

Merged
merged 2 commits into from Jun 18, 2023

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Jun 18, 2023

Short description of the changes

Add new configuration options:

  • -services: to generate traces on behalf of many services, by instantiating different tracers
  • -spans: to generate more than one child span
  • -attrs: to generate N number of attributes on each child span
  • -attr-values: to control how many distinct values each attribute can have

Fix weird span durations when using -pause 0s.

Test:

go run ./cmd/tracegen -traces 2 -services 2 -spans 3 -attrs 3
image image

Signed-off-by: Yuri Shkuro <ysh@meta.com>
Signed-off-by: Yuri Shkuro <ysh@meta.com>
@yurishkuro yurishkuro requested a review from a team as a code owner June 18, 2023 18:58
@codecov
Copy link

codecov bot commented Jun 18, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (bfed6e7) 97.05% compared to head (c234f69) 97.04%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4535      +/-   ##
==========================================
- Coverage   97.05%   97.04%   -0.01%     
==========================================
  Files         301      301              
  Lines       17817    17817              
==========================================
- Hits        17292    17291       -1     
- Misses        421      422       +1     
  Partials      104      104              
Flag Coverage Δ
unittests 97.04% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yurishkuro yurishkuro merged commit 4a6f118 into jaegertracing:main Jun 18, 2023
31 checks passed
@yurishkuro yurishkuro deleted the tracegen2 branch June 18, 2023 19:31
kjschnei001 pushed a commit to kjschnei001/jaeger that referenced this pull request Jun 29, 2023
…racing#4535)

## Short description of the changes
Add new configuration options:
- `-services`: to generate traces on behalf of many services, by
instantiating different tracers
- `-spans`: to generate more than one child span
- `-attrs`: to generate N number of attributes on each child span
- `-attr-values`: to control how many distinct values each attribute can
have

Fix weird span durations when using `-pause 0s`.

Test:
```shell
go run ./cmd/tracegen -traces 2 -services 2 -spans 3 -attrs 3
```
<img width="964" alt="image"
src="https://github.com/jaegertracing/jaeger/assets/3523016/3f2d6cee-ab1c-4fef-a016-259aaa7a77b6">

<img width="952" alt="image"
src="https://github.com/jaegertracing/jaeger/assets/3523016/44d0f67b-7443-48a9-8b13-95b69841804b">

---------

Signed-off-by: Yuri Shkuro <ysh@meta.com>
Signed-off-by: KevinSchneider <kevin.schneider@target.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant