Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotROD] Add OTEL instrumentation to customer svc #4559

Merged

Conversation

afzal442
Copy link
Contributor

@afzal442 afzal442 commented Jul 2, 2023

Which problem is this PR solving?

Related to #3380
Part of #3381

Short description of the changes

  • This PR adds OTEL instrumentation to customer svc

Signed-off-by: Afzal Ansari <afzal442@gmail.com>
@afzal442 afzal442 requested a review from a team as a code owner July 2, 2023 11:36
@afzal442 afzal442 requested a review from joe-elliott July 2, 2023 11:36
@codecov
Copy link

codecov bot commented Jul 2, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (321357a) 97.05% compared to head (a4ed802) 97.05%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4559      +/-   ##
==========================================
- Coverage   97.05%   97.05%   -0.01%     
==========================================
  Files         301      301              
  Lines       17837    17837              
==========================================
- Hits        17312    17311       -1     
- Misses        421      422       +1     
  Partials      104      104              
Flag Coverage Δ
unittests 97.05% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fill out proper pr description

examples/hotrod/services/customer/database.go Show resolved Hide resolved
@afzal442 afzal442 changed the title Adds otel instrumn to customer svc [hotROD] Added otel instrumn to customer svc Jul 2, 2023
@afzal442 afzal442 changed the title [hotROD] Added otel instrumn to customer svc [hotROD] Added OTEL instrumentation to customer svc Jul 2, 2023
@afzal442 afzal442 changed the title [hotROD] Added OTEL instrumentation to customer svc [hotROD] Add OTEL instrumentation to customer svc Jul 2, 2023
Signed-off-by: Afzal Ansari <afzal442@gmail.com>
@afzal442 afzal442 requested a review from yurishkuro July 2, 2023 17:04
@yurishkuro yurishkuro enabled auto-merge (squash) July 2, 2023 18:14
@yurishkuro yurishkuro merged commit b833839 into jaegertracing:main Jul 2, 2023
31 checks passed
@afzal442 afzal442 deleted the customer-svc-otel-instrmn branch July 3, 2023 09:26
afzal442 added a commit to Cloud-Hacks/jaeger that referenced this pull request Jul 10, 2023
## Which problem is this PR solving?
Related to jaegertracing#3380
Part of jaegertracing#3381

## Short description of the changes
- This PR adds OTEL instrumentation to customer svc

---------

Signed-off-by: Afzal Ansari <afzal442@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants