New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect Zipkin v2 json #518

Merged
merged 8 commits into from Nov 16, 2017

Conversation

Projects
None yet
4 participants
@pavolloffay
Member

pavolloffay commented Nov 8, 2017

Fixes #450

How does it work:

  • zipkin swagger from idl is compiled to go code (it uses https://github.com/go-swagger/go-swagger)
  • custom http handler which uses generated files to unmarshall and validate spans
  • convert swagger model classes to zipkin thrift

Zipkin related links:
messaging annos: openzipkin/zipkin-api#29
span v2: openzipkin/zipkin#1499

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Nov 8, 2017

Coverage Status

Coverage decreased (-1.3%) to 98.656% when pulling 4b12db5 on pavolloffay:zipkin-v2 into 2b73fe9 on jaegertracing:master.

coveralls commented Nov 8, 2017

Coverage Status

Coverage decreased (-1.3%) to 98.656% when pulling 4b12db5 on pavolloffay:zipkin-v2 into 2b73fe9 on jaegertracing:master.

Show outdated Hide outdated .gitmodules
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Nov 10, 2017

Coverage Status

Coverage decreased (-2.3%) to 97.716% when pulling cd795b5 on pavolloffay:zipkin-v2 into a2ed9b8 on jaegertracing:master.

coveralls commented Nov 10, 2017

Coverage Status

Coverage decreased (-2.3%) to 97.716% when pulling cd795b5 on pavolloffay:zipkin-v2 into a2ed9b8 on jaegertracing:master.

@pavolloffay

This comment has been minimized.

Show comment
Hide comment
@pavolloffay

pavolloffay Nov 10, 2017

Member

xdock tests with brave using JSON V2 are passing. It can be reviewed. In meanwhile I will improve coverage and wait for swagger a thrift IDL changes.

Member

pavolloffay commented Nov 10, 2017

xdock tests with brave using JSON V2 are passing. It can be reviewed. In meanwhile I will improve coverage and wait for swagger a thrift IDL changes.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Nov 13, 2017

Coverage Status

Coverage decreased (-2.2%) to 97.716% when pulling 102d6cf on pavolloffay:zipkin-v2 into 32e2cd3 on jaegertracing:master.

coveralls commented Nov 13, 2017

Coverage Status

Coverage decreased (-2.2%) to 97.716% when pulling 102d6cf on pavolloffay:zipkin-v2 into 32e2cd3 on jaegertracing:master.

@pavolloffay pavolloffay changed the title from WIP: Collect Zipkin v2 json to Collect Zipkin v2 json Nov 13, 2017

@pavolloffay

This comment has been minimized.

Show comment
Hide comment
@pavolloffay

pavolloffay Nov 13, 2017

Member

it's ready for review

Member

pavolloffay commented Nov 13, 2017

it's ready for review

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Nov 13, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 43b8461 on pavolloffay:zipkin-v2 into e0a74f2 on jaegertracing:master.

coveralls commented Nov 13, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 43b8461 on pavolloffay:zipkin-v2 into e0a74f2 on jaegertracing:master.

Show outdated Hide outdated cmd/collector/app/zipkin/http_handler.go
Show outdated Hide outdated cmd/collector/app/zipkin/http_handler.go
Show outdated Hide outdated cmd/collector/app/zipkin/jsonv2.go
Show outdated Hide outdated cmd/collector/app/zipkin/jsonv2.go
Show outdated Hide outdated cmd/collector/app/zipkin/jsonv2.go
Show outdated Hide outdated cmd/collector/app/zipkin/jsonv2.go
@@ -53,6 +54,14 @@ services:
environment:
- ENCODING=JSON
zipkin-brave-json-v2:

This comment has been minimized.

@black-adder

black-adder Nov 14, 2017

Collaborator

+1 love how easy it is to integration test new endpoints

@black-adder

black-adder Nov 14, 2017

Collaborator

+1 love how easy it is to integration test new endpoints

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Nov 15, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling ca70179 on pavolloffay:zipkin-v2 into e0a74f2 on jaegertracing:master.

coveralls commented Nov 15, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling ca70179 on pavolloffay:zipkin-v2 into e0a74f2 on jaegertracing:master.

Show outdated Hide outdated cmd/collector/app/zipkin/jsonv2.go

pavolloffay added some commits Nov 8, 2017

Collect Zipkin v2 json
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
fix make
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
remove submodule
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
Trasform messaging spans
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
http handler tests
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
Fix review comments
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
Preallocate spans slice
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Nov 15, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 78db314 on pavolloffay:zipkin-v2 into 5db9cde on jaegertracing:master.

coveralls commented Nov 15, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 78db314 on pavolloffay:zipkin-v2 into 5db9cde on jaegertracing:master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Nov 15, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 78db314 on pavolloffay:zipkin-v2 into 5db9cde on jaegertracing:master.

coveralls commented Nov 15, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 78db314 on pavolloffay:zipkin-v2 into 5db9cde on jaegertracing:master.

@pavolloffay

This comment has been minimized.

Show comment
Hide comment
@pavolloffay

pavolloffay Nov 16, 2017

Member

@yurishkuro I will merge on green, I can apply additional changes in a separate PR.

Member

pavolloffay commented Nov 16, 2017

@yurishkuro I will merge on green, I can apply additional changes in a separate PR.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Nov 16, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 3a703db on pavolloffay:zipkin-v2 into 6897ca2 on jaegertracing:master.

coveralls commented Nov 16, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 3a703db on pavolloffay:zipkin-v2 into 6897ca2 on jaegertracing:master.

@pavolloffay pavolloffay merged commit 53955e3 into jaegertracing:master Nov 16, 2017

3 checks passed

DCO All commits have a DCO sign-off from the author
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details

@wafflebot wafflebot bot removed the review label Nov 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment