diff --git a/.golangci.yml b/.golangci.yml index bd43de248f8..a88d4b8c39f 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -168,9 +168,6 @@ linters-settings: # not sure how different from previous one - name: cyclomatic disabled: true - # do a clean-up and enable - - name: unused-parameter - disabled: true # we use storage_v2, so... - name: var-naming disabled: true diff --git a/cmd/agent/app/processors/thrift_processor_test.go b/cmd/agent/app/processors/thrift_processor_test.go index ce824a13fff..f7a421f1f77 100644 --- a/cmd/agent/app/processors/thrift_processor_test.go +++ b/cmd/agent/app/processors/thrift_processor_test.go @@ -121,7 +121,7 @@ type failingHandler struct { err error } -func (h failingHandler) Process(_ context.Context, iprot, oprot thrift.TProtocol) (success bool, err thrift.TException) { +func (h failingHandler) Process(context.Context, thrift.TProtocol /* iprot */, thrift.TProtocol /* oprot */) (success bool, err thrift.TException) { return false, thrift.NewTApplicationException(0, h.err.Error()) } diff --git a/cmd/agent/app/reporter/flags.go b/cmd/agent/app/reporter/flags.go index c3ec9616789..ea3deeeda47 100644 --- a/cmd/agent/app/reporter/flags.go +++ b/cmd/agent/app/reporter/flags.go @@ -52,7 +52,7 @@ func AddFlags(flags *flag.FlagSet) { } // InitFromViper initializes Options with properties retrieved from Viper. -func (b *Options) InitFromViper(v *viper.Viper, logger *zap.Logger) *Options { +func (b *Options) InitFromViper(v *viper.Viper, _ *zap.Logger) *Options { b.ReporterType = Type(v.GetString(reporterType)) if !setupcontext.IsAllInOne() { if len(v.GetString(agentTags)) > 0 { diff --git a/cmd/agent/app/reporter/grpc/reporter_test.go b/cmd/agent/app/reporter/grpc/reporter_test.go index 19345ce8527..ae29fbe5290 100644 --- a/cmd/agent/app/reporter/grpc/reporter_test.go +++ b/cmd/agent/app/reporter/grpc/reporter_test.go @@ -46,7 +46,7 @@ func (h *mockSpanHandler) getRequests() []*api_v2.PostSpansRequest { return h.requests } -func (h *mockSpanHandler) PostSpans(c context.Context, r *api_v2.PostSpansRequest) (*api_v2.PostSpansResponse, error) { +func (h *mockSpanHandler) PostSpans(_ context.Context, r *api_v2.PostSpansRequest) (*api_v2.PostSpansResponse, error) { h.mux.Lock() defer h.mux.Unlock() h.requests = append(h.requests, r) @@ -183,7 +183,7 @@ func TestReporter_MakeModelKeyValue(t *testing.T) { type mockMultitenantSpanHandler struct{} -func (*mockMultitenantSpanHandler) PostSpans(ctx context.Context, r *api_v2.PostSpansRequest) (*api_v2.PostSpansResponse, error) { +func (*mockMultitenantSpanHandler) PostSpans(ctx context.Context, _ *api_v2.PostSpansRequest) (*api_v2.PostSpansResponse, error) { md, ok := metadata.FromIncomingContext(ctx) if !ok { return &api_v2.PostSpansResponse{}, status.Errorf(codes.PermissionDenied, "missing tenant header") diff --git a/cmd/collector/app/collector_test.go b/cmd/collector/app/collector_test.go index fe7a79bc009..84eb3718015 100644 --- a/cmd/collector/app/collector_test.go +++ b/cmd/collector/app/collector_test.go @@ -53,11 +53,11 @@ type mockAggregator struct { closeCount atomic.Int32 } -func (t *mockAggregator) RecordThroughput(service, operation string, samplerType model.SamplerType, probability float64) { +func (t *mockAggregator) RecordThroughput(string /* service */, string /* operation */, model.SamplerType, float64 /* probability */) { t.callCount.Add(1) } -func (t *mockAggregator) HandleRootSpan(span *model.Span, logger *zap.Logger) { +func (t *mockAggregator) HandleRootSpan(*model.Span, *zap.Logger) { t.callCount.Add(1) } @@ -146,7 +146,7 @@ func TestCollector_StartErrors(t *testing.T) { type mockStrategyStore struct{} -func (*mockStrategyStore) GetSamplingStrategy(_ context.Context, serviceName string) (*api_v2.SamplingStrategyResponse, error) { +func (*mockStrategyStore) GetSamplingStrategy(context.Context, string /* serviceName */) (*api_v2.SamplingStrategyResponse, error) { return &api_v2.SamplingStrategyResponse{}, nil } diff --git a/cmd/collector/app/flags/flags.go b/cmd/collector/app/flags/flags.go index 64a36b66e3b..8b3203b853c 100644 --- a/cmd/collector/app/flags/flags.go +++ b/cmd/collector/app/flags/flags.go @@ -234,7 +234,7 @@ func addGRPCFlags(flags *flag.FlagSet, cfg serverFlagsConfig, defaultHostPort st cfg.tls.AddFlags(flags) } -func (opts *HTTPOptions) initFromViper(v *viper.Viper, logger *zap.Logger, cfg serverFlagsConfig) error { +func (opts *HTTPOptions) initFromViper(v *viper.Viper, _ *zap.Logger, cfg serverFlagsConfig) error { opts.HostPort = ports.FormatHostPort(v.GetString(cfg.prefix + "." + flagSuffixHostPort)) opts.IdleTimeout = v.GetDuration(cfg.prefix + "." + flagSuffixHTTPIdleTimeout) opts.ReadTimeout = v.GetDuration(cfg.prefix + "." + flagSuffixHTTPReadTimeout) @@ -247,7 +247,7 @@ func (opts *HTTPOptions) initFromViper(v *viper.Viper, logger *zap.Logger, cfg s return nil } -func (opts *GRPCOptions) initFromViper(v *viper.Viper, logger *zap.Logger, cfg serverFlagsConfig) error { +func (opts *GRPCOptions) initFromViper(v *viper.Viper, _ *zap.Logger, cfg serverFlagsConfig) error { opts.HostPort = ports.FormatHostPort(v.GetString(cfg.prefix + "." + flagSuffixHostPort)) opts.MaxReceiveMessageLength = v.GetInt(cfg.prefix + "." + flagSuffixGRPCMaxReceiveMessageLength) opts.MaxConnectionAge = v.GetDuration(cfg.prefix + "." + flagSuffixGRPCMaxConnectionAge) diff --git a/cmd/collector/app/handler/http_thrift_handler_test.go b/cmd/collector/app/handler/http_thrift_handler_test.go index cc50ae64b92..68c93992ef3 100644 --- a/cmd/collector/app/handler/http_thrift_handler_test.go +++ b/cmd/collector/app/handler/http_thrift_handler_test.go @@ -171,7 +171,7 @@ func TestCannotReadBodyFromRequest(t *testing.T) { type errReader struct{} -func (*errReader) Read(p []byte) (int, error) { +func (*errReader) Read([]byte) (int, error) { return 0, fmt.Errorf("Simulated error reading body") } diff --git a/cmd/collector/app/sampling/grpc_handler_test.go b/cmd/collector/app/sampling/grpc_handler_test.go index ed9a65a72c6..26c7af88aa0 100644 --- a/cmd/collector/app/sampling/grpc_handler_test.go +++ b/cmd/collector/app/sampling/grpc_handler_test.go @@ -28,7 +28,7 @@ import ( type mockSamplingStore struct{} -func (mockSamplingStore) GetSamplingStrategy(ctx context.Context, serviceName string) (*api_v2.SamplingStrategyResponse, error) { +func (mockSamplingStore) GetSamplingStrategy(_ context.Context, serviceName string) (*api_v2.SamplingStrategyResponse, error) { if serviceName == "error" { return nil, errors.New("some error") } else if serviceName == "nil" { diff --git a/cmd/collector/app/sanitizer/cache/auto_refresh_cache.go b/cmd/collector/app/sanitizer/cache/auto_refresh_cache.go index b3d8c433fdd..9bcadd72f4e 100644 --- a/cmd/collector/app/sanitizer/cache/auto_refresh_cache.go +++ b/cmd/collector/app/sanitizer/cache/auto_refresh_cache.go @@ -65,7 +65,7 @@ func (c *autoRefreshCache) Get(key string) string { } // Put implementation that does nothing -func (*autoRefreshCache) Put(key string, value string) error { +func (*autoRefreshCache) Put(string /* key */, string /* value */) error { return nil } diff --git a/cmd/collector/app/sanitizer/cache/auto_refresh_cache_test.go b/cmd/collector/app/sanitizer/cache/auto_refresh_cache_test.go index 8295fe9ec48..ad8a538152c 100644 --- a/cmd/collector/app/sanitizer/cache/auto_refresh_cache_test.go +++ b/cmd/collector/app/sanitizer/cache/auto_refresh_cache_test.go @@ -38,7 +38,7 @@ var ( // dont_go:generate mockery -name=ServiceAliasMappingStorage // dont_go:generate mockery -name=ServiceAliasMappingExternalSource -func getCache(t *testing.T) (*autoRefreshCache, *mocks.ServiceAliasMappingExternalSource, *mocks.ServiceAliasMappingStorage) { +func getCache(*testing.T) (*autoRefreshCache, *mocks.ServiceAliasMappingExternalSource, *mocks.ServiceAliasMappingStorage) { mockExtSource := &mocks.ServiceAliasMappingExternalSource{} mockStorage := &mocks.ServiceAliasMappingStorage{} logger := zap.NewNop() diff --git a/cmd/collector/app/sanitizer/sanitizer_test.go b/cmd/collector/app/sanitizer/sanitizer_test.go index e370e7a7747..d0c47f43bad 100644 --- a/cmd/collector/app/sanitizer/sanitizer_test.go +++ b/cmd/collector/app/sanitizer/sanitizer_test.go @@ -22,7 +22,7 @@ import ( "github.com/jaegertracing/jaeger/model" ) -func TestNewStandardSanitizers(t *testing.T) { +func TestNewStandardSanitizers(*testing.T) { NewStandardSanitizers() } diff --git a/cmd/collector/app/sanitizer/service_name_sanitizer_test.go b/cmd/collector/app/sanitizer/service_name_sanitizer_test.go index f9ab382e300..51294c99f8c 100644 --- a/cmd/collector/app/sanitizer/service_name_sanitizer_test.go +++ b/cmd/collector/app/sanitizer/service_name_sanitizer_test.go @@ -40,7 +40,7 @@ func (d *fixedMappingCache) Get(key string) string { return k } -func (*fixedMappingCache) Put(key string, value string) error { +func (*fixedMappingCache) Put(string /* key */, string /* value */) error { return nil } diff --git a/cmd/collector/app/sanitizer/zipkin/span_sanitizer_test.go b/cmd/collector/app/sanitizer/zipkin/span_sanitizer_test.go index c9584ab9a9b..cf90426a402 100644 --- a/cmd/collector/app/sanitizer/zipkin/span_sanitizer_test.go +++ b/cmd/collector/app/sanitizer/zipkin/span_sanitizer_test.go @@ -29,7 +29,7 @@ var ( positiveDuration = int64(1) ) -func TestNewStandardSanitizers(t *testing.T) { +func TestNewStandardSanitizers(*testing.T) { NewStandardSanitizers() } diff --git a/cmd/collector/app/server/test.go b/cmd/collector/app/server/test.go index 38667d9f034..338e5365730 100644 --- a/cmd/collector/app/server/test.go +++ b/cmd/collector/app/server/test.go @@ -24,7 +24,7 @@ import ( type mockSamplingStore struct{} -func (mockSamplingStore) GetSamplingStrategy(_ context.Context, serviceName string) (*api_v2.SamplingStrategyResponse, error) { +func (mockSamplingStore) GetSamplingStrategy(context.Context, string /* serviceName */) (*api_v2.SamplingStrategyResponse, error) { return nil, nil } @@ -38,6 +38,6 @@ func (*mockSpanProcessor) Close() error { return nil } -func (*mockSpanProcessor) ProcessSpans(spans []*model.Span, _ processor.SpansOptions) ([]bool, error) { +func (*mockSpanProcessor) ProcessSpans([]*model.Span, processor.SpansOptions) ([]bool, error) { return []bool{}, nil } diff --git a/cmd/collector/app/span_processor.go b/cmd/collector/app/span_processor.go index 03d9ae460dd..e041eb410a9 100644 --- a/cmd/collector/app/span_processor.go +++ b/cmd/collector/app/span_processor.go @@ -169,7 +169,7 @@ func (sp *spanProcessor) saveSpan(span *model.Span, tenant string) { sp.metrics.SaveLatency.Record(time.Since(startTime)) } -func (sp *spanProcessor) countSpan(span *model.Span, tenant string) { +func (sp *spanProcessor) countSpan(span *model.Span, _ string /* tenant */) { sp.bytesProcessed.Add(uint64(span.Size())) sp.spansProcessed.Add(1) } diff --git a/cmd/collector/app/span_processor_test.go b/cmd/collector/app/span_processor_test.go index ed1b6bde619..e3a7eca40e4 100644 --- a/cmd/collector/app/span_processor_test.go +++ b/cmd/collector/app/span_processor_test.go @@ -302,7 +302,7 @@ type blockingWriter struct { inWriteSpan atomic.Int32 } -func (w *blockingWriter) WriteSpan(ctx context.Context, span *model.Span) error { +func (w *blockingWriter) WriteSpan(context.Context, *model.Span) error { w.inWriteSpan.Add(1) w.Lock() defer w.Unlock() diff --git a/cmd/ingester/app/consumer/consumer_test.go b/cmd/ingester/app/consumer/consumer_test.go index 51ceda49b9f..4825d69af6c 100644 --- a/cmd/ingester/app/consumer/consumer_test.go +++ b/cmd/ingester/app/consumer/consumer_test.go @@ -88,7 +88,7 @@ func newSaramaClusterConsumer(saramaPartitionConsumer sarama.PartitionConsumer, func newConsumer( t *testing.T, metricsFactory metrics.Factory, - topic string, + _ string, /* topic */ processor processor.SpanProcessor, consumer consumer.Consumer, ) *Consumer { diff --git a/cmd/ingester/app/consumer/deadlock_detector_test.go b/cmd/ingester/app/consumer/deadlock_detector_test.go index 6cef1c00b6c..d7627b8c297 100644 --- a/cmd/ingester/app/consumer/deadlock_detector_test.go +++ b/cmd/ingester/app/consumer/deadlock_detector_test.go @@ -79,7 +79,7 @@ func TestPanicFunc(t *testing.T) { }) } -func TestPanicForPartition(t *testing.T) { +func TestPanicForPartition(*testing.T) { l, _ := zap.NewDevelopment() wg := sync.WaitGroup{} wg.Add(1) @@ -96,7 +96,7 @@ func TestPanicForPartition(t *testing.T) { wg.Wait() } -func TestGlobalPanic(t *testing.T) { +func TestGlobalPanic(*testing.T) { l, _ := zap.NewDevelopment() wg := sync.WaitGroup{} wg.Add(1) diff --git a/cmd/internal/flags/service_test.go b/cmd/internal/flags/service_test.go index 0eaf8a10325..0915135dec4 100644 --- a/cmd/internal/flags/service_test.go +++ b/cmd/internal/flags/service_test.go @@ -28,7 +28,7 @@ import ( "github.com/jaegertracing/jaeger/pkg/healthcheck" ) -func TestAddFlags(t *testing.T) { +func TestAddFlags(*testing.T) { s := NewService(0) s.AddFlags(new(flag.FlagSet)) diff --git a/cmd/internal/status/command_test.go b/cmd/internal/status/command_test.go index 16dcad59080..85d964254f0 100644 --- a/cmd/internal/status/command_test.go +++ b/cmd/internal/status/command_test.go @@ -26,12 +26,12 @@ import ( "github.com/jaegertracing/jaeger/pkg/testutils" ) -func readyHandler(w http.ResponseWriter, r *http.Request) { +func readyHandler(w http.ResponseWriter, _ *http.Request) { w.WriteHeader(http.StatusOK) w.Write([]byte("{\"status\":\"Server available\"}")) } -func unavailableHandler(w http.ResponseWriter, r *http.Request) { +func unavailableHandler(w http.ResponseWriter, _ *http.Request) { w.WriteHeader(http.StatusServiceUnavailable) w.Write([]byte("{\"status\":\"Server not available\"}")) } diff --git a/cmd/jaeger/internal/extension/jaegerquery/server.go b/cmd/jaeger/internal/extension/jaegerquery/server.go index 9a07f1089bf..dc9fc29323d 100644 --- a/cmd/jaeger/internal/extension/jaegerquery/server.go +++ b/cmd/jaeger/internal/extension/jaegerquery/server.go @@ -46,7 +46,7 @@ func (*server) Dependencies() []component.ID { return []component.ID{jaegerstorage.ID} } -func (s *server) Start(ctx context.Context, host component.Host) error { +func (s *server) Start(_ context.Context, host component.Host) error { f, err := jaegerstorage.GetStorageFactory(s.config.TraceStoragePrimary, host) if err != nil { return fmt.Errorf("cannot find primary storage %s: %w", s.config.TraceStoragePrimary, err) diff --git a/cmd/jaeger/internal/extension/jaegerquery/server_test.go b/cmd/jaeger/internal/extension/jaegerquery/server_test.go index cbf8d2ceaca..36cc4d82c4c 100644 --- a/cmd/jaeger/internal/extension/jaegerquery/server_test.go +++ b/cmd/jaeger/internal/extension/jaegerquery/server_test.go @@ -69,11 +69,11 @@ func (fakeStorageExt) Factory(name string) (storage.Factory, bool) { return fakeFactory{name: name}, true } -func (fakeStorageExt) Start(ctx context.Context, host component.Host) error { +func (fakeStorageExt) Start(context.Context, component.Host) error { return nil } -func (fakeStorageExt) Shutdown(ctx context.Context) error { +func (fakeStorageExt) Shutdown(context.Context) error { return nil } @@ -81,7 +81,7 @@ type storageHost struct { extension component.Component } -func (storageHost) ReportFatalError(err error) { +func (storageHost) ReportFatalError(error) { } func (host storageHost) GetExtensions() map[component.ID]component.Component { diff --git a/cmd/jaeger/internal/extension/jaegerstorage/extension.go b/cmd/jaeger/internal/extension/jaegerstorage/extension.go index 59a1680cb34..3bb1073ddf7 100644 --- a/cmd/jaeger/internal/extension/jaegerstorage/extension.go +++ b/cmd/jaeger/internal/extension/jaegerstorage/extension.go @@ -157,7 +157,7 @@ func (s *storageExt) Start(ctx context.Context, host component.Host) error { return nil } -func (s *storageExt) Shutdown(ctx context.Context) error { +func (s *storageExt) Shutdown(context.Context) error { var errs []error for _, factory := range s.factories { if closer, ok := factory.(io.Closer); ok { diff --git a/cmd/jaeger/internal/extension/jaegerstorage/extension_test.go b/cmd/jaeger/internal/extension/jaegerstorage/extension_test.go index 4a50b002303..743d1de5428 100644 --- a/cmd/jaeger/internal/extension/jaegerstorage/extension_test.go +++ b/cmd/jaeger/internal/extension/jaegerstorage/extension_test.go @@ -52,7 +52,7 @@ type errorFactory struct { closeErr error } -func (errorFactory) Initialize(metricsFactory metrics.Factory, logger *zap.Logger) error { +func (errorFactory) Initialize(metrics.Factory, *zap.Logger) error { panic("not implemented") } diff --git a/cmd/jaeger/internal/integration/receivers/storagereceiver/factory.go b/cmd/jaeger/internal/integration/receivers/storagereceiver/factory.go index 9163583b102..c3b63f3fdab 100644 --- a/cmd/jaeger/internal/integration/receivers/storagereceiver/factory.go +++ b/cmd/jaeger/internal/integration/receivers/storagereceiver/factory.go @@ -29,7 +29,7 @@ func createDefaultConfig() component.Config { return &Config{} } -func createTracesReceiver(ctx context.Context, set receiver.CreateSettings, config component.Config, nextConsumer consumer.Traces) (receiver.Traces, error) { +func createTracesReceiver(_ context.Context, set receiver.CreateSettings, config component.Config, nextConsumer consumer.Traces) (receiver.Traces, error) { cfg := config.(*Config) return newTracesReceiver(cfg, set, nextConsumer) diff --git a/cmd/jaeger/internal/integration/receivers/storagereceiver/receiver_test.go b/cmd/jaeger/internal/integration/receivers/storagereceiver/receiver_test.go index 393d2082e48..17d81fcd0f3 100644 --- a/cmd/jaeger/internal/integration/receivers/storagereceiver/receiver_test.go +++ b/cmd/jaeger/internal/integration/receivers/storagereceiver/receiver_test.go @@ -33,11 +33,11 @@ type mockStorageExt struct { factory *factoryMocks.Factory } -func (*mockStorageExt) Start(ctx context.Context, host component.Host) error { +func (*mockStorageExt) Start(context.Context, component.Host) error { panic("not implemented") } -func (*mockStorageExt) Shutdown(ctx context.Context) error { +func (*mockStorageExt) Shutdown(context.Context) error { panic("not implemented") } diff --git a/cmd/jaeger/internal/integration/span_reader.go b/cmd/jaeger/internal/integration/span_reader.go index 14db12312b4..2ebedb7caac 100644 --- a/cmd/jaeger/internal/integration/span_reader.go +++ b/cmd/jaeger/internal/integration/span_reader.go @@ -168,6 +168,6 @@ func (r *spanReader) FindTraces(ctx context.Context, query *spanstore.TraceQuery return traces, nil } -func (*spanReader) FindTraceIDs(ctx context.Context, query *spanstore.TraceQueryParameters) ([]model.TraceID, error) { +func (*spanReader) FindTraceIDs(context.Context, *spanstore.TraceQueryParameters) ([]model.TraceID, error) { panic("not implemented") } diff --git a/cmd/jaeger/internal/integration/storagecleaner/extension.go b/cmd/jaeger/internal/integration/storagecleaner/extension.go index cdc7b0988c8..2a8b37016e6 100644 --- a/cmd/jaeger/internal/integration/storagecleaner/extension.go +++ b/cmd/jaeger/internal/integration/storagecleaner/extension.go @@ -41,7 +41,7 @@ func newStorageCleaner(config *Config, telemetrySettings component.TelemetrySett } } -func (c *storageCleaner) Start(ctx context.Context, host component.Host) error { +func (c *storageCleaner) Start(_ context.Context, host component.Host) error { storageFactory, err := jaegerstorage.GetStorageFactory(c.config.TraceStorage, host) if err != nil { return fmt.Errorf("cannot find storage factory '%s': %w", c.config.TraceStorage, err) diff --git a/cmd/jaeger/internal/integration/storagecleaner/extension_test.go b/cmd/jaeger/internal/integration/storagecleaner/extension_test.go index 068a58ed131..a150e0f00ac 100644 --- a/cmd/jaeger/internal/integration/storagecleaner/extension_test.go +++ b/cmd/jaeger/internal/integration/storagecleaner/extension_test.go @@ -40,11 +40,11 @@ type mockStorageExt struct { factory storage.Factory } -func (*mockStorageExt) Start(ctx context.Context, host component.Host) error { +func (*mockStorageExt) Start(context.Context, component.Host) error { panic("not implemented") } -func (*mockStorageExt) Shutdown(ctx context.Context) error { +func (*mockStorageExt) Shutdown(context.Context) error { panic("not implemented") } diff --git a/cmd/query/app/apiv3/http_gateway.go b/cmd/query/app/apiv3/http_gateway.go index 16f01cbdb10..897b30a5404 100644 --- a/cmd/query/app/apiv3/http_gateway.go +++ b/cmd/query/app/apiv3/http_gateway.go @@ -66,7 +66,7 @@ func (h *HTTPGateway) addRoute( router *mux.Router, f func(http.ResponseWriter, *http.Request), route string, - args ...any, + _ ...any, /* args */ ) *mux.Route { var handler http.Handler = http.HandlerFunc(f) if h.TenancyMgr.Enabled { diff --git a/cmd/query/app/apiv3/http_gateway_test.go b/cmd/query/app/apiv3/http_gateway_test.go index edffadb485d..5c35c8ae78e 100644 --- a/cmd/query/app/apiv3/http_gateway_test.go +++ b/cmd/query/app/apiv3/http_gateway_test.go @@ -29,7 +29,7 @@ import ( ) func setupHTTPGatewayNoServer( - t *testing.T, + _ *testing.T, basePath string, tenancyOptions tenancy.Options, ) *testGateway { diff --git a/cmd/query/app/grpc_handler.go b/cmd/query/app/grpc_handler.go index 670050f5ba9..362efcaeb1d 100644 --- a/cmd/query/app/grpc_handler.go +++ b/cmd/query/app/grpc_handler.go @@ -181,7 +181,7 @@ func (g *GRPCHandler) sendSpanChunks(spans []*model.Span, sendFn func(*api_v2.Sp } // GetServices is the gRPC handler to fetch services. -func (g *GRPCHandler) GetServices(ctx context.Context, r *api_v2.GetServicesRequest) (*api_v2.GetServicesResponse, error) { +func (g *GRPCHandler) GetServices(ctx context.Context, _ *api_v2.GetServicesRequest) (*api_v2.GetServicesResponse, error) { services, err := g.queryService.GetServices(ctx) if err != nil { g.logger.Error("failed to fetch services", zap.Error(err)) diff --git a/cmd/query/app/http_handler_test.go b/cmd/query/app/http_handler_test.go index 00d8dcf87d8..ec84b37e55a 100644 --- a/cmd/query/app/http_handler_test.go +++ b/cmd/query/app/http_handler_test.go @@ -209,7 +209,7 @@ type httpResponseErrWriter struct{} func (*httpResponseErrWriter) Write([]byte) (int, error) { return 0, fmt.Errorf("failed to write") } -func (*httpResponseErrWriter) WriteHeader(statusCode int) {} +func (*httpResponseErrWriter) WriteHeader(int /* statusCode */) {} func (*httpResponseErrWriter) Header() http.Header { return http.Header{} } diff --git a/cmd/query/app/internal/api_v3/traces.go b/cmd/query/app/internal/api_v3/traces.go index 7090f099689..04b9c2a850b 100644 --- a/cmd/query/app/internal/api_v3/traces.go +++ b/cmd/query/app/internal/api_v3/traces.go @@ -33,7 +33,7 @@ func (td *TracesData) Marshal() ([]byte, error) { } // MarshalTo implements gogocodec.CustomType. -func (*TracesData) MarshalTo(data []byte) (n int, err error) { +func (*TracesData) MarshalTo([]byte /* data */) (n int, err error) { // TODO unclear when this might be called, perhaps when type is embedded inside other structs. panic("unimplemented") } diff --git a/cmd/query/app/querysvc/query_service_test.go b/cmd/query/app/querysvc/query_service_test.go index 41231993930..a31bc26f9f8 100644 --- a/cmd/query/app/querysvc/query_service_test.go +++ b/cmd/query/app/querysvc/query_service_test.go @@ -315,7 +315,7 @@ type fakeStorageFactory2 struct { wErr error } -func (*fakeStorageFactory1) Initialize(metricsFactory metrics.Factory, logger *zap.Logger) error { +func (*fakeStorageFactory1) Initialize(metrics.Factory, *zap.Logger) error { return nil } func (*fakeStorageFactory1) CreateSpanReader() (spanstore.Reader, error) { return nil, nil } diff --git a/cmd/query/app/static_handler.go b/cmd/query/app/static_handler.go index ee27fe9dbe4..2ebbfff7345 100644 --- a/cmd/query/app/static_handler.go +++ b/cmd/query/app/static_handler.go @@ -235,7 +235,7 @@ func (sH *StaticAssetsHandler) RegisterRoutes(router *mux.Router) { router.NotFoundHandler = sH.loggingHandler(http.HandlerFunc(sH.notFound)) } -func (sH *StaticAssetsHandler) notFound(w http.ResponseWriter, r *http.Request) { +func (sH *StaticAssetsHandler) notFound(w http.ResponseWriter, _ *http.Request) { w.Header().Set("Content-Type", "text/html; charset=utf-8") w.Write(sH.indexHTML.Load().([]byte)) } diff --git a/cmd/query/app/static_handler_test.go b/cmd/query/app/static_handler_test.go index 5f2cda04c87..a7a2bb8b0b6 100644 --- a/cmd/query/app/static_handler_test.go +++ b/cmd/query/app/static_handler_test.go @@ -310,7 +310,7 @@ type fakeFile struct { os.File } -func (*fakeFile) Read(p []byte) (n int, err error) { +func (*fakeFile) Read([]byte) (n int, err error) { return 0, fmt.Errorf("read error") } diff --git a/cmd/remote-storage/app/flags.go b/cmd/remote-storage/app/flags.go index 8e7cebc2f1d..f2858ddd917 100644 --- a/cmd/remote-storage/app/flags.go +++ b/cmd/remote-storage/app/flags.go @@ -52,7 +52,7 @@ func AddFlags(flagSet *flag.FlagSet) { } // InitFromViper initializes Options with properties from CLI flags. -func (o *Options) InitFromViper(v *viper.Viper, logger *zap.Logger) (*Options, error) { +func (o *Options) InitFromViper(v *viper.Viper, _ *zap.Logger) (*Options, error) { o.GRPCHostPort = v.GetString(flagGRPCHostPort) tlsGrpc, err := tlsGRPCFlagsConfig.InitFromViper(v) if err != nil { diff --git a/empty_test.go b/empty_test.go index f47c1cd1584..31f0e3915ae 100644 --- a/empty_test.go +++ b/empty_test.go @@ -20,7 +20,7 @@ import ( "github.com/jaegertracing/jaeger/pkg/testutils" ) -func TestDummy(t *testing.T) { +func TestDummy(*testing.T) { // This is a dummy test in the root package. // Without it `go test -v .` prints "testing: warning: no tests to run". } diff --git a/examples/hotrod/pkg/log/spanlogger.go b/examples/hotrod/pkg/log/spanlogger.go index 98d0f3fce1a..23cb784e0f8 100644 --- a/examples/hotrod/pkg/log/spanlogger.go +++ b/examples/hotrod/pkg/log/spanlogger.go @@ -172,5 +172,5 @@ func (e *bridgeFieldEncoder) AddUintptr(key string, value uintptr) { e.pairs = append(e.pairs, attribute.String(key, fmt.Sprint(value))) } -func (*bridgeFieldEncoder) AddReflected(key string, value any) error { return nil } -func (*bridgeFieldEncoder) OpenNamespace(key string) {} +func (*bridgeFieldEncoder) AddReflected(string /* key */, any /* value */) error { return nil } +func (*bridgeFieldEncoder) OpenNamespace(string /* key */) {} diff --git a/examples/hotrod/pkg/tracing/http.go b/examples/hotrod/pkg/tracing/http.go index bab10ec75f8..4110418e899 100644 --- a/examples/hotrod/pkg/tracing/http.go +++ b/examples/hotrod/pkg/tracing/http.go @@ -46,7 +46,7 @@ func NewHTTPClient(tp trace.TracerProvider) *HTTPClient { // GetJSON executes HTTP GET against specified url and tried to parse // the response into out object. -func (c *HTTPClient) GetJSON(ctx context.Context, endpoint string, url string, out any) error { +func (c *HTTPClient) GetJSON(ctx context.Context, _ string /* endpoint */, url string, out any) error { req, err := http.NewRequestWithContext(ctx, http.MethodGet, url, nil) if err != nil { return err diff --git a/examples/hotrod/pkg/tracing/rpcmetrics/observer.go b/examples/hotrod/pkg/tracing/rpcmetrics/observer.go index 2b14077a10d..0b3702b53c5 100644 --- a/examples/hotrod/pkg/tracing/rpcmetrics/observer.go +++ b/examples/hotrod/pkg/tracing/rpcmetrics/observer.go @@ -48,7 +48,7 @@ func NewObserver(metricsFactory metrics.Factory, normalizer NameNormalizer) *Obs } } -func (*Observer) OnStart(parent context.Context, s sdktrace.ReadWriteSpan) {} +func (*Observer) OnStart(context.Context /* parent */, sdktrace.ReadWriteSpan) {} func (o *Observer) OnEnd(sp sdktrace.ReadOnlySpan) { operationName := sp.Name() @@ -83,10 +83,10 @@ func (o *Observer) OnEnd(sp sdktrace.ReadOnlySpan) { } } -func (*Observer) Shutdown(ctx context.Context) error { +func (*Observer) Shutdown(context.Context) error { return nil } -func (*Observer) ForceFlush(ctx context.Context) error { +func (*Observer) ForceFlush(context.Context) error { return nil } diff --git a/examples/hotrod/services/route/server.go b/examples/hotrod/services/route/server.go index 2cea77ce8e7..668303163dc 100644 --- a/examples/hotrod/services/route/server.go +++ b/examples/hotrod/services/route/server.go @@ -69,7 +69,7 @@ func (s *Server) createServeMux() http.Handler { return mux } -func movedToFrontend(w http.ResponseWriter, r *http.Request) { +func movedToFrontend(w http.ResponseWriter, _ *http.Request) { http.Error(w, "endpoint moved to the frontend service", http.StatusNotFound) } diff --git a/model/converter/empty_test.go b/model/converter/empty_test.go index ea6db368330..4ef8023266f 100644 --- a/model/converter/empty_test.go +++ b/model/converter/empty_test.go @@ -20,7 +20,7 @@ import ( "github.com/jaegertracing/jaeger/pkg/testutils" ) -func TestDummy(t *testing.T) { +func TestDummy(*testing.T) { // This is a dummy test in the root package. // Without it `go test -v .` prints "testing: warning: no tests to run". } diff --git a/model/converter/thrift/empty_test.go b/model/converter/thrift/empty_test.go index a78e79544e4..bb1fe0b2e91 100644 --- a/model/converter/thrift/empty_test.go +++ b/model/converter/thrift/empty_test.go @@ -20,7 +20,7 @@ import ( "github.com/jaegertracing/jaeger/pkg/testutils" ) -func TestDummy(t *testing.T) { +func TestDummy(*testing.T) { // This is a dummy test in the root package. // Without it `go test -v .` prints "testing: warning: no tests to run". } diff --git a/model/hash_test.go b/model/hash_test.go index d62e033f893..1c76813ebc1 100644 --- a/model/hash_test.go +++ b/model/hash_test.go @@ -48,7 +48,7 @@ type errHashable struct { err error } -func (e *errHashable) Hash(w io.Writer) error { +func (e *errHashable) Hash(io.Writer) error { return e.err } diff --git a/model/ids.go b/model/ids.go index 3ffd6412e5e..525bbf874eb 100644 --- a/model/ids.go +++ b/model/ids.go @@ -98,7 +98,7 @@ func (TraceID) MarshalText() ([]byte, error) { } // UnmarshalText is called by encoding/json, which we do not want people to use. -func (*TraceID) UnmarshalText(text []byte) error { +func (*TraceID) UnmarshalText([]byte /* text */) error { return fmt.Errorf("unsupported method TraceID.UnmarshalText; please use github.com/gogo/protobuf/jsonpb for marshalling") } @@ -192,7 +192,7 @@ func (SpanID) MarshalText() ([]byte, error) { } // UnmarshalText is called by encoding/json, which we do not want people to use. -func (*SpanID) UnmarshalText(text []byte) error { +func (*SpanID) UnmarshalText([]byte /* text */) error { return fmt.Errorf("unsupported method SpanID.UnmarshalText; please use github.com/gogo/protobuf/jsonpb for marshalling") } diff --git a/model/process_test.go b/model/process_test.go index d80f842312c..2551a075e26 100644 --- a/model/process_test.go +++ b/model/process_test.go @@ -60,7 +60,7 @@ func Hash(w io.Writer) { w.Write([]byte("hello")) } -func TestX(t *testing.T) { +func TestX(*testing.T) { h := fnv.New64a() Hash(h) } diff --git a/pkg/cache/lru_test.go b/pkg/cache/lru_test.go index 2e8d462ef35..dce4c2406a2 100644 --- a/pkg/cache/lru_test.go +++ b/pkg/cache/lru_test.go @@ -139,7 +139,7 @@ func TestDefaultClock(t *testing.T) { assert.Equal(t, 0, cache.Size()) } -func TestLRUCacheConcurrentAccess(t *testing.T) { +func TestLRUCacheConcurrentAccess(*testing.T) { cache := NewLRU(5) values := map[string]string{ "A": "foo", diff --git a/pkg/cassandra/metrics/table_test.go b/pkg/cassandra/metrics/table_test.go index dab69b1b2ec..beffaafde1a 100644 --- a/pkg/cassandra/metrics/table_test.go +++ b/pkg/cassandra/metrics/table_test.go @@ -155,7 +155,7 @@ func (q insertQuery) String() string { return q.str } -func (insertQuery) ScanCAS(dest ...any) (bool, error) { +func (insertQuery) ScanCAS(...any /* dest */) (bool, error) { return true, nil } diff --git a/pkg/clientcfg/clientcfghttp/cfgmgr_test.go b/pkg/clientcfg/clientcfghttp/cfgmgr_test.go index c5a7e2a9971..53dd14e7868 100644 --- a/pkg/clientcfg/clientcfghttp/cfgmgr_test.go +++ b/pkg/clientcfg/clientcfghttp/cfgmgr_test.go @@ -30,7 +30,7 @@ type mockSamplingStore struct { samplingResponse *api_v2.SamplingStrategyResponse } -func (m *mockSamplingStore) GetSamplingStrategy(_ context.Context, serviceName string) (*api_v2.SamplingStrategyResponse, error) { +func (m *mockSamplingStore) GetSamplingStrategy(context.Context, string /* serviceName */) (*api_v2.SamplingStrategyResponse, error) { if m.samplingResponse == nil { return nil, errors.New("no mock response provided") } @@ -45,7 +45,7 @@ type mockBaggageMgr struct { baggageResponse []*baggage.BaggageRestriction } -func (m *mockBaggageMgr) GetBaggageRestrictions(_ context.Context, serviceName string) ([]*baggage.BaggageRestriction, error) { +func (m *mockBaggageMgr) GetBaggageRestrictions(context.Context, string /* serviceName */) ([]*baggage.BaggageRestriction, error) { if m.baggageResponse == nil { return nil, errors.New("no mock response provided") } diff --git a/pkg/discovery/grpcresolver/grpc_resolver.go b/pkg/discovery/grpcresolver/grpc_resolver.go index 852da1032ba..8783b19f843 100644 --- a/pkg/discovery/grpcresolver/grpc_resolver.go +++ b/pkg/discovery/grpcresolver/grpc_resolver.go @@ -85,7 +85,7 @@ func New( } // Build returns itself for Resolver, because it's both a builder and a resolver. -func (r *Resolver) Build(target resolver.Target, cc resolver.ClientConn, opts resolver.BuildOptions) (resolver.Resolver, error) { +func (r *Resolver) Build(_ resolver.Target, cc resolver.ClientConn, _ resolver.BuildOptions) (resolver.Resolver, error) { r.cc = cc // Update conn states if proactively updates already work @@ -106,7 +106,7 @@ func (r *Resolver) Scheme() string { // ResolveNow is a noop for Resolver since resolver is already firing r.cc.UpdatesState every time // it receives updates of new instance from discoCh -func (*Resolver) ResolveNow(o resolver.ResolveNowOptions) {} +func (*Resolver) ResolveNow(resolver.ResolveNowOptions) {} func (r *Resolver) watcher() { defer r.closing.Done() diff --git a/pkg/discovery/grpcresolver/grpc_resolver_test.go b/pkg/discovery/grpcresolver/grpc_resolver_test.go index 5488508fcfd..9256570cc6f 100644 --- a/pkg/discovery/grpcresolver/grpc_resolver_test.go +++ b/pkg/discovery/grpcresolver/grpc_resolver_test.go @@ -44,7 +44,7 @@ type test struct { addresses []string } -func (*testServer) EmptyCall(ctx context.Context, in *grpc_testing.Empty) (*grpc_testing.Empty, error) { +func (*testServer) EmptyCall(context.Context, *grpc_testing.Empty /* in */) (*grpc_testing.Empty, error) { return &grpc_testing.Empty{}, nil } diff --git a/pkg/empty_test.go b/pkg/empty_test.go index ae11c0ea819..9e7600c9553 100644 --- a/pkg/empty_test.go +++ b/pkg/empty_test.go @@ -20,7 +20,7 @@ import ( "github.com/jaegertracing/jaeger/pkg/testutils" ) -func TestDummy(t *testing.T) { +func TestDummy(*testing.T) { // This is a dummy test in the root package. // Without it `go test -v .` prints "testing: warning: no tests to run". } diff --git a/pkg/es/wrapper/wrapper.go b/pkg/es/wrapper/wrapper.go index 16e503020eb..8e20263c16a 100644 --- a/pkg/es/wrapper/wrapper.go +++ b/pkg/es/wrapper/wrapper.go @@ -199,7 +199,7 @@ func (c TemplateCreatorWrapperV8) Body(mapping string) es.TemplateCreateService } // Do executes Put Template command. -func (c TemplateCreatorWrapperV8) Do(ctx context.Context) (*elastic.IndicesPutTemplateResponse, error) { +func (c TemplateCreatorWrapperV8) Do(context.Context) (*elastic.IndicesPutTemplateResponse, error) { resp, err := c.indicesV8.PutIndexTemplate(c.templateName, strings.NewReader(c.templateMapping)) if err != nil { return nil, fmt.Errorf("error creating index template %s: %w", c.templateName, err) diff --git a/pkg/metrics/factory.go b/pkg/metrics/factory.go index e77257127d9..b1b9000a285 100644 --- a/pkg/metrics/factory.go +++ b/pkg/metrics/factory.go @@ -64,19 +64,19 @@ var NullFactory Factory = nullFactory{} type nullFactory struct{} -func (nullFactory) Counter(options Options) Counter { +func (nullFactory) Counter(Options) Counter { return NullCounter } -func (nullFactory) Timer(options TimerOptions) Timer { +func (nullFactory) Timer(TimerOptions) Timer { return NullTimer } -func (nullFactory) Gauge(options Options) Gauge { +func (nullFactory) Gauge(Options) Gauge { return NullGauge } -func (nullFactory) Histogram(options HistogramOptions) Histogram { +func (nullFactory) Histogram(HistogramOptions) Histogram { return NullHistogram } -func (nullFactory) Namespace(scope NSOptions) Factory { return NullFactory } +func (nullFactory) Namespace(NSOptions /* scope */) Factory { return NullFactory } diff --git a/pkg/metrics/metrics_test.go b/pkg/metrics/metrics_test.go index d9ca191c795..7c75d4a00df 100644 --- a/pkg/metrics/metrics_test.go +++ b/pkg/metrics/metrics_test.go @@ -124,7 +124,7 @@ func TestInitPanic(t *testing.T) { metrics.MustInit(&noMetricTag, metrics.NullFactory, nil) } -func TestNullMetrics(t *testing.T) { +func TestNullMetrics(*testing.T) { // This test is just for cover metrics.NullFactory.Timer(metrics.TimerOptions{ Name: "name", diff --git a/pkg/tenancy/http_test.go b/pkg/tenancy/http_test.go index 4117bcb4b60..d28ef906d67 100644 --- a/pkg/tenancy/http_test.go +++ b/pkg/tenancy/http_test.go @@ -29,7 +29,7 @@ type testHttpHandler struct { reached bool } -func (thh *testHttpHandler) ServeHTTP(res http.ResponseWriter, req *http.Request) { +func (thh *testHttpHandler) ServeHTTP(http.ResponseWriter, *http.Request) { thh.reached = true } diff --git a/pkg/tenancy/manager.go b/pkg/tenancy/manager.go index 9f6addf1471..5042b7a0b2a 100644 --- a/pkg/tenancy/manager.go +++ b/pkg/tenancy/manager.go @@ -53,7 +53,7 @@ func (tc *Manager) Valid(tenant string) bool { type tenantDontCare bool -func (tenantDontCare) Valid(candidate string) bool { +func (tenantDontCare) Valid(string /* candidate */) bool { return true } diff --git a/pkg/testutils/logger_test.go b/pkg/testutils/logger_test.go index d36d96fdcc9..79998375f8d 100644 --- a/pkg/testutils/logger_test.go +++ b/pkg/testutils/logger_test.go @@ -49,7 +49,7 @@ func TestJSONLineError(t *testing.T) { } // NB. Run with -race to ensure no race condition -func TestRaceCondition(t *testing.T) { +func TestRaceCondition(*testing.T) { logger, buffer := NewLogger() start := make(chan struct{}) diff --git a/plugin/metrics/disabled/reader.go b/plugin/metrics/disabled/reader.go index 8b104b84c5b..1e6937373e1 100644 --- a/plugin/metrics/disabled/reader.go +++ b/plugin/metrics/disabled/reader.go @@ -44,21 +44,21 @@ func NewMetricsReader() (*MetricsReader, error) { } // GetLatencies gets the latency metrics for the given set of latency query parameters. -func (*MetricsReader) GetLatencies(ctx context.Context, requestParams *metricsstore.LatenciesQueryParameters) (*metrics.MetricFamily, error) { +func (*MetricsReader) GetLatencies(context.Context, *metricsstore.LatenciesQueryParameters) (*metrics.MetricFamily, error) { return nil, ErrDisabled } // GetCallRates gets the call rate metrics for the given set of call rate query parameters. -func (*MetricsReader) GetCallRates(ctx context.Context, requestParams *metricsstore.CallRateQueryParameters) (*metrics.MetricFamily, error) { +func (*MetricsReader) GetCallRates(context.Context, *metricsstore.CallRateQueryParameters) (*metrics.MetricFamily, error) { return nil, ErrDisabled } // GetErrorRates gets the error rate metrics for the given set of error rate query parameters. -func (*MetricsReader) GetErrorRates(ctx context.Context, requestParams *metricsstore.ErrorRateQueryParameters) (*metrics.MetricFamily, error) { +func (*MetricsReader) GetErrorRates(context.Context, *metricsstore.ErrorRateQueryParameters) (*metrics.MetricFamily, error) { return nil, ErrDisabled } // GetMinStepDuration gets the minimum step duration (the smallest possible duration between two data points in a time series) supported. -func (*MetricsReader) GetMinStepDuration(_ context.Context, _ *metricsstore.MinStepDurationQueryParameters) (time.Duration, error) { +func (*MetricsReader) GetMinStepDuration(context.Context, *metricsstore.MinStepDurationQueryParameters) (time.Duration, error) { return 0, ErrDisabled } diff --git a/plugin/sampling/strategystore/adaptive/factory.go b/plugin/sampling/strategystore/adaptive/factory.go index 35a583d4800..baead570e3a 100644 --- a/plugin/sampling/strategystore/adaptive/factory.go +++ b/plugin/sampling/strategystore/adaptive/factory.go @@ -59,7 +59,7 @@ func (*Factory) AddFlags(flagSet *flag.FlagSet) { } // InitFromViper implements plugin.Configurable -func (f *Factory) InitFromViper(v *viper.Viper, logger *zap.Logger) { +func (f *Factory) InitFromViper(v *viper.Viper, _ *zap.Logger) { f.options.InitFromViper(v) } diff --git a/plugin/sampling/strategystore/adaptive/factory_test.go b/plugin/sampling/strategystore/adaptive/factory_test.go index 39157f1f39c..df1d54fda1a 100644 --- a/plugin/sampling/strategystore/adaptive/factory_test.go +++ b/plugin/sampling/strategystore/adaptive/factory_test.go @@ -131,7 +131,7 @@ func (m *mockSamplingStoreFactory) CreateLock() (distributedlock.Lock, error) { return mockLock, nil } -func (m *mockSamplingStoreFactory) CreateSamplingStore(maxBuckets int) (samplingstore.Store, error) { +func (m *mockSamplingStoreFactory) CreateSamplingStore(int /* maxBuckets */) (samplingstore.Store, error) { if m.storeFailsWith != nil { return nil, m.storeFailsWith } diff --git a/plugin/sampling/strategystore/factory_test.go b/plugin/sampling/strategystore/factory_test.go index 28e8f47182d..9af5850109a 100644 --- a/plugin/sampling/strategystore/factory_test.go +++ b/plugin/sampling/strategystore/factory_test.go @@ -139,7 +139,7 @@ func (f *mockFactory) CreateStrategyStore() (ss.StrategyStore, ss.Aggregator, er return nil, nil, nil } -func (f *mockFactory) Initialize(metricsFactory metrics.Factory, ssFactory storage.SamplingStoreFactory, logger *zap.Logger) error { +func (f *mockFactory) Initialize(metrics.Factory, storage.SamplingStoreFactory, *zap.Logger) error { if f.retError { return errors.New("error initializing store") } @@ -159,6 +159,6 @@ func (*mockSamplingStoreFactory) CreateLock() (distributedlock.Lock, error) { return nil, nil } -func (*mockSamplingStoreFactory) CreateSamplingStore(maxBuckets int) (samplingstore.Store, error) { +func (*mockSamplingStoreFactory) CreateSamplingStore(int /* maxBuckets */) (samplingstore.Store, error) { return nil, nil } diff --git a/plugin/sampling/strategystore/static/factory.go b/plugin/sampling/strategystore/static/factory.go index d2fb0a8d8a9..3f16548459d 100644 --- a/plugin/sampling/strategystore/static/factory.go +++ b/plugin/sampling/strategystore/static/factory.go @@ -48,7 +48,7 @@ func (*Factory) AddFlags(flagSet *flag.FlagSet) { } // InitFromViper implements plugin.Configurable -func (f *Factory) InitFromViper(v *viper.Viper, logger *zap.Logger) { +func (f *Factory) InitFromViper(v *viper.Viper, _ *zap.Logger) { f.options.InitFromViper(v) } diff --git a/plugin/storage/badger/factory.go b/plugin/storage/badger/factory.go index 5e223625efa..ab1c41ff1d7 100644 --- a/plugin/storage/badger/factory.go +++ b/plugin/storage/badger/factory.go @@ -199,7 +199,7 @@ func (f *Factory) CreateDependencyReader() (dependencystore.Reader, error) { } // CreateSamplingStore implements storage.SamplingStoreFactory -func (f *Factory) CreateSamplingStore(maxBuckets int) (samplingstore.Store, error) { +func (f *Factory) CreateSamplingStore(int /* maxBuckets */) (samplingstore.Store, error) { return badgerSampling.NewSamplingStore(f.store), nil } diff --git a/plugin/storage/badger/lock.go b/plugin/storage/badger/lock.go index dc86669cf4e..e8b3368057c 100644 --- a/plugin/storage/badger/lock.go +++ b/plugin/storage/badger/lock.go @@ -19,11 +19,11 @@ import "time" type lock struct{} // Acquire always returns true for badgerdb as no lock is needed -func (*lock) Acquire(resource string, ttl time.Duration) (bool, error) { +func (*lock) Acquire(string /* resource */, time.Duration /* ttl */) (bool, error) { return true, nil } // Forfeit always returns true for badgerdb as no lock is needed -func (*lock) Forfeit(resource string) (bool, error) { +func (*lock) Forfeit(string /* resource */) (bool, error) { return true, nil } diff --git a/plugin/storage/badger/options.go b/plugin/storage/badger/options.go index 22b8ffb14a9..f756cf421eb 100644 --- a/plugin/storage/badger/options.go +++ b/plugin/storage/badger/options.go @@ -65,7 +65,7 @@ const ( ) // NewOptions creates a new Options struct. -func NewOptions(primaryNamespace string, otherNamespaces ...string) *Options { +func NewOptions(primaryNamespace string, _ ...string /* otherNamespaces */) *Options { defaultBadgerDataDir := getCurrentExecutableDir() options := &Options{ @@ -143,7 +143,7 @@ func (opt *Options) InitFromViper(v *viper.Viper, logger *zap.Logger) { initFromViper(&opt.Primary, v, logger) } -func initFromViper(cfg *NamespaceConfig, v *viper.Viper, logger *zap.Logger) { +func initFromViper(cfg *NamespaceConfig, v *viper.Viper, _ *zap.Logger) { cfg.Ephemeral = v.GetBool(cfg.namespace + suffixEphemeral) cfg.KeyDirectory = v.GetString(cfg.namespace + suffixKeyDirectory) cfg.ValueDirectory = v.GetString(cfg.namespace + suffixValueDirectory) diff --git a/plugin/storage/badger/spanstore/read_write_test.go b/plugin/storage/badger/spanstore/read_write_test.go index a7655741260..9c4e4462785 100644 --- a/plugin/storage/badger/spanstore/read_write_test.go +++ b/plugin/storage/badger/spanstore/read_write_test.go @@ -538,7 +538,7 @@ func makeWriteSupports(tagsCount, spans int) ([]model.KeyValue, []string, []stri return tags, services, operations } -func makeReadBenchmark(b *testing.B, tid time.Time, params *spanstore.TraceQueryParameters, outputFile string) { +func makeReadBenchmark(b *testing.B, _ time.Time, params *spanstore.TraceQueryParameters, outputFile string) { runLargeFactoryTest(b, func(tb testing.TB, sw spanstore.Writer, sr spanstore.Reader) { tid := time.Now() diff --git a/plugin/storage/badger/spanstore/reader.go b/plugin/storage/badger/spanstore/reader.go index 484deeaa575..955aa723903 100644 --- a/plugin/storage/badger/spanstore/reader.go +++ b/plugin/storage/badger/spanstore/reader.go @@ -157,7 +157,7 @@ func (r *TraceReader) getTraces(traceIDs []model.TraceID) ([]*model.Trace, error } // GetTrace takes a traceID and returns a Trace associated with that traceID -func (r *TraceReader) GetTrace(ctx context.Context, traceID model.TraceID) (*model.Trace, error) { +func (r *TraceReader) GetTrace(_ context.Context, traceID model.TraceID) (*model.Trace, error) { traces, err := r.getTraces([]model.TraceID{traceID}) if err != nil { return nil, err @@ -241,13 +241,13 @@ func createPrimaryKeySeekPrefix(traceID model.TraceID) []byte { } // GetServices fetches the sorted service list that have not expired -func (r *TraceReader) GetServices(ctx context.Context) ([]string, error) { +func (r *TraceReader) GetServices(context.Context) ([]string, error) { return r.cache.GetServices() } // GetOperations fetches operations in the service and empty slice if service does not exists func (r *TraceReader) GetOperations( - ctx context.Context, + _ context.Context, query spanstore.OperationQueryParameters, ) ([]spanstore.Operation, error) { return r.cache.GetOperations(query.ServiceName) @@ -464,7 +464,7 @@ func (r *TraceReader) FindTraces(ctx context.Context, query *spanstore.TraceQuer } // FindTraceIDs retrieves only the TraceIDs that match the traceQuery, but not the trace data -func (r *TraceReader) FindTraceIDs(ctx context.Context, query *spanstore.TraceQueryParameters) ([]model.TraceID, error) { +func (r *TraceReader) FindTraceIDs(_ context.Context, query *spanstore.TraceQueryParameters) ([]model.TraceID, error) { // Validate and set query defaults which were not defined if err := validateQuery(query); err != nil { return nil, err diff --git a/plugin/storage/badger/spanstore/writer.go b/plugin/storage/badger/spanstore/writer.go index 0265e6c1e38..323974c5739 100644 --- a/plugin/storage/badger/spanstore/writer.go +++ b/plugin/storage/badger/spanstore/writer.go @@ -65,7 +65,7 @@ func NewSpanWriter(db *badger.DB, c *CacheStore, ttl time.Duration) *SpanWriter } // WriteSpan writes the encoded span as well as creates indexes with defined TTL -func (w *SpanWriter) WriteSpan(ctx context.Context, span *model.Span) error { +func (w *SpanWriter) WriteSpan(_ context.Context, span *model.Span) error { expireTime := uint64(time.Now().Add(w.ttl).Unix()) startTime := model.TimeAsEpochMicroseconds(span.StartTime) diff --git a/plugin/storage/blackhole/blackhole.go b/plugin/storage/blackhole/blackhole.go index 924203527db..f1af3996cae 100644 --- a/plugin/storage/blackhole/blackhole.go +++ b/plugin/storage/blackhole/blackhole.go @@ -37,39 +37,39 @@ func NewStore() *Store { } // GetDependencies returns nothing. -func (*Store) GetDependencies(ctx context.Context, endTs time.Time, lookback time.Duration) ([]model.DependencyLink, error) { +func (*Store) GetDependencies(context.Context, time.Time /* endTs */, time.Duration /* lookback */) ([]model.DependencyLink, error) { return []model.DependencyLink{}, nil } // WriteSpan writes the given span to blackhole. -func (*Store) WriteSpan(ctx context.Context, span *model.Span) error { +func (*Store) WriteSpan(context.Context, *model.Span) error { return nil } // GetTrace gets nothing. -func (*Store) GetTrace(ctx context.Context, traceID model.TraceID) (*model.Trace, error) { +func (*Store) GetTrace(context.Context, model.TraceID) (*model.Trace, error) { return nil, spanstore.ErrTraceNotFound } // GetServices returns nothing. -func (*Store) GetServices(ctx context.Context) ([]string, error) { +func (*Store) GetServices(context.Context) ([]string, error) { return []string{}, nil } // GetOperations returns nothing. func (*Store) GetOperations( - ctx context.Context, - query spanstore.OperationQueryParameters, + context.Context, + spanstore.OperationQueryParameters, ) ([]spanstore.Operation, error) { return []spanstore.Operation{}, nil } // FindTraces returns nothing. -func (*Store) FindTraces(ctx context.Context, query *spanstore.TraceQueryParameters) ([]*model.Trace, error) { +func (*Store) FindTraces(context.Context, *spanstore.TraceQueryParameters) ([]*model.Trace, error) { return []*model.Trace{}, nil } // FindTraceIDs returns nothing. -func (*Store) FindTraceIDs(ctx context.Context, query *spanstore.TraceQueryParameters) ([]model.TraceID, error) { +func (*Store) FindTraceIDs(context.Context, *spanstore.TraceQueryParameters) ([]model.TraceID, error) { return []model.TraceID{}, nil } diff --git a/plugin/storage/cassandra/dependencystore/storage.go b/plugin/storage/cassandra/dependencystore/storage.go index 7906f63c552..b7df818d024 100644 --- a/plugin/storage/cassandra/dependencystore/storage.go +++ b/plugin/storage/cassandra/dependencystore/storage.go @@ -105,7 +105,7 @@ func (s *DependencyStore) WriteDependencies(ts time.Time, dependencies []model.D } // GetDependencies returns all interservice dependencies -func (s *DependencyStore) GetDependencies(ctx context.Context, endTs time.Time, lookback time.Duration) ([]model.DependencyLink, error) { +func (s *DependencyStore) GetDependencies(_ context.Context, endTs time.Time, lookback time.Duration) ([]model.DependencyLink, error) { startTs := endTs.Add(-1 * lookback) var query cassandra.Query switch s.version { diff --git a/plugin/storage/cassandra/factory.go b/plugin/storage/cassandra/factory.go index ae082e99cc5..a3bcc895f95 100644 --- a/plugin/storage/cassandra/factory.go +++ b/plugin/storage/cassandra/factory.go @@ -124,7 +124,7 @@ func (f *Factory) AddFlags(flagSet *flag.FlagSet) { } // InitFromViper implements plugin.Configurable -func (f *Factory) InitFromViper(v *viper.Viper, logger *zap.Logger) { +func (f *Factory) InitFromViper(v *viper.Viper, _ *zap.Logger) { f.Options.InitFromViper(v) f.configureFromOptions(f.Options) } @@ -218,7 +218,7 @@ func (f *Factory) CreateLock() (distributedlock.Lock, error) { } // CreateSamplingStore implements storage.SamplingStoreFactory -func (f *Factory) CreateSamplingStore(maxBuckets int) (samplingstore.Store, error) { +func (f *Factory) CreateSamplingStore(int /* maxBuckets */) (samplingstore.Store, error) { return cSamplingStore.New(f.primarySession, f.primaryMetricsFactory, f.logger), nil } diff --git a/plugin/storage/cassandra/spanstore/dbmodel/cql_udt.go b/plugin/storage/cassandra/spanstore/dbmodel/cql_udt.go index 0a8a6369005..5fa44b2ddaa 100644 --- a/plugin/storage/cassandra/spanstore/dbmodel/cql_udt.go +++ b/plugin/storage/cassandra/spanstore/dbmodel/cql_udt.go @@ -26,12 +26,12 @@ import ( var ErrTraceIDWrongLength = errors.New("TraceID is not a 128bit integer") // MarshalCQL handles marshaling DBTraceID (e.g. in SpanRef) -func (t TraceID) MarshalCQL(info gocql.TypeInfo) ([]byte, error) { +func (t TraceID) MarshalCQL(gocql.TypeInfo) ([]byte, error) { return t[:], nil } // UnmarshalCQL handles unmarshaling DBTraceID (e.g. in SpanRef) -func (t *TraceID) UnmarshalCQL(info gocql.TypeInfo, data []byte) error { +func (t *TraceID) UnmarshalCQL(_ gocql.TypeInfo, data []byte) error { if len(data) != 16 { return ErrTraceIDWrongLength } diff --git a/plugin/storage/cassandra/spanstore/dbmodel/tag_filter.go b/plugin/storage/cassandra/spanstore/dbmodel/tag_filter.go index bb8749972d5..b232b32d520 100644 --- a/plugin/storage/cassandra/spanstore/dbmodel/tag_filter.go +++ b/plugin/storage/cassandra/spanstore/dbmodel/tag_filter.go @@ -63,14 +63,14 @@ var DefaultTagFilter = tagFilterImpl{} type tagFilterImpl struct{} -func (tagFilterImpl) FilterProcessTags(span *model.Span, processTags model.KeyValues) model.KeyValues { +func (tagFilterImpl) FilterProcessTags(_ *model.Span, processTags model.KeyValues) model.KeyValues { return processTags } -func (tagFilterImpl) FilterTags(span *model.Span, tags model.KeyValues) model.KeyValues { +func (tagFilterImpl) FilterTags(_ *model.Span, tags model.KeyValues) model.KeyValues { return tags } -func (tagFilterImpl) FilterLogFields(span *model.Span, logFields model.KeyValues) model.KeyValues { +func (tagFilterImpl) FilterLogFields(_ *model.Span, logFields model.KeyValues) model.KeyValues { return logFields } diff --git a/plugin/storage/cassandra/spanstore/dbmodel/tag_filter_drop_all.go b/plugin/storage/cassandra/spanstore/dbmodel/tag_filter_drop_all.go index c22eeafdc6b..49e724c1099 100644 --- a/plugin/storage/cassandra/spanstore/dbmodel/tag_filter_drop_all.go +++ b/plugin/storage/cassandra/spanstore/dbmodel/tag_filter_drop_all.go @@ -35,7 +35,7 @@ func NewTagFilterDropAll(dropTags bool, dropProcessTags bool, dropLogs bool) *Ta } // FilterProcessTags implements TagFilter -func (f *TagFilterDropAll) FilterProcessTags(span *model.Span, processTags model.KeyValues) model.KeyValues { +func (f *TagFilterDropAll) FilterProcessTags(_ *model.Span, processTags model.KeyValues) model.KeyValues { if f.dropProcessTags { return model.KeyValues{} } @@ -43,7 +43,7 @@ func (f *TagFilterDropAll) FilterProcessTags(span *model.Span, processTags model } // FilterTags implements TagFilter -func (f *TagFilterDropAll) FilterTags(span *model.Span, tags model.KeyValues) model.KeyValues { +func (f *TagFilterDropAll) FilterTags(_ *model.Span, tags model.KeyValues) model.KeyValues { if f.dropTags { return model.KeyValues{} } @@ -51,7 +51,7 @@ func (f *TagFilterDropAll) FilterTags(span *model.Span, tags model.KeyValues) mo } // FilterLogFields implements TagFilter -func (f *TagFilterDropAll) FilterLogFields(span *model.Span, logFields model.KeyValues) model.KeyValues { +func (f *TagFilterDropAll) FilterLogFields(_ *model.Span, logFields model.KeyValues) model.KeyValues { if f.dropLogs { return model.KeyValues{} } diff --git a/plugin/storage/cassandra/spanstore/dbmodel/tag_filter_exact_match.go b/plugin/storage/cassandra/spanstore/dbmodel/tag_filter_exact_match.go index 51917a9bff4..06670036388 100644 --- a/plugin/storage/cassandra/spanstore/dbmodel/tag_filter_exact_match.go +++ b/plugin/storage/cassandra/spanstore/dbmodel/tag_filter_exact_match.go @@ -49,17 +49,17 @@ func NewWhitelistFilter(tags []string) ExactMatchTagFilter { } // FilterProcessTags implements TagFilter -func (tf ExactMatchTagFilter) FilterProcessTags(span *model.Span, processTags model.KeyValues) model.KeyValues { +func (tf ExactMatchTagFilter) FilterProcessTags(_ *model.Span, processTags model.KeyValues) model.KeyValues { return tf.filter(processTags) } // FilterTags implements TagFilter -func (tf ExactMatchTagFilter) FilterTags(span *model.Span, tags model.KeyValues) model.KeyValues { +func (tf ExactMatchTagFilter) FilterTags(_ *model.Span, tags model.KeyValues) model.KeyValues { return tf.filter(tags) } // FilterLogFields implements TagFilter -func (tf ExactMatchTagFilter) FilterLogFields(span *model.Span, logFields model.KeyValues) model.KeyValues { +func (tf ExactMatchTagFilter) FilterLogFields(_ *model.Span, logFields model.KeyValues) model.KeyValues { return tf.filter(logFields) } diff --git a/plugin/storage/cassandra/spanstore/dbmodel/tag_filter_test.go b/plugin/storage/cassandra/spanstore/dbmodel/tag_filter_test.go index e9c872f9eb3..e5327f86f0d 100644 --- a/plugin/storage/cassandra/spanstore/dbmodel/tag_filter_test.go +++ b/plugin/storage/cassandra/spanstore/dbmodel/tag_filter_test.go @@ -47,15 +47,15 @@ func (onlyStringsFilter) filterStringTags(tags model.KeyValues) model.KeyValues return ret } -func (f onlyStringsFilter) FilterProcessTags(span *model.Span, processTags model.KeyValues) model.KeyValues { +func (f onlyStringsFilter) FilterProcessTags(_ *model.Span, processTags model.KeyValues) model.KeyValues { return f.filterStringTags(processTags) } -func (f onlyStringsFilter) FilterTags(span *model.Span, tags model.KeyValues) model.KeyValues { +func (f onlyStringsFilter) FilterTags(_ *model.Span, tags model.KeyValues) model.KeyValues { return f.filterStringTags(tags) } -func (f onlyStringsFilter) FilterLogFields(span *model.Span, logFields model.KeyValues) model.KeyValues { +func (f onlyStringsFilter) FilterLogFields(_ *model.Span, logFields model.KeyValues) model.KeyValues { return f.filterStringTags(logFields) } diff --git a/plugin/storage/cassandra/spanstore/reader.go b/plugin/storage/cassandra/spanstore/reader.go index 1f32be79c62..7ef2f23250f 100644 --- a/plugin/storage/cassandra/spanstore/reader.go +++ b/plugin/storage/cassandra/spanstore/reader.go @@ -142,13 +142,13 @@ func NewSpanReader( } // GetServices returns all services traced by Jaeger -func (s *SpanReader) GetServices(ctx context.Context) ([]string, error) { +func (s *SpanReader) GetServices(context.Context) ([]string, error) { return s.serviceNamesReader() } // GetOperations returns all operations for a specific service traced by Jaeger func (s *SpanReader) GetOperations( - ctx context.Context, + _ context.Context, query spanstore.OperationQueryParameters, ) ([]spanstore.Operation, error) { return s.operationNamesReader(query) @@ -164,7 +164,7 @@ func (s *SpanReader) readTrace(ctx context.Context, traceID dbmodel.TraceID) (*m return trace, err } -func (s *SpanReader) readTraceInSpan(ctx context.Context, traceID dbmodel.TraceID) (*model.Trace, error) { +func (s *SpanReader) readTraceInSpan(_ context.Context, traceID dbmodel.TraceID) (*model.Trace, error) { start := time.Now() q := s.session.Query(querySpanByTraceID, traceID) i := q.Iter() diff --git a/plugin/storage/cassandra/spanstore/writer.go b/plugin/storage/cassandra/spanstore/writer.go index 615dfcedbc3..c26bf3e911d 100644 --- a/plugin/storage/cassandra/spanstore/writer.go +++ b/plugin/storage/cassandra/spanstore/writer.go @@ -138,7 +138,7 @@ func (s *SpanWriter) Close() error { } // WriteSpan saves the span into Cassandra -func (s *SpanWriter) WriteSpan(ctx context.Context, span *model.Span) error { +func (s *SpanWriter) WriteSpan(_ context.Context, span *model.Span) error { ds := dbmodel.FromDomain(span) if s.storageMode&storeFlag == storeFlag { if err := s.writeSpan(span, ds); err != nil { @@ -153,7 +153,7 @@ func (s *SpanWriter) WriteSpan(ctx context.Context, span *model.Span) error { return nil } -func (s *SpanWriter) writeSpan(span *model.Span, ds *dbmodel.Span) error { +func (s *SpanWriter) writeSpan(_ *model.Span, ds *dbmodel.Span) error { mainQuery := s.session.Query( insertSpan, ds.TraceID, diff --git a/plugin/storage/es/factory.go b/plugin/storage/es/factory.go index d1c53821336..267254d260d 100644 --- a/plugin/storage/es/factory.go +++ b/plugin/storage/es/factory.go @@ -126,7 +126,7 @@ func (f *Factory) AddFlags(flagSet *flag.FlagSet) { } // InitFromViper implements plugin.Configurable -func (f *Factory) InitFromViper(v *viper.Viper, logger *zap.Logger) { +func (f *Factory) InitFromViper(v *viper.Viper, _ *zap.Logger) { f.Options.InitFromViper(v) f.configureFromOptions(f.Options) } @@ -296,7 +296,7 @@ func createSpanWriter( return writer, nil } -func (f *Factory) CreateSamplingStore(maxBuckets int) (samplingstore.Store, error) { +func (f *Factory) CreateSamplingStore(int /* maxBuckets */) (samplingstore.Store, error) { params := esSampleStore.Params{ Client: f.getPrimaryClient, Logger: f.logger, diff --git a/plugin/storage/es/factory_test.go b/plugin/storage/es/factory_test.go index a79e2942a19..2e3b4056e43 100644 --- a/plugin/storage/es/factory_test.go +++ b/plugin/storage/es/factory_test.go @@ -57,7 +57,7 @@ type mockClientBuilder struct { createTemplateError error } -func (m *mockClientBuilder) NewClient(_ *escfg.Configuration, logger *zap.Logger, metricsFactory metrics.Factory) (es.Client, error) { +func (m *mockClientBuilder) NewClient(*escfg.Configuration, *zap.Logger, metrics.Factory) (es.Client, error) { if m.err == nil { c := &mocks.Client{} tService := &mocks.TemplateCreateService{} diff --git a/plugin/storage/es/spanstore/service_operation_test.go b/plugin/storage/es/spanstore/service_operation_test.go index 515e9fbafcd..521f21c6d71 100644 --- a/plugin/storage/es/spanstore/service_operation_test.go +++ b/plugin/storage/es/spanstore/service_operation_test.go @@ -64,7 +64,7 @@ func TestWriteService(t *testing.T) { }) } -func TestWriteServiceError(t *testing.T) { +func TestWriteServiceError(*testing.T) { withSpanWriter(func(w *spanWriterTest) { indexService := &mocks.IndexService{} diff --git a/plugin/storage/factory_test.go b/plugin/storage/factory_test.go index b99aef57efc..00ffad2b5fd 100644 --- a/plugin/storage/factory_test.go +++ b/plugin/storage/factory_test.go @@ -422,7 +422,7 @@ var ( _ io.Closer = (*errorFactory)(nil) ) -func (errorFactory) Initialize(metricsFactory metrics.Factory, logger *zap.Logger) error { +func (errorFactory) Initialize(metrics.Factory, *zap.Logger) error { panic("implement me") } diff --git a/plugin/storage/grpc/shared/archive.go b/plugin/storage/grpc/shared/archive.go index 1fceabddb03..1dacae3fcdf 100644 --- a/plugin/storage/grpc/shared/archive.go +++ b/plugin/storage/grpc/shared/archive.go @@ -58,22 +58,22 @@ func (r *archiveReader) GetTrace(ctx context.Context, traceID model.TraceID) (*m } // GetServices not used in archiveReader -func (*archiveReader) GetServices(ctx context.Context) ([]string, error) { +func (*archiveReader) GetServices(context.Context) ([]string, error) { return nil, errors.New("GetServices not implemented") } // GetOperations not used in archiveReader -func (*archiveReader) GetOperations(ctx context.Context, query spanstore.OperationQueryParameters) ([]spanstore.Operation, error) { +func (*archiveReader) GetOperations(context.Context, spanstore.OperationQueryParameters) ([]spanstore.Operation, error) { return nil, errors.New("GetOperations not implemented") } // FindTraces not used in archiveReader -func (*archiveReader) FindTraces(ctx context.Context, query *spanstore.TraceQueryParameters) ([]*model.Trace, error) { +func (*archiveReader) FindTraces(context.Context, *spanstore.TraceQueryParameters) ([]*model.Trace, error) { return nil, errors.New("FindTraces not implemented") } // FindTraceIDs not used in archiveReader -func (*archiveReader) FindTraceIDs(ctx context.Context, query *spanstore.TraceQueryParameters) ([]model.TraceID, error) { +func (*archiveReader) FindTraceIDs(context.Context, *spanstore.TraceQueryParameters) ([]model.TraceID, error) { return nil, errors.New("FindTraceIDs not implemented") } diff --git a/plugin/storage/grpc/shared/grpc_handler.go b/plugin/storage/grpc/shared/grpc_handler.go index fd76ac7f1d3..d8843b1189f 100644 --- a/plugin/storage/grpc/shared/grpc_handler.go +++ b/plugin/storage/grpc/shared/grpc_handler.go @@ -149,7 +149,7 @@ func (s *GRPCHandler) WriteSpan(ctx context.Context, r *storage_v1.WriteSpanRequ return &storage_v1.WriteSpanResponse{}, nil } -func (s *GRPCHandler) Close(ctx context.Context, r *storage_v1.CloseWriterRequest) (*storage_v1.CloseWriterResponse, error) { +func (s *GRPCHandler) Close(context.Context, *storage_v1.CloseWriterRequest) (*storage_v1.CloseWriterResponse, error) { if closer, ok := s.impl.SpanWriter().(io.Closer); ok { if err := closer.Close(); err != nil { return nil, err @@ -179,7 +179,7 @@ func (s *GRPCHandler) GetTrace(r *storage_v1.GetTraceRequest, stream storage_v1. } // GetServices returns a list of all known services -func (s *GRPCHandler) GetServices(ctx context.Context, r *storage_v1.GetServicesRequest) (*storage_v1.GetServicesResponse, error) { +func (s *GRPCHandler) GetServices(ctx context.Context, _ *storage_v1.GetServicesRequest) (*storage_v1.GetServicesResponse, error) { services, err := s.impl.SpanReader().GetServices(ctx) if err != nil { return nil, err @@ -274,7 +274,7 @@ func (*GRPCHandler) sendSpans(spans []*model.Span, sendFn func(*storage_v1.Spans return nil } -func (s *GRPCHandler) Capabilities(ctx context.Context, request *storage_v1.CapabilitiesRequest) (*storage_v1.CapabilitiesResponse, error) { +func (s *GRPCHandler) Capabilities(context.Context, *storage_v1.CapabilitiesRequest) (*storage_v1.CapabilitiesResponse, error) { return &storage_v1.CapabilitiesResponse{ ArchiveSpanReader: s.impl.ArchiveSpanReader() != nil, ArchiveSpanWriter: s.impl.ArchiveSpanWriter() != nil, diff --git a/plugin/storage/integration/kafka_test.go b/plugin/storage/integration/kafka_test.go index 77d4cdfa79c..447373c3cd9 100644 --- a/plugin/storage/integration/kafka_test.go +++ b/plugin/storage/integration/kafka_test.go @@ -110,22 +110,22 @@ func (r *ingester) GetTrace(ctx context.Context, traceID model.TraceID) (*model. return r.traceStore.GetTrace(ctx, traceID) } -func (*ingester) GetServices(ctx context.Context) ([]string, error) { +func (*ingester) GetServices(context.Context) ([]string, error) { return nil, nil } func (*ingester) GetOperations( - ctx context.Context, - query spanstore.OperationQueryParameters, + context.Context, + spanstore.OperationQueryParameters, ) ([]spanstore.Operation, error) { return nil, nil } -func (*ingester) FindTraces(ctx context.Context, query *spanstore.TraceQueryParameters) ([]*model.Trace, error) { +func (*ingester) FindTraces(context.Context, *spanstore.TraceQueryParameters) ([]*model.Trace, error) { return nil, nil } -func (*ingester) FindTraceIDs(ctx context.Context, query *spanstore.TraceQueryParameters) ([]model.TraceID, error) { +func (*ingester) FindTraceIDs(context.Context, *spanstore.TraceQueryParameters) ([]model.TraceID, error) { return nil, nil } diff --git a/plugin/storage/kafka/factory.go b/plugin/storage/kafka/factory.go index fb27411b1e4..43ae120dbfa 100644 --- a/plugin/storage/kafka/factory.go +++ b/plugin/storage/kafka/factory.go @@ -60,7 +60,7 @@ func (f *Factory) AddFlags(flagSet *flag.FlagSet) { } // InitFromViper implements plugin.Configurable -func (f *Factory) InitFromViper(v *viper.Viper, logger *zap.Logger) { +func (f *Factory) InitFromViper(v *viper.Viper, _ *zap.Logger) { f.options.InitFromViper(v) f.configureFromOptions(f.options) } diff --git a/plugin/storage/kafka/writer.go b/plugin/storage/kafka/writer.go index 9be38926b01..dc291549bb6 100644 --- a/plugin/storage/kafka/writer.go +++ b/plugin/storage/kafka/writer.go @@ -73,7 +73,7 @@ func NewSpanWriter( } // WriteSpan writes the span to kafka. -func (w *SpanWriter) WriteSpan(ctx context.Context, span *model.Span) error { +func (w *SpanWriter) WriteSpan(_ context.Context, span *model.Span) error { spanBytes, err := w.marshaller.Marshal(span) if err != nil { w.metrics.SpansWrittenFailure.Inc(1) diff --git a/plugin/storage/memory/factory.go b/plugin/storage/memory/factory.go index efaf0ac1c23..2c9fe0b5fda 100644 --- a/plugin/storage/memory/factory.go +++ b/plugin/storage/memory/factory.go @@ -70,7 +70,7 @@ func (*Factory) AddFlags(flagSet *flag.FlagSet) { } // InitFromViper implements plugin.Configurable -func (f *Factory) InitFromViper(v *viper.Viper, logger *zap.Logger) { +func (f *Factory) InitFromViper(v *viper.Viper, _ *zap.Logger) { f.options.InitFromViper(v) } diff --git a/plugin/storage/memory/lock.go b/plugin/storage/memory/lock.go index 95f2530cf86..de5bd816f63 100644 --- a/plugin/storage/memory/lock.go +++ b/plugin/storage/memory/lock.go @@ -19,11 +19,11 @@ import "time" type lock struct{} // Acquire always returns true for memory storage because it's a single-node -func (*lock) Acquire(resource string, ttl time.Duration) (bool, error) { +func (*lock) Acquire(string /* resource */, time.Duration /* ttl */) (bool, error) { return true, nil } // Forfeit always returns true for memory storage -func (*lock) Forfeit(resource string) (bool, error) { +func (*lock) Forfeit(string /* resource */) (bool, error) { return true, nil } diff --git a/plugin/storage/memory/memory.go b/plugin/storage/memory/memory.go index 11fdd1dc074..e7c8c3fb0a0 100644 --- a/plugin/storage/memory/memory.go +++ b/plugin/storage/memory/memory.go @@ -278,7 +278,7 @@ func (st *Store) FindTraces(ctx context.Context, query *spanstore.TraceQueryPara } // FindTraceIDs is not implemented. -func (*Store) FindTraceIDs(ctx context.Context, query *spanstore.TraceQueryParameters) ([]model.TraceID, error) { +func (*Store) FindTraceIDs(context.Context, *spanstore.TraceQueryParameters) ([]model.TraceID, error) { return nil, errors.New("not implemented") } diff --git a/storage/spanstore/composite_test.go b/storage/spanstore/composite_test.go index 85aed7a98b4..b3378f1cff7 100644 --- a/storage/spanstore/composite_test.go +++ b/storage/spanstore/composite_test.go @@ -31,13 +31,13 @@ var errIWillAlwaysFail = errors.New("ErrProneWriteSpanStore will always fail") type errProneWriteSpanStore struct{} -func (*errProneWriteSpanStore) WriteSpan(ctx context.Context, span *model.Span) error { +func (*errProneWriteSpanStore) WriteSpan(context.Context, *model.Span) error { return errIWillAlwaysFail } type noopWriteSpanStore struct{} -func (*noopWriteSpanStore) WriteSpan(ctx context.Context, span *model.Span) error { +func (*noopWriteSpanStore) WriteSpan(context.Context, *model.Span) error { return nil } diff --git a/storage/spanstore/downsampling_writer_test.go b/storage/spanstore/downsampling_writer_test.go index 5087015373d..78fade542a7 100644 --- a/storage/spanstore/downsampling_writer_test.go +++ b/storage/spanstore/downsampling_writer_test.go @@ -28,7 +28,7 @@ import ( type noopWriteSpanStore struct{} -func (*noopWriteSpanStore) WriteSpan(ct context.Context, span *model.Span) error { +func (*noopWriteSpanStore) WriteSpan(context.Context, *model.Span) error { return nil } @@ -36,7 +36,7 @@ var errIWillAlwaysFail = errors.New("ErrProneWriteSpanStore will always fail") type errorWriteSpanStore struct{} -func (*errorWriteSpanStore) WriteSpan(ctx context.Context, span *model.Span) error { +func (*errorWriteSpanStore) WriteSpan(context.Context, *model.Span) error { return errIWillAlwaysFail }