Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add semver to dependencies #5590

Merged
merged 4 commits into from
Jun 15, 2024
Merged

Add semver to dependencies #5590

merged 4 commits into from
Jun 15, 2024

Conversation

danish9039
Copy link
Contributor

@danish9039 danish9039 commented Jun 12, 2024

Which problem is this PR solving?

Resolves #5582

Description of the changes

  • added semvers to dependencies

How was this change tested?

Checklist

Signed-off-by: danish siddiqui <danishsiddiqui040@gmail.com>
@danish9039 danish9039 requested a review from a team as a code owner June 12, 2024 12:45
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.19%. Comparing base (d4f02b8) to head (ea93041).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5590      +/-   ##
==========================================
- Coverage   96.20%   96.19%   -0.02%     
==========================================
  Files         327      327              
  Lines       16014    16014              
==========================================
- Hits        15406    15404       -2     
- Misses        432      433       +1     
- Partials      176      177       +1     
Flag Coverage Δ
badger_v1 8.05% <ø> (ø)
badger_v2 1.93% <ø> (ø)
cassandra-3.x-v1 16.45% <ø> (ø)
cassandra-3.x-v2 1.85% <ø> (ø)
cassandra-4.x-v1 16.45% <ø> (ø)
cassandra-4.x-v2 1.85% <ø> (ø)
elasticsearch-7.x-v1 18.89% <ø> (+0.01%) ⬆️
elasticsearch-8.x-v1 19.09% <ø> (+0.01%) ⬆️
elasticsearch-8.x-v2 19.07% <ø> (ø)
grpc_v1 9.47% <ø> (ø)
grpc_v2 ?
kafka 9.77% <ø> (ø)
opensearch-1.x-v1 18.93% <ø> (ø)
opensearch-2.x-v1 18.93% <ø> (-0.02%) ⬇️
opensearch-2.x-v2 18.93% <ø> (-0.02%) ⬇️
unittests 94.06% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label Jun 12, 2024
.github/workflows/codeql.yml Outdated Show resolved Hide resolved
.github/workflows/codeql.yml Outdated Show resolved Hide resolved
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please address comments

@danish9039
Copy link
Contributor Author

please address comments

looking into it

Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro changed the title add semver to dependencies Add semver to dependencies Jun 15, 2024
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro enabled auto-merge (squash) June 15, 2024 02:52
@yurishkuro yurishkuro merged commit 70fc1f7 into jaegertracing:main Jun 15, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:ci Change related to continuous integration / testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add semver to dependencies
2 participants