New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add log to avoid warning for ineffectual assignment #584

Merged
merged 5 commits into from Dec 8, 2017

Conversation

Projects
None yet
4 participants
@isaachier
Contributor

isaachier commented Dec 5, 2017

Signed-off-by: Isaac Hier ihier@uber.com

Add log to avoid warning for ineffectual assignment
Signed-off-by: Isaac Hier <ihier@uber.com>
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Dec 5, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 5ddffed on isaachier:hotrod-ctx-assign-fix into 1e10ffc on jaegertracing:master.

coveralls commented Dec 5, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 5ddffed on isaachier:hotrod-ctx-assign-fix into 1e10ffc on jaegertracing:master.

Log drivers
Signed-off-by: Isaac Hier <ihier@uber.com>

isaachier added some commits Dec 5, 2017

Use zap array field
Signed-off-by: Isaac Hier <ihier@uber.com>
Remove unused import
Signed-off-by: Isaac Hier <ihier@uber.com>
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Dec 5, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 99ab73c on isaachier:hotrod-ctx-assign-fix into 1e10ffc on jaegertracing:master.

coveralls commented Dec 5, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 99ab73c on isaachier:hotrod-ctx-assign-fix into 1e10ffc on jaegertracing:master.

@wafflebot wafflebot bot added the review label Dec 7, 2017

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Dec 7, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 5c1ac80 on isaachier:hotrod-ctx-assign-fix into 3fddfb2 on jaegertracing:master.

coveralls commented Dec 7, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 5c1ac80 on isaachier:hotrod-ctx-assign-fix into 3fddfb2 on jaegertracing:master.

@yurishkuro yurishkuro merged commit 6cb46f5 into jaegertracing:master Dec 8, 2017

3 checks passed

DCO All commits have a DCO sign-off from the author
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details

@wafflebot wafflebot bot removed the review label Dec 8, 2017

@isaachier isaachier deleted the isaachier:hotrod-ctx-assign-fix branch Jan 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment