New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add standalone Dockerfile that runs agent, collector, and query #69

Merged
merged 24 commits into from Apr 8, 2017

Conversation

Projects
None yet
6 participants
@badiib
Contributor

badiib commented Mar 29, 2017

  • UI is not part of this docker instance
Show outdated Hide outdated cmd/standalone/Dockerfile Outdated
Show outdated Hide outdated cmd/standalone/Dockerfile Outdated
@yurishkuro

This comment has been minimized.

Show comment
Hide comment
@yurishkuro

yurishkuro Mar 29, 2017

Member

let's keep this open and define a proper task (#70) with all requirements.

Member

yurishkuro commented Mar 29, 2017

let's keep this open and define a proper task (#70) with all requirements.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Mar 29, 2017

Coverage Status

Coverage remained the same at 98.365% when pulling f783410 on rooz/dockerize-single-application into 00435d3 on master.

coveralls commented Mar 29, 2017

Coverage Status

Coverage remained the same at 98.365% when pulling f783410 on rooz/dockerize-single-application into 00435d3 on master.

Show outdated Hide outdated cmd/standalone/Dockerfile Outdated
Show outdated Hide outdated cmd/standalone/Dockerfile Outdated
Show outdated Hide outdated cmd/standalone/Dockerfile Outdated
@yurishkuro

This comment has been minimized.

Show comment
Hide comment
@yurishkuro

yurishkuro Apr 6, 2017

Member

I assume this also needs a travis change

Member

yurishkuro commented Apr 6, 2017

I assume this also needs a travis change

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Apr 6, 2017

Coverage Status

Coverage remained the same at 98.31% when pulling 0f4ac46 on rooz/dockerize-single-application into 2b99d9d on master.

coveralls commented Apr 6, 2017

Coverage Status

Coverage remained the same at 98.31% when pulling 0f4ac46 on rooz/dockerize-single-application into 2b99d9d on master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Apr 6, 2017

Coverage Status

Coverage remained the same at 98.31% when pulling b5141eb on rooz/dockerize-single-application into 2b99d9d on master.

coveralls commented Apr 6, 2017

Coverage Status

Coverage remained the same at 98.31% when pulling b5141eb on rooz/dockerize-single-application into 2b99d9d on master.

Show outdated Hide outdated cmd/standalone/Dockerfile Outdated
Show outdated Hide outdated .travis.yml Outdated
Show outdated Hide outdated cmd/standalone/Dockerfile Outdated
Show outdated Hide outdated cmd/standalone/Dockerfile Outdated
@@ -0,0 +1,10 @@
FROM golang:1.7

This comment has been minimized.

@yurishkuro

yurishkuro Apr 6, 2017

Member

there may be a lighter base image than the one with full go tool chain (add TODO)

@yurishkuro

yurishkuro Apr 6, 2017

Member

there may be a lighter base image than the one with full go tool chain (add TODO)

This comment has been minimized.

@vprithvi

vprithvi Apr 6, 2017

Member

The alpine image should work because we don't depend on git, etc
We can simply use golang:1.7-alpine

@vprithvi

vprithvi Apr 6, 2017

Member

The alpine image should work because we don't depend on git, etc
We can simply use golang:1.7-alpine

@black-adder black-adder changed the title from Add standalone Dockerfile that runs agent, collector, and query to [WIP] Add standalone Dockerfile that runs agent, collector, and query Apr 6, 2017

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Apr 6, 2017

Coverage Status

Coverage increased (+0.07%) to 98.378% when pulling 6df44b7 on rooz/dockerize-single-application into 2b99d9d on master.

coveralls commented Apr 6, 2017

Coverage Status

Coverage increased (+0.07%) to 98.378% when pulling 6df44b7 on rooz/dockerize-single-application into 2b99d9d on master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Apr 7, 2017

Coverage Status

Coverage increased (+0.07%) to 98.378% when pulling 1740b79 on rooz/dockerize-single-application into 2b99d9d on master.

coveralls commented Apr 7, 2017

Coverage Status

Coverage increased (+0.07%) to 98.378% when pulling 1740b79 on rooz/dockerize-single-application into 2b99d9d on master.

black-adder added some commits Apr 7, 2017

@black-adder black-adder changed the title from [WIP] Add standalone Dockerfile that runs agent, collector, and query to Add standalone Dockerfile that runs agent, collector, and query Apr 7, 2017

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Apr 7, 2017

Coverage Status

Coverage decreased (-0.1%) to 98.227% when pulling 2bb5afc on rooz/dockerize-single-application into 527cde4 on master.

coveralls commented Apr 7, 2017

Coverage Status

Coverage decreased (-0.1%) to 98.227% when pulling 2bb5afc on rooz/dockerize-single-application into 527cde4 on master.

black-adder added some commits Apr 7, 2017

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Apr 7, 2017

Coverage Status

Coverage decreased (-0.1%) to 98.227% when pulling b4bfb0e on rooz/dockerize-single-application into 527cde4 on master.

coveralls commented Apr 7, 2017

Coverage Status

Coverage decreased (-0.1%) to 98.227% when pulling b4bfb0e on rooz/dockerize-single-application into 527cde4 on master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Apr 7, 2017

Coverage Status

Coverage increased (+0.0007%) to 98.339% when pulling b4bfb0e on rooz/dockerize-single-application into 527cde4 on master.

coveralls commented Apr 7, 2017

Coverage Status

Coverage increased (+0.0007%) to 98.339% when pulling b4bfb0e on rooz/dockerize-single-application into 527cde4 on master.

Show outdated Hide outdated .travis.yml Outdated
Show outdated Hide outdated .travis.yml Outdated
Show outdated Hide outdated .travis.yml Outdated
install:
- nvm version
- node -v

This comment has been minimized.

@yurishkuro

yurishkuro Apr 7, 2017

Member

we need a minimum version, I would suggest nvm use 4 somewhere in this file - @saminzadeh thoughts?

@yurishkuro

yurishkuro Apr 7, 2017

Member

we need a minimum version, I would suggest nvm use 4 somewhere in this file - @saminzadeh thoughts?

Show outdated Hide outdated .travis.yml Outdated
Show outdated Hide outdated .travis.yml Outdated
Show outdated Hide outdated Makefile Outdated
Show outdated Hide outdated .travis.yml Outdated
Show outdated Hide outdated cmd/standalone/Dockerfile Outdated

black-adder added some commits Apr 7, 2017

Show outdated Hide outdated Makefile Outdated
@yurishkuro

This comment has been minimized.

Show comment
Hide comment
@yurishkuro

yurishkuro Apr 7, 2017

Member

don't forget to move back to after_script:

Member

yurishkuro commented Apr 7, 2017

don't forget to move back to after_script:

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Apr 8, 2017

Coverage Status

Coverage decreased (-0.07%) to 98.272% when pulling c01a660 on rooz/dockerize-single-application into 527cde4 on master.

coveralls commented Apr 8, 2017

Coverage Status

Coverage decreased (-0.07%) to 98.272% when pulling c01a660 on rooz/dockerize-single-application into 527cde4 on master.

@black-adder black-adder merged commit 0ab671e into master Apr 8, 2017

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.1%) to 98.384%
Details
license/cla Contributor License Agreement is signed.
Details

@black-adder black-adder deleted the rooz/dockerize-single-application branch Apr 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment