Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxify http request in article when jarr is served in https #45

Closed
jaesivsm opened this issue Jul 22, 2016 · 1 comment
Closed

proxify http request in article when jarr is served in https #45

jaesivsm opened this issue Jul 22, 2016 · 1 comment
Milestone

Comments

@jaesivsm
Copy link
Owner

@jaesivsm jaesivsm commented Jul 22, 2016

When articles contain images served in http and jarr is served in https, the browser will block the content.

The easiest solution is to proxify access to those images.

@jaesivsm

This comment has been minimized.

Copy link
Owner Author

@jaesivsm jaesivsm commented Jul 22, 2016

Ok, I wrote this completely misunderstanding how mixed-content are handled. Visibly, mixed-content is tolerated through <img src=[...]> but not <img srcset=[...]>. So the simple fix is to remove the srcset when it can't be displayed (jarr is served over https and src is set so the image will still be valid).

@jaesivsm jaesivsm added minor and removed new feature labels Jul 22, 2016
@jaesivsm jaesivsm added this to the 1.0.2 - Madrid milestone Jul 24, 2016
@jaesivsm jaesivsm closed this in f77504d Jul 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.