Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

undefined: commandeer.ImplementsRunner #6

Closed
chrispickard opened this issue Mar 1, 2019 · 4 comments
Closed

undefined: commandeer.ImplementsRunner #6

chrispickard opened this issue Mar 1, 2019 · 4 comments

Comments

@chrispickard
Copy link

chrispickard commented Mar 1, 2019

I tried to run myapp-cobrafy which gives undefined: commandeer.ImplementsRunner at line 31 in cobrafy/cobra.go

full error

~/dev/golang/src/github.com/jaffee/commandeer/examples/myapp/cmd/myapp-cobrafy master
» go run main.go
# github.com/jaffee/commandeer/cobrafy
../../../../cobrafy/cobra.go:31:5: undefined: commandeer.ImplementsRunner
@jaffee
Copy link
Owner

jaffee commented Mar 1, 2019

that's odd... can you make sure you have the latest version of the master branch?

I am not able to reproduce this issue and ImplementsRunner is clearly defined in com.go

@chrispickard
Copy link
Author

I pulled and I'm up to date with master. The latest commit I have is 719d29f8107ee2337fef4e1680770ea58780ff32 which is the same one github shows, and I still don't have that function. I couldn't find it with the github search either (or just by looking at com.go on github)

@chrispickard
Copy link
Author

as far as I can tell it looks like it was removed in #4

@jaffee
Copy link
Owner

jaffee commented Mar 1, 2019

ah ha! I didn't have the latest master 🤦‍♂️

Thank you! I pushed a fix to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants