Fix two LP Mk3 device setup for 128 grid - to jaggednz/midigrid fork #3
Conversation
Without this change log is: finding device: 2 with name Launchpad Mini MK3 1 finding device: 3 with name Launchpad Mini MK3 2 Dev3 FD launchpad_minimk3 finding device: 4 with name Launchpad Mini MK3 1 2 finding device: 5 with name Launchpad Mini MK3 2 2 Dev5 FD launchpad_minimk3 mounted_devices 5 launchpad_minimk3 3 launchpad_minimk3 With this change log is: finding device: 2 with name Launchpad Mini MK3 1 finding device: 3 with name Launchpad Mini MK3 2 Dev3 FD launchpad_minimk3 finding device: 4 with name Launchpad Mini MK3 1 2 finding device: 5 with name Launchpad Mini MK3 2 2 Dev5 FD launchpad_minimk3_128 mounted_devices 5 launchpad_minimk3_128 3 launchpad_minimk3 Also tested this change with LP Mk2 and APC mini. It did not effect the loading behaviour of these devices.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Fix two LP Mk3 device setup for 128 grid.
Without this change log is:
With this change log is:
Also tested this change with LP Mk2 and APC mini. It did not effect the loading behaviour of these devices.
Added comments to code explaining LP MIDI device names.