Fix rgb 128 #9
Merged
Fix rgb 128 #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, Novation are super consistent :| Agree that mk2 should have its own config but I can sort sort that later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are fixes currently required to get the launchpad mini mk3 in "128 mode" running.
Note that I also fixed the auxcols for the mk2 RGB launchpad. I can't test this but I followed the programmers reference
Maybe you should group launchpad mk2 and Launchpad X/Mini mk3 separately since it seems like their specification is different.
Thanks for the update! Looks like everything else is working :)