Report errors when loading helpers

Fixes hapijs#73.
jagoda · Mar 31, 2016 · 81091f5 · 81091f5
1 parent 43155a6
commit 81091f5
Show file tree

Hide file tree

Showing 4 changed files with 41 additions and 1 deletion.
diff --git a/lib/manager.js b/lib/manager.js
@@ -257,7 +257,9 @@ internals.Manager.prototype._loadHelpers = function (engine) {
                         engine.module.registerHelper(name, helper);
                     }
                 }
-                catch (err) { }
+                catch (err) {
+                    console.log('WARNING: vision failed to load helper \'%s\': %s', file, err.message);
+                }
             }
         });
     });

diff --git a/test/manager.js b/test/manager.js
@@ -10,6 +10,7 @@ const Jade = require('jade');
 const Lab = require('lab');
 const Vision = require('..');
 const Manager = require('../lib/manager');
+const Util = require('util');
 
 
 // Declare internals
@@ -1773,6 +1774,39 @@ describe('Manager', () => {
             });
         });
 
+        it('prints a warning message when helpers fail to load', (done) => {
+
+            const buffer = [];
+            const oldLog = console.log;
+
+            console.log = function () {
+
+                const message = Util.format.apply(Util, arguments);
+
+                buffer.push(message);
+            };
+
+            try {
+                new Manager({
+                    engines: { html: { module: Handlebars.create() } },
+                    relativeTo: 'test/templates',
+                    path: 'valid',
+                    helpersPath: 'invalid/helpers'
+                });
+            }
+            finally {
+                console.log = oldLog;
+            }
+
+            const output = buffer.join('\n');
+
+            expect(output).to.match(/^WARNING:/);
+            expect(output).to.contain('vision failed to load helper');
+            expect(output).to.contain('invalid/helpers/bad1.module');
+            expect(output).to.contain('invalid/helpers/bad2.module');
+            done();
+        });
+
         it('reuses cached compilation', (done) => {
 
             let gen = 0;

diff --git a/test/templates/invalid/helpers/bad1.module b/test/templates/invalid/helpers/bad1.module
@@ -0,0 +1 @@
+this is an invalid helper
diff --git a/test/templates/invalid/helpers/bad2.module b/test/templates/invalid/helpers/bad2.module
@@ -0,0 +1,3 @@
+module.exports = funtcion (context) {
+    return context;
+};