Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upElm 0.18 Support #36
Comments
jahewson
added
the
enhancement
label
Feb 15, 2017
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
TimPerry
commented
Apr 24, 2017
|
+1 and update on this? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jahewson
Apr 24, 2017
Owner
Yep, after much delay I'm working on this now. Having to rewrite the decoder codegen as it relies heavily on a custom infix operator. Should have something this week, fingers crossed.
|
Yep, after much delay I'm working on this now. Having to rewrite the decoder codegen as it relies heavily on a custom |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Bellk17
commented
May 2, 2017
|
@jahweson my fork is 0.18 compliant, though using a different |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
TimPerry
commented
May 3, 2017
|
@Bellk17 Any change you could do a PR? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Bellk17
May 4, 2017
@TimPerry I'll look into it tonight. I've made a number of changes on my fork to utilize this on a build server, so need to make sure no breaking changes.
Bellk17
commented
May 4, 2017
|
@TimPerry I'll look into it tonight. I've made a number of changes on my fork to utilize this on a build server, so need to make sure no breaking changes. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
maticzav
commented
Aug 26, 2017
|
Any progress with this? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Gregoirevda
commented
Aug 27, 2017
|
+1 any update? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
nicu-chiciuc
Oct 11, 2017
It seems like the last commit was made a year ago. Is the project abandoned?
nicu-chiciuc
commented
Oct 11, 2017
|
It seems like the last commit was made a year ago. Is the project abandoned? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
nickdima
commented
Nov 16, 2017
|
This one seems more active: https://github.com/jamesmacaulay/elm-graphql |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
dillonkearns
Jan 6, 2018
Hello @jahewson, I recently published a library called Graphqelm that I think achieves similar goals to this one, and has support for Elm 0.18. It actually takes the approach of generating functions for the entire schema which guarantee that you only build valid, type-safe queries. I recommend that anybody on this thread check it out! Here's a live Ellie demo.
I believe that with graphqelm, the technique of generating code for specific queries is obsolete (though perhaps you might disagree, or there is a use case I am missing). I'd be curious to hear everyone's thoughts on this.
dillonkearns
commented
Jan 6, 2018
|
Hello @jahewson, I recently published a library called Graphqelm that I think achieves similar goals to this one, and has support for Elm 0.18. It actually takes the approach of generating functions for the entire schema which guarantee that you only build valid, type-safe queries. I recommend that anybody on this thread check it out! Here's a live Ellie demo. I believe that with |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Gregoirevda
commented
Jan 6, 2018
|
Will check that out! |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
daniel-kun
Jan 6, 2018
IMHO it sounds reasonable to generate the whole scheme (except when it might be gigantic). Will definitely try it out when I want to access a GraphQL API from Elm again. Thanks!
daniel-kun
commented
Jan 6, 2018
|
IMHO it sounds reasonable to generate the whole scheme (except when it might be gigantic). Will definitely try it out when I want to access a GraphQL API from Elm again. Thanks! |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
dillonkearns
Jan 6, 2018
@daniel-kun I agree. I've been using the Github API as an example. It generates a total of 308 files, but it doesn't seem to be an issue. It's in the examples/src/Github.elm file in the repo.
dillonkearns
commented
Jan 6, 2018
|
@daniel-kun I agree. I've been using the Github API as an example. It generates a total of 308 files, but it doesn't seem to be an issue. It's in the examples/src/Github.elm file in the repo. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
dillonkearns
Jan 6, 2018
And another nice thing is that it gives you a clear separation between the generated code and your code, so you can freely edit your code without worrying about breaking something that was auto-generated. So having lots of files isn't necessarily an issue unless it slows down compile times or increases bundle sizes too much. That hasn't been an issue with the Github example, and Elm 0.19 is going to improve dead code elimination and some compile performance issues I believe.
dillonkearns
commented
Jan 6, 2018
|
And another nice thing is that it gives you a clear separation between the generated code and your code, so you can freely edit your code without worrying about breaking something that was auto-generated. So having lots of files isn't necessarily an issue unless it slows down compile times or increases bundle sizes too much. That hasn't been an issue with the Github example, and Elm 0.19 is going to improve dead code elimination and some compile performance issues I believe. |
carleryd commentedJan 9, 2017
https://github.com/elm-lang/elm-platform/blob/master/upgrade-docs/0.18.md