Sandbox SVG elements to avoid ID conflicts #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arrows in the sequence diagrams use SVG-markers for the messqge arrows, and since the extension has to have to the DOM both the light and the dark diagrams and hide the less relevant one, it used to produce conflicts which confuse the rendering engine into using the hidden light arrows for the dark diagram. Sandboxing the images within img tags resolves the issue. Refs: jaime-olivares/yuml-diagram#10 Fixes: jaime-olivares#50
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arrows in the sequence diagrams use SVG-markers for the message arrows, and since the extension has to have to the DOM both the light and the dark diagrams and hide the less relevant one, it used to produce conflicts which confuse the rendering engine into using the hidden light arrows for the dark diagram.
Sandboxing the images within img tags resolves the issue.
Refs: jaime-olivares/yuml-diagram#10
Fixes: #50