Skip to content
Commits on Aug 24, 2012
  1. Add exception handling to rake guides:validate

    If the validation of a guide encounters an exception, inform about it
    and continue with the loop to validate the rest.
  2. Fix rake guides:validate

    This rake task was looking for the output folder in the wrong place.
  3. Revert "Fix rake guides:validate task as it should be run from the gu…

    …ides directory; add exception handling"
    This kind of changes should go on a pull request instead.
    This reverts commit ecae2f0.
Commits on Aug 23, 2012
  1. @murtra
  2. @murtra

    Fix HTML validation errors

    murtra committed
  3. Fix rake guides:validate task as it should be run from the guides dir…

    …ectory; add exception handling
Commits on Aug 22, 2012
  1. @vijaydev
  2. @carlosantoniodasilva

    Merge pull request #7413 from siong1987/secret_token

    carlosantoniodasilva committed
    Remind user a good way to generate a secret code [ci skip]
  3. @siong1987
  4. @randomecho
Commits on Aug 21, 2012
  1. @rafaelfranca

    Merge pull request #6606 from amatsuda/ar_relation_model_method

    rafaelfranca committed
    AR::Relation#model would be a better API than AR::Relation#klass
  2. @rafaelfranca
  3. @rafaelfranca

    Merge pull request #3578 from amatsuda/remove_j_alias_for_json_escape

    rafaelfranca committed
    Remove j alias for ERB::Util.json_escape
  4. @carlosantoniodasilva

    Remove app building setup/teardown for remote ip railtie tests

    carlosantoniodasilva committed
    These tests rely on "make_basic_app", which is a faster version that
    does not need to create the whole app directory structure.
  5. @carlosantoniodasilva

    Set eager load option in "make_basic_app" for railties tests

    carlosantoniodasilva committed
    Avoid output with config option not set when running some tests.
  6. @josevalim

    Merge pull request #7225 from rails/eager_load

    josevalim committed
    Improve eager load on Rails
  7. @carlosantoniodasilva

    Merge pull request #6499 from lazylester/patch-1

    carlosantoniodasilva committed
    Clarify and correct the description for the --full option of the 
    plugin_new generator. [ci skip]
  8. @lazylester
  9. @rafaelfranca
  10. @tenderlove @josevalim

    add Rack::Lock for webrick

    tenderlove committed with josevalim
  11. @josevalim

    Deprecate config.threadsafe!

    josevalim committed
  12. @josevalim

    Get rid of config.preload_frameworks in favor of config.eager_load_na…

    josevalim committed
    The new option allows any Ruby namespace to be registered and set
    up for eager load. We are effectively exposing the structure existing
    in Rails since v3.0 for all developers in order to make their applications
    thread-safe and CoW friendly.
  13. @josevalim

    Make ActiveSupport::Autoload local

    josevalim committed
    Previously, ActiveSupport::Autoload was global and reserved
    for usage inside Rails. This pull request makes it local,
    fixes its test (they were not being run because its file
    was named wrongly) and make it part of Rails public API.
  14. @josevalim

    Remove allow_concurrency as a flag

    josevalim committed
    The flag was mainly used to add a Rack::Lock middleware to
    the stack, but the only scenario the lock is desired is in
    If you are deploying on a not-threaded server, the Rack::Lock
    does not provide any benefit since you don't have concurrent
    accesses. On the other hand, if you are on a threaded server,
    you don't want the lock, since it defeats the purpose of using
    a threaded server.
    If there is someone out there, running on a thread server
    and does want a lock, it can be added to your environment
    as easy as: `use Rack::Lock`
  15. @josevalim

    Allow users to choose when to eager_load the application or not.

    josevalim committed
    Previously, the eager load behavior was mostly coupled to
    config.cache_classes, however this was suboptimal since in
    some environments a developer may want to cache classes but
    not necessarily load them all on boot (for example, test env).
    This pull request also promotes the use of config.eager_load
    set to true by default in production. In the majority of the
    cases, this is the behavior you want since it will copy most
    of your app into memory on boot (which was also the previous
    Finally, this fix a long standing Rails bug where it was
    impossible to access a model in a rake task when Rails was
    set as thread safe.
  16. @rafaelfranca

    Merge pull request #5210 from Pliny/masteri

    rafaelfranca committed
    Fix for #5200
  17. @Pliny @rafaelfranca

    reset_counters() was crashing when there were multiple belongs_to ass…

    Pliny committed with rafaelfranca
    …ociations with the same foreign key.
    This closes #5200.
  18. @rafaelfranca
  19. @rafaelfranca

    Merge pull request #7410 from sandeepravi/default_options_helper_value

    rafaelfranca committed
    option_tags coerced to "" instead of nil
    Closes #7404
  20. @sandeepr-sourcebits
  21. @rafaelfranca

    Merge pull request #7409 from kennyj/refactor_activerecord_result

    rafaelfranca committed
    Refactor AR::Result or inherits. Because we have redundant codes about column_types.
  22. @kennyj
  23. @carlosantoniodasilva

    Merge pull request #7408 from yahonda/sqlmode_mysql

    carlosantoniodasilva committed
    Change mysql tests for strict mode disabled to work with new sql_mode default in MySQL 5.6.6-m9.
    Since this MySQL version, the sql_mode default value is `NO_ENGINE_SUBSTITUTION`.
  24. @yahonda

    Rename to test_mysql_strict_mode_disabled_dont_override_global_sql_mode

    yahonda committed
    Reason since MySQL 5.6.6-m9 the `sql_mode` default value is
    This default parameter change is out of control from Rails.
    This test verifies Rails not overriding the default `@@GLOBAL.sql_mode` value
    by checking if `@@GLOBAL.sql_mode` is the same as `@@SESSION.sql_mode`.
  25. @rafaelfranca

    Merge pull request #7406 from janko-m/documentation_fixes

    rafaelfranca committed
    Fixed some documentation mistakes
Something went wrong with that request. Please try again.