Simplify scrape_meta_data method

jaimeiniesta · Dec 1, 2012 · 2113ec2 · 2113ec2
1 parent c9dbd86
commit 2113ec2
Showing 1 changed file with 10 additions and 9 deletions.
diff --git a/lib/meta_inspector/scraper.rb b/lib/meta_inspector/scraper.rb
@@ -190,19 +190,20 @@ def scrape_meta_data
         @data.meta!.name!
         @data.meta!.property!
         parsed_document.xpath("//meta").each do |element|
-          if element.attributes["content"]
+          get_meta_name_or_property(element)
-            if element.attributes["name"]
-              @data.meta.name[element.attributes["name"].value.downcase] = element.attributes["content"].value
-            end
-
-            if element.attributes["property"]
-              @data.meta.property[element.attributes["property"].value.downcase] = element.attributes["content"].value
-            end
-          end
         end
       end
     end
 
+    # Store meta tag value, looking at meta name or meta property
+    def get_meta_name_or_property(element)
+      if element.attributes["content"]
+        type = element.attributes["name"] ? "name" : (element.attributes["property"] ? "property" : nil)
+
+        @data.meta.name[element.attributes[type].value.downcase] = element.attributes["content"].value if type
+      end
+    end
+
     def parsed_links
       @parsed_links ||= parsed_document.search("//a") \
                           .map {|link| link.attributes["href"] \