Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links with malformed hrefs throw exception #28

Closed
gabceb opened this issue Nov 17, 2012 · 2 comments
Closed

Links with malformed hrefs throw exception #28

gabceb opened this issue Nov 17, 2012 · 2 comments

Comments

@gabceb
Copy link
Contributor

gabceb commented Nov 17, 2012

Pages such as http://www.nationalgeographic.com contain links with href values that are invalid URIs.

The method absolutify_url throws URI::InvalidURIError (bad URI(is not URI?)) when trying to get the links for the page.

We should be able to catch those exceptions and don't add the link to the links array.

@gabceb
Copy link
Contributor Author

gabceb commented Nov 17, 2012

Issue #29 has the fix for this issue. I'm still getting used to Github and how to sync pull requests and issues

jaimeiniesta added a commit that referenced this issue Nov 17, 2012
@jaimeiniesta
Copy link
Owner

Thanks, closing this now that your patch is merged.

The trick on github is to include "fixes #28" in your commit message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants