Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Links with malformed hrefs throw exception #28

Closed
gabceb opened this Issue · 2 comments

2 participants

Gabriel Cebrian Jaime Iniesta
Gabriel Cebrian

Pages such as http://www.nationalgeographic.com contain links with href values that are invalid URIs.

The method absolutify_url throws URI::InvalidURIError (bad URI(is not URI?)) when trying to get the links for the page.

We should be able to catch those exceptions and don't add the link to the links array.

Gabriel Cebrian

Issue #29 has the fix for this issue. I'm still getting used to Github and how to sync pull requests and issues

Jaime Iniesta

Thanks, closing this now that your patch is merged.

The trick on github is to include "fixes #28" in your commit message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.