We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pages such as http://www.nationalgeographic.com contain links with href values that are invalid URIs.
The method absolutify_url throws URI::InvalidURIError (bad URI(is not URI?)) when trying to get the links for the page.
We should be able to catch those exceptions and don't add the link to the links array.
The text was updated successfully, but these errors were encountered:
Issue #29 has the fix for this issue. I'm still getting used to Github and how to sync pull requests and issues
Sorry, something went wrong.
Merge pull request #29 from gabceb/master
326995b
Fix for issue #28
Thanks, closing this now that your patch is merged.
The trick on github is to include "fixes #28" in your commit message.
does not raise exception when a link has a weird href value. References
fdde23f
#28
No branches or pull requests
Pages such as http://www.nationalgeographic.com contain links with href values that are invalid URIs.
The method absolutify_url throws URI::InvalidURIError (bad URI(is not URI?)) when trying to get the links for the page.
We should be able to catch those exceptions and don't add the link to the links array.
The text was updated successfully, but these errors were encountered: