Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix for issue #28 #29

merged 1 commit into from Nov 17, 2012


None yet
2 participants

gabceb commented Nov 17, 2012

Added rescue to bad uri exception when trying to encode URIs and add an error when it happens. Specs added to the commit too

@jaimeiniesta jaimeiniesta added a commit that referenced this pull request Nov 17, 2012

@jaimeiniesta jaimeiniesta Merge pull request #29 from gabceb/master
Fix for issue #28

@jaimeiniesta jaimeiniesta merged commit 326995b into jaimeiniesta:master Nov 17, 2012

1 check passed

default The Travis build passed

jaimeiniesta commented Nov 17, 2012

Looks good, merged!

I'll review some things and release a minor revision later today.



jaimeiniesta commented Nov 17, 2012

Thanks @gabceb -- I have release 1.10.2 which includes your fix, and a minor change from me.

I still need to think of refactoring this to organize it better -- I feel there are mixed responsibilities, and that absolutify_url shouldn't be responsible of verifying the validity of the URLs.

But for now it works and it fixes a real issue, so there it goes.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment