Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Partial Dearrangements #1403

Merged
merged 3 commits into from May 28, 2019

Conversation

singh-shreya6
Copy link
Collaborator

Fixes #1399

Checklist:

  • 4 space indentation.
  • Coding conventions are followed.
  • Input is taken dynamically.
  • Sample Input / Output is added at the end of file.
  • Logic Documentation (Comments).
  • File names are correct.

Changes proposed in this pull request:

  • Added Partial Dearrangements Implementation

Languages Used:

  • C
  • C++
  • Java
  • Python
  • Go

Files Added:

  • Partial_Dearrangements.c
  • Partial_Dearrangements.cpp
  • Partial_Dearrangements.go
  • Partial_Dearrangements.java
  • Partial_Dearrangements.py

Copy link
Contributor

@manbirmarwah manbirmarwah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few changes...

return -1;
}
// We create a pascal triangle.
int Pascal[r+1];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add space around +.

int number;
cin >> number;
int k;
cin >> k;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to add space around << and >> in cout and cin statements.


var mod int = 1000000007

func nCr(n int, r int, mod int) int{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add space before {.

@singh-shreya6
Copy link
Collaborator Author

Please review @marwahmanbir

Copy link
Collaborator

@MastersAbh MastersAbh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. You can have a look @rishabhgarg25699

Copy link
Contributor

@rishabhgarg25699 rishabhgarg25699 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@singh-shreya6 Approved .

@rishabhgarg25699 rishabhgarg25699 merged commit ac1ae2a into jainaman224:master May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Partial Dearrangements in C, C++, Go, Java, Python
4 participants