Initial commit - minimal set of classes from MP Config. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jansupol
reviewed
Oct 18, 2021
Emily-Jiang
reviewed
Oct 19, 2021
Emily-Jiang
reviewed
Oct 19, 2021
Emily-Jiang
reviewed
Oct 19, 2021
Emily-Jiang
reviewed
Oct 19, 2021
Emily-Jiang
reviewed
Oct 19, 2021
Emily-Jiang
reviewed
Oct 19, 2021
Emily-Jiang
reviewed
Oct 19, 2021
otaviojava
reviewed
Oct 19, 2021
rdebusscher
reviewed
Oct 19, 2021
api/src/main/java/jakarta/config/spi/ConfigProviderResolver.java
Outdated
Show resolved
Hide resolved
radcortez
reviewed
Oct 19, 2021
radcortez
reviewed
Oct 19, 2021
|
I had a quick look. Not sure if we want to do some of the changes or just push it as is and then provide separate PRs for some ideas. |
|
Is there a list of MP Config classes or methods that were removed and are TBD? |
Not that I'm aware, but @tomas-langer might be able to provide one. |
ljnelson
reviewed
Oct 19, 2021
struberg
requested changes
Oct 21, 2021
Co-authored-by: Emily Jiang <emijiang6@googlemail.com>
A lot of methods on |
dmlloyd
approved these changes
Oct 21, 2021
radcortez
approved these changes
Nov 2, 2021
Emily-Jiang
reviewed
Nov 2, 2021
|
@tomas-langer I added one small correction to be consistence. With that, I think I am ok with this PR. |
Co-authored-by: Emily Jiang <emijiang6@googlemail.com>
pzygielo
reviewed
Nov 2, 2021
joakime
reviewed
Nov 2, 2021
joakime
requested changes
Nov 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial commit.
Contains most classes from MP. Some methods were removed, so we can update them as agreed on meetings/mailing lists.
The spec folder is almost clean and uses template from Jakarta.
The tck folder is clean (just created two packages for programmatic TCK and inject TCK).
If you run the build, documentation is generated (both html and pdf) in target directory of the spec module.