Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jakarta RESTful Web Services 3.1 #430

Merged
merged 7 commits into from Apr 6, 2022

Conversation

spericas
Copy link
Contributor

@spericas spericas commented Nov 9, 2021

Signed-off-by: Santiago Pericasgeertsen santiago.pericasgeertsen@oracle.com

Specification PR template

When creating a specification project release review, create PRs with the content defined as follows.

Include the following in the PR:

Note: If any item does not apply, check it and mark N/A below it.

Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
@netlify
Copy link

netlify bot commented Nov 9, 2021

✔️ Deploy Preview for jakartaee-specifications ready!

🔨 Explore the source changes: 70f9bae

🔍 Inspect the deploy log: https://app.netlify.com/sites/jakartaee-specifications/deploys/621e30d61a9b3e0007c3c1f5

😎 Browse the preview: https://deploy-preview-430--jakartaee-specifications.netlify.app/specifications/restful-ws/3.1/jakarta-restful-ws-spec-3.1

@ivargrimstad ivargrimstad self-assigned this Nov 9, 2021
Copy link
Member

@ivargrimstad ivargrimstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment about the plan review ballot results

restful-ws/3.1/_index.md Outdated Show resolved Hide resolved
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
@ivargrimstad ivargrimstad added the release review Use this label on PRs that are filed for release review label Nov 16, 2021
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
@ivargrimstad
Copy link
Member

ivargrimstad commented Nov 23, 2021

Spec Review Checklist

  1. Spec PR
  1. _index.md
  1. javadocs
  • Footer contains Eclipse copyright and link to license
  • ESFL license is included, usually as doc-files/speclicense.html
  • no META-INF directory in PR
  • javadocs-jar artifact matches apidocs (optional for this release)
  1. Spec PDF
  • Correct spec title
  • Version number of the form x.y, not x.y.z
  • Correct Eclipse copyright line
  • No DRAFT or SNAPSHOT
  • Correct Logo
  1. Spec HTML
  • Same as PDF
  1. TCK zip file
  • README file (optional for this release)
  • EFTL license file, preferably named LICENSE.md
  • User's Guide (or equivalent documentation)
  • How to test the Compatible Implementation(s) listed in _index.md above with the TCK (may be in UG)
  1. TCK User's Guide (or equivalent documentation)
  • Software requirements listed
  • Installation and configuration described
  • How to run tests
  • Where to file challenges
  1. Compatibility certification request
  • Request follows template
  • SHA-256 fingerprint matches staged TCK zip file
  • Request issue has certification label.
  1. TCK results summary
  • Page is hosted by Compatible Implementation project
  • Includes all information from certification request
  • Summary includes number of tests passed, failed, errors
  • SHA-256 fingerprint matches staged TCK zip file on cert request
  1. If a Release Review is required, the specification project team contacts the EMO to initiate the review by sending an email to emo@eclipse.org.
    (A Release Review is not required if the current release is a Service Release based on a previously successful Major or Minor
    release as indicated by a release record on the project's Releases page, e.g., the Jakarta Servlet releases page.)

  2. Update Jakarta EE API jar

  • Update the Jakarta EE API jar by submitting a PR to the jakartaee-api project that updates the version number of your API jar file.

@spericas
Copy link
Contributor Author

spericas commented Dec 8, 2021

@ivargrimstad Should I be going over the latest checklist you pasted or is that for you?

@ivargrimstad
Copy link
Member

@ivargrimstad Should I be going over the latest checklist you pasted or is that for you?

Did I scare you with this long list? :)
Don't worry, it's for me. You only have to tick the boxes in the first list of the PR you created...

starksm64 added a commit to starksm64/specifications that referenced this pull request Dec 20, 2021
Add minutes for November 9 platform call
@edbratt
Copy link
Contributor

edbratt commented Jan 7, 2022

@ivargrimstad could you have a look and try to determine why this deploy preview has failed? (Servlet PR deploy preview has also failed.)

@ivargrimstad
Copy link
Member

@ivargrimstad could you have a look and try to determine why this deploy preview has failed? (Servlet PR deploy preview has also failed.)

It looks like the API for project metadata was down when the last commit was made. Should be alright again when a change is made so the build is initiated again.

@ivargrimstad
Copy link
Member

@spericas Any predictions when you may go forward with this PR?

@spericas
Copy link
Contributor Author

spericas commented Feb 9, 2022

@ivargrimstad We have just a couple of PR's related to TCK's almost ready. I'd say no later than next week.

…ease.

Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
@spericas
Copy link
Contributor Author

spericas commented Feb 28, 2022

@ivargrimstad Pushed update of spec and apidocs for 3.1. Also latest jars are in staging and so is Jersey's milestone release that passes the TCKs.

Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
@ivargrimstad
Copy link
Member

ivargrimstad commented Mar 1, 2022

The copyright footer in the Javadoc should be "Copyright © 2018, 2022 Eclipse Foundation."
Currently, it says "...2018, 2020..."

The same goes for the spec doc, which is currently "...2018, 2021..."

Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
@spericas
Copy link
Contributor Author

spericas commented Mar 1, 2022

The copyright footer in the Javadoc should be "Copyright © 2018, 2022 Eclipse Foundation." Currently, it says "...2018, 2020..."

The same goes for the spec doc, which is currently "...2018, 2021..."

Done.

@spericas
Copy link
Contributor Author

spericas commented Mar 2, 2022

@ivargrimstad Should I go ahead and merge it now?

@starksm64
Copy link
Contributor

@spericas No, Ivar will merge this after the spec committee completes the final ballot.

@ivargrimstad
Copy link
Member

@spericas The items of the checklist in the PR, the one on the top, not the longer Review checklist I am using, need to be done.

Currently, what's missing are the process steps for a release review, the TCK and a certification request.

@ivargrimstad ivargrimstad added ballot Delivered to the Specification Committee for ballot and removed ballot Delivered to the Specification Committee for ballot labels Mar 13, 2022
@ivargrimstad ivargrimstad added the ballot Delivered to the Specification Committee for ballot label Mar 23, 2022
@ivargrimstad ivargrimstad added approved The ballot was approved by the Specification Committee and removed ballot Delivered to the Specification Committee for ballot labels Apr 6, 2022
@ivargrimstad
Copy link
Member

ivargrimstad commented Apr 6, 2022

  • On ballot completion, the specification committee mentor:
  • adds this final checklist to the main PR.
  • adds the approved label to the PRs, and sends out the Ballot Summary per this template to the public Jakarta EE Specification Committee email list
  • calculates the staged EFTL TCK signature and promotes it to the committee download area
    using the https://ci.eclipse.org/jakartaee-spec-committee/job/promote-release/ job. Manually editing the jenkins Build Information will help identify the build (ie. Mail 2.0 or CDI 3.0).
  • merges the specification (and apidocs) PRs, ensuring the "date:" field in the _index.md file has an appropriate value to allow publishing.
  • updates the specification page with the ballot results. This is normally done via a separate PR that should be reviewed, approved, and merged.
  • notifies the EMO of the ballot results by email to emo@eclipse-foundation.org. Just forward the ballot summary note sent earlier to the public Spec Committee email list.
  • creates an issue in the specification project that includes the following checklist for the specification project team:
    Finalize the Jakarta RESTful Web Services 3.1 Release rest#1108

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved The ballot was approved by the Specification Committee release review Use this label on PRs that are filed for release review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants