Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jakarta Annotations 2.1 #437

Merged
merged 3 commits into from Feb 9, 2022
Merged

Conversation

m0mus
Copy link
Contributor

@m0mus m0mus commented Dec 1, 2021

Signed-off-by: Dmitry Kornilov dmitry.kornilov@oracle.com

Specification PR template

When creating a specification project release review, create PRs with the content defined as follows.

Include the following in the PR:

Note: If any item does not apply, check it and mark N/A below it.

Signed-off-by: Dmitry Kornilov <dmitry.kornilov@oracle.com>
@m0mus m0mus added the release review Use this label on PRs that are filed for release review label Dec 1, 2021
@netlify
Copy link

netlify bot commented Dec 1, 2021

✔️ Deploy Preview for jakartaee-specifications ready!

🔨 Explore the source changes: ef6b448

🔍 Inspect the deploy log: https://app.netlify.com/sites/jakartaee-specifications/deploys/61f7b7d642a3130007ae884f

😎 Browse the preview: https://deploy-preview-437--jakartaee-specifications.netlify.app

@m0mus m0mus marked this pull request as draft December 1, 2021 15:07
@ivargrimstad ivargrimstad self-assigned this Dec 15, 2021
@ivargrimstad
Copy link
Member

ivargrimstad commented Dec 15, 2021

Spec Review Checklist

  1. Spec PR
  1. _index.md
  1. javadocs
  • Footer contains Eclipse copyright and link to license
  • ESFL license is included, usually as doc-files/speclicense.html
  • no META-INF directory in PR
  • javadocs-jar artifact matches apidocs (optional for this release)
  1. Spec PDF
  • Correct spec title
  • Version number of the form x.y, not x.y.z
  • Correct Eclipse copyright line
  • No DRAFT or SNAPSHOT
  • Correct Logo
  1. Spec HTML
  • Same as PDF
  1. TCK zip file
  • README file (optional for this release) - N/A
  • EFTL license file, preferably named LICENSE.md
  • User's Guide (or equivalent documentation)
  • How to test the Compatible Implementation(s) listed in _index.md above with the TCK (may be in UG)
  1. TCK User's Guide (or equivalent documentation)
  • Software requirements listed
  • Installation and configuration described
  • How to run tests
  • Where to file challenges
  1. Compatibility certification request
  • Request follows template
  • SHA-256 fingerprint matches staged TCK zip file
  • Request issue has certification label.
  1. TCK results summary
  • Page is hosted by Compatible Implementation project
  • Includes all information from certification request
  • Summary includes number of tests passed, failed, errors
  • SHA-256 fingerprint matches staged TCK zip file on cert request
  1. If a Release Review is required, the specification project team contacts the EMO to initiate the review by sending an email to emo@eclipse.org.
    (A Release Review is not required if the current release is a Service Release based on a previously successful Major or Minor
    release as indicated by a release record on the project's Releases page, e.g., the Jakarta Servlet releases page.)

  2. Update Jakarta EE API jar

  • Update the Jakarta EE API jar by submitting a PR to the jakartaee-api project that updates the version number of your API jar file.

starksm64 added a commit to starksm64/specifications that referenced this pull request Dec 20, 2021
Add minutes from Nov 16 platform call
@m0mus m0mus marked this pull request as ready for review January 6, 2022 12:10
@m0mus
Copy link
Contributor Author

m0mus commented Jan 6, 2022

I am opening this PR for review. One note, there is no compatible implementation for Jakarta Annotations. So, I am leaving the compatible implementation check box unchecked.

@ivargrimstad
Copy link
Member

I am opening this PR for review. One note, there is no compatible implementation for Jakarta Annotations. So, I am leaving the compatible implementation check box unchecked.

So, in order for the ballot to start we will need to find someone that provides an implementation, e.g. GlassFish?

@ivargrimstad
Copy link
Member

Looks good!
Only thing that is missing is a CI and a corresponding CCR

@m0mus
Copy link
Contributor Author

m0mus commented Jan 17, 2022

Looks good! Only thing that is missing is a CI and a corresponding CCR

It's done.

@ivargrimstad
Copy link
Member

ivargrimstad commented Jan 25, 2022

The SHA-256 doesn't match https://download.eclipse.org/ee4j/jakartaee-tck/jakartaee10/staged/eftl/jakarta-annotations-tck-2.1.0-tckinfo.txt

Should be: 875811dbc18353f74ff96afb7ced8fb6b4cfa02daac07806e6701f698e3a9d4b

Applies to the CCR and the TCK Results page

Copy link
Member

@ivargrimstad ivargrimstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Add the Compatible implementation under "Compatible Implementation used for ratification" as well as under Compatible Implementations.
  • Update the SHA-256 for the TCK results and in the CCR
  • Otherwise, everything looks fine!

annotations/2.1/_index.md Show resolved Hide resolved
annotations/2.1/_index.md Outdated Show resolved Hide resolved
Signed-off-by: Dmitry Kornilov <dmitry.kornilov@oracle.com>
@m0mus
Copy link
Contributor Author

m0mus commented Jan 26, 2022

@ivargrimstad All issues are addressed. Please re-review.

@ivargrimstad ivargrimstad self-requested a review January 26, 2022 16:48
Copy link
Member

@ivargrimstad ivargrimstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks @m0mus!
I'll get the ballot started shortly

@ivargrimstad ivargrimstad added the ballot Delivered to the Specification Committee for ballot label Jan 30, 2022
@ivargrimstad
Copy link
Member

Please delete the file .idea/misc.xml

Signed-off-by: Dmitry Kornilov <dmitry.kornilov@oracle.com>
@m0mus
Copy link
Contributor Author

m0mus commented Jan 31, 2022

Please delete the file .idea/misc.xml

Oooops...
Deleted

@ivargrimstad ivargrimstad added approved The ballot was approved by the Specification Committee and removed ballot Delivered to the Specification Committee for ballot labels Feb 9, 2022
@ivargrimstad ivargrimstad merged commit 6ea5510 into jakartaee:master Feb 9, 2022
@ivargrimstad
Copy link
Member

ivargrimstad commented Feb 9, 2022

  • adds this final checklist to the main PR.
  • adds the approved label to the PRs, and sends out the Ballot Summary per this template to the public Jakarta EE Specification Committee email list
  • calculates the staged EFTL TCK signature and promotes it to the committee download area
    using the https://ci.eclipse.org/jakartaee-spec-committee/job/promote-release/ job. Manually editing the jenkins Build Information will help identify the build (ie. Mail 2.0 or CDI 3.0).
  • merges the specification (and apidocs) PRs, ensuring the "date:" field in the _index.md file has an appropriate value to allow publishing.
  • updates the specification page with the ballot results. This is normally done via a separate PR that should be reviewed, approved, and merged.
  • notifies the EMO of the ballot results by email to emo@eclipse-foundation.org. Just forward the ballot summary note sent earlier to the public Spec Committee email list.
  • creates an issue in the specification project that includes the following checklist for the specification project team: Finalize Annotations 2.1 release common-annotations-api#100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved The ballot was approved by the Specification Committee release review Use this label on PRs that are filed for release review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants