New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jakarta Annotations 2.1 #437
Conversation
Signed-off-by: Dmitry Kornilov <dmitry.kornilov@oracle.com>
✔️ Deploy Preview for jakartaee-specifications ready! 🔨 Explore the source changes: ef6b448 🔍 Inspect the deploy log: https://app.netlify.com/sites/jakartaee-specifications/deploys/61f7b7d642a3130007ae884f 😎 Browse the preview: https://deploy-preview-437--jakartaee-specifications.netlify.app |
Spec Review Checklist
|
Add minutes from Nov 16 platform call
I am opening this PR for review. One note, there is no compatible implementation for Jakarta Annotations. So, I am leaving the compatible implementation check box unchecked. |
So, in order for the ballot to start we will need to find someone that provides an implementation, e.g. GlassFish? |
Looks good! |
It's done. |
The SHA-256 doesn't match https://download.eclipse.org/ee4j/jakartaee-tck/jakartaee10/staged/eftl/jakarta-annotations-tck-2.1.0-tckinfo.txt Should be: Applies to the CCR and the TCK Results page |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Add the Compatible implementation under "Compatible Implementation used for ratification" as well as under Compatible Implementations.
- Update the SHA-256 for the TCK results and in the CCR
- Otherwise, everything looks fine!
Signed-off-by: Dmitry Kornilov <dmitry.kornilov@oracle.com>
@ivargrimstad All issues are addressed. Please re-review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now, thanks @m0mus!
I'll get the ballot started shortly
Please delete the file .idea/misc.xml |
Signed-off-by: Dmitry Kornilov <dmitry.kornilov@oracle.com>
Oooops... |
|
Signed-off-by: Dmitry Kornilov dmitry.kornilov@oracle.com
Specification PR template
When creating a specification project release review, create PRs with the content defined as follows.
Include the following in the PR:
https://github.com/jakartaee/specification-committee/blob/master/spec_page_template.md
Instructions MAY be by reference.
https://projects.eclipse.org/projects/ee4j.ca/releases/2.1
https://jakarta.oss.sonatype.org/content/repositories/staging/jakarta/annotation/jakarta.annotation-api/2.1.0/
https://download.eclipse.org/ee4j/jakartaee-tck/jakartaee10/staged/eftl/jakarta-annotations-tck-2.1.0.zip
Compatibility Certification Request for Eclipse GlassFish 7.0.0-M1 common-annotations-api#98
If desired, an optional second PR can be created to contain just the JavaDoc in the
apidocs
directory.Note: If any item does not apply, check it and mark N/A below it.