Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jakarta XML WS 4.0 spec #445

Merged
merged 4 commits into from Apr 7, 2022
Merged

Jakarta XML WS 4.0 spec #445

merged 4 commits into from Apr 7, 2022

Conversation

lukasj
Copy link
Contributor

@lukasj lukasj commented Jan 11, 2022

Signed-off-by: Lukas Jungmann lukas.jungmann@oracle.com

Specification PR template

When creating a specification project release review, create PRs with the content defined as follows.

Include the following in the PR:

Note: If any item does not apply, check it and mark N/A below it.

Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
@netlify
Copy link

netlify bot commented Jan 11, 2022

✔️ Deploy Preview for jakartaee-specifications ready!

🔨 Explore the source changes: 00086ef

🔍 Inspect the deploy log: https://app.netlify.com/sites/jakartaee-specifications/deploys/6216ac319090b9000839dcc2

😎 Browse the preview: https://deploy-preview-445--jakartaee-specifications.netlify.app

@ivargrimstad ivargrimstad added the release review Use this label on PRs that are filed for release review label Jan 23, 2022
Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
@lukasj lukasj marked this pull request as ready for review March 20, 2022 08:38
@lukasj
Copy link
Contributor Author

lukasj commented Mar 20, 2022

this is now ready for review

@edbratt
Copy link
Contributor

edbratt commented Mar 23, 2022

I've been asked to assist in the Mentor review of this Specification.
Convenience link to the Preview rendering:
https://deploy-preview-445--jakartaee-specifications.netlify.app/specifications/xml-web-services/4.0/
I will be using the following checklist to verify that we have received all required contents:

Spec Review Checklist

  1. Spec PR
  1. _index.md
  1. javadocs
  • Footer contains Eclipse copyright and link to license
  • ESFL license is included, usually as doc-files/speclicense.html
  • no META-INF directory in PR
  • javadocs-jar artifact matches apidocs (optional for this release)
  1. Spec PDF
  • Correct spec title
  • Version number of the form x.y, not x.y.z
  • Correct Eclipse copyright line
  • No DRAFT or SNAPSHOT
  • Correct Logo
  1. Spec HTML
  • Same as PDF
  1. TCK zip file
  • README file (optional for this release)
  • EFTL license file, preferably named LICENSE.md
  • User's Guide (or equivalent documentation)
  • How to test the Compatible Implementation(s) listed in _index.md above with the TCK (may be in UG)
  1. TCK User's Guide (or equivalent documentation)
  • Software requirements listed
  • Installation and configuration described
  • How to run tests
  • Where to file challenges
  1. Compatibility certification request
  • Request follows template
  • SHA-256 fingerprint matches staged TCK zip file
  • Request issue has certification label.
  1. TCK results summary
  • Page is hosted by Compatible Implementation project
  • Includes all information from certification request
  • Summary includes number of tests passed, failed, errors
  • SHA-256 fingerprint matches staged TCK zip file on cert request
  1. If a Release Review is required, the specification project team contacts the EMO to initiate the review by sending an email to emo@eclipse.org.
    (A Release Review is not required if the current release is a Service Release based on a previously successful Major or Minor
    release as indicated by a release record on the project's Releases page, e.g., the Jakarta Servlet releases page.)

  2. Update Jakarta EE API jar

  • Update the Jakarta EE API jar by submitting a PR to the jakartaee-api project that updates the version number of your API jar file.

Copy link
Contributor

@edbratt edbratt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR itself looks good. All checklist items appear to be satisfied. Thank you.

@edbratt
Copy link
Contributor

edbratt commented Apr 6, 2022

Congratulations, the release ballot has successfully concluded. We must now complete this final checklist:


To finalize this specification, the committer members must

  • promote api staging release, promote the specification api jars to maven central. An example release job script can be found here https://wiki.eclipse.org/MavenReleaseScript.
  • go through the merged jakarta.ee specification website page to verify all the links are valid.
  • if XML Schemas are published on https://jakarta.ee/schemas, send a PR to update the status from Draft to Final.
  • approve the compatibility request.
  • The compatible implementation project/vendor MUST send an email to tck@eclipse.org for approval of the compatible implementation for trademark usage.
  • merge any final release branch as appropriate for the branch management for the project.
  • Confirm that the project has updated the Jakarta EE API jar by submitting a PR to the jakartaee-api project that updates the version number of your API jar file.

@edbratt edbratt added approved The ballot was approved by the Specification Committee and removed release review Use this label on PRs that are filed for release review labels Apr 6, 2022
@edbratt edbratt merged commit e9ebf79 into jakartaee:master Apr 7, 2022
@edbratt edbratt added complete All specification tasks for release are complete release review Use this label on PRs that are filed for release review labels Apr 7, 2022
@lukasj lukasj deleted the xmlws40 branch April 21, 2022 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved The ballot was approved by the Specification Committee complete All specification tasks for release are complete release review Use this label on PRs that are filed for release review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants