Adding reset button #142
Merged
Adding reset button #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
src/js/page/ui/settings.js
Outdated
| @@ -17,6 +18,10 @@ export default class Settings extends EventEmitter { | |||
| document.querySelectorAll('.settings .global input') | |||
| ); | |||
|
|
|||
| this._resetRipple = new Ripple(); | |||
| const resetBtn = document.querySelector('.setting-reset'); | |||
| resetBtn.appendChild(this._resetRipple.container); | |||
There was a problem hiding this comment.
Personally I find it a bit weird that the reset button itself is not on this but its ripple effect is. Perhaps ripple can be triggered in the local event listener, or a separate even listener?
There was a problem hiding this comment.
Looks like I put stuff on this even if it isn't used outside of the constructor. That seems like a weird thing for past-me to do, but I'll keep doing it for consistency.
ericcornelissen
approved these changes
Aug 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.