Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAdding reset button #142
Conversation
ericcornelissen
reviewed
Aug 7, 2018
src/js/page/ui/settings.js
Outdated
| @@ -17,6 +18,10 @@ export default class Settings extends EventEmitter { | |||
| document.querySelectorAll('.settings .global input') | |||
| ); | |||
|
|
|||
| this._resetRipple = new Ripple(); | |||
| const resetBtn = document.querySelector('.setting-reset'); | |||
| resetBtn.appendChild(this._resetRipple.container); | |||
This comment has been minimized.
This comment has been minimized.
ericcornelissen
Aug 7, 2018
Personally I find it a bit weird that the reset button itself is not on this but its ripple effect is. Perhaps ripple can be triggered in the local event listener, or a separate even listener?
This comment has been minimized.
This comment has been minimized.
jakearchibald
Aug 7, 2018
Author
Owner
Looks like I put stuff on this even if it isn't used outside of the constructor. That seems like a weird thing for past-me to do, but I'll keep doing it for consistency.
This comment has been minimized.
This comment has been minimized.
ericcornelissen
approved these changes
Aug 7, 2018
jakearchibald
merged commit 1f2e05d
into
master
Aug 7, 2018
jakearchibald
deleted the
reset-settings
branch
Aug 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
jakearchibald commentedAug 7, 2018
No description provided.