Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding reset button #142

Merged
merged 3 commits into from Aug 7, 2018
Merged

Adding reset button #142

merged 3 commits into from Aug 7, 2018

Conversation

@jakearchibald
Copy link
Owner

@jakearchibald jakearchibald commented Aug 7, 2018

No description provided.

@jakearchibald jakearchibald mentioned this pull request Aug 7, 2018
2 of 6 tasks complete
@@ -17,6 +18,10 @@ export default class Settings extends EventEmitter {
document.querySelectorAll('.settings .global input')
);

this._resetRipple = new Ripple();
const resetBtn = document.querySelector('.setting-reset');
resetBtn.appendChild(this._resetRipple.container);

This comment has been minimized.

@ericcornelissen

ericcornelissen Aug 7, 2018

Personally I find it a bit weird that the reset button itself is not on this but its ripple effect is. Perhaps ripple can be triggered in the local event listener, or a separate even listener?

This comment has been minimized.

@jakearchibald

jakearchibald Aug 7, 2018
Author Owner

Looks like I put stuff on this even if it isn't used outside of the constructor. That seems like a weird thing for past-me to do, but I'll keep doing it for consistency.

This comment has been minimized.

@ericcornelissen

ericcornelissen Aug 7, 2018

Haha, alright 👍

@jakearchibald jakearchibald merged commit 1f2e05d into master Aug 7, 2018
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@jakearchibald jakearchibald deleted the reset-settings branch Aug 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants