Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module paths should all be lower case #1

Open
KateGo520 opened this issue Jul 31, 2020 · 5 comments
Open

module paths should all be lower case #1

KateGo520 opened this issue Jul 31, 2020 · 5 comments

Comments

@KateGo520
Copy link

Background

Module path is inconsistent with go import path.
GO111MODULE=on, as doc said, import "github.com/JakeHL/Goid", then get this error:

go: finding module for package github.com/JakeHL/Goid
go: downloading github.com/JakeHL/Goid v1.1.0
go: found github.com/JakeHL/Goid in github.com/JakeHL/Goid v1.1.0
go: test1 imports
        github.com/JakeHL/Goid: github.com/JakeHL/Goid@v1.1.0: parsing go.mod:
        module declares its path as: github.com/jakehl/goid
                but was required as: github.com/JakeHL/Goid 

Solution

Fix the module path:

  1. Rename the module path to "github.com/JakeHL/Goid": https://github.com/JakeHL/Goid/blob/master/go.mod#L1
module github.com/JakeHL/Goid
  1. Change the doc document to use import "github.com/jakehl/goid".
@KateGo520
Copy link
Author

@jakeHL Could you help me review this issue? Thx :p

@fgm
Copy link

fgm commented Apr 8, 2022

More idiomatically, the repo path should be the lowercase version.

@jakenvac
Copy link
Owner

jakenvac commented Apr 8, 2022

hey sorry, I've not touched this project in a little while and my go is a little Rusty. feel free to submit a PR or i can take a look later.

@jakenvac jakenvac changed the title Module path should be "github.com/JakeHL/Goid", not "github.com/jakehl/goid" module paths should all be lower case Apr 8, 2022
@fgm
Copy link

fgm commented Apr 11, 2022

Hi @jakeHL thanks for considering the issue. Do you want it to go apply to the renamed repo, or to the existing non-idiomatic mixed-case repo name ?

@jakenvac
Copy link
Owner

I think the idiomatic approach would be best. people build habbits around idioms 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants