Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more details about the error if the compilation failed #81

Merged
merged 1 commit into from Mar 21, 2019

Conversation

Projects
None yet
2 participants
@minhtuannguyen
Copy link
Contributor

minhtuannguyen commented Mar 15, 2019

Currently the error message looks like this:

Error refreshing environment: Syntax error compiling at (a/b/c/namespace.clj:80:7).

It's useful to add the error cause why is failed. i.e

Error refreshing environment: Syntax error compiling at (a/b/c/namespace.clj:80:7). java.lang.RuntimeException: Unable to resolve symbol: x in this context

@minhtuannguyen minhtuannguyen changed the title Ddd more details about the error if the compilation failed Add more details about the error if the compilation failed Mar 15, 2019

@jakemcc

This comment has been minimized.

Copy link
Owner

jakemcc commented Mar 18, 2019

@jakemcc

This comment has been minimized.

Copy link
Owner

jakemcc commented Mar 18, 2019

@minhtuannguyen

This comment has been minimized.

Copy link
Contributor Author

minhtuannguyen commented Mar 18, 2019

Thank you for your reply. My setup is clojure 1.11 with Leiningen 2.9.1

@minhtuannguyen

This comment has been minimized.

Copy link
Contributor Author

minhtuannguyen commented Mar 18, 2019

I also noticed that the error message got bad since I upgrade to clojure 1.9

@jakemcc jakemcc merged commit 7e1db6b into jakemcc:master Mar 21, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jakemcc

This comment has been minimized.

Copy link
Owner

jakemcc commented Mar 21, 2019

Released in version 0.24.0. Thanks for the contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.